#metabrainz

/

      • fletchto99 has quit
      • 2023-08-01 21318, 2023

      • s1b1 has quit
      • 2023-08-01 21341, 2023

      • s1b1 joined the channel
      • 2023-08-01 21334, 2023

      • Clint has quit
      • 2023-08-01 21342, 2023

      • Clint joined the channel
      • 2023-08-01 21315, 2023

      • elomatreb[m] joined the channel
      • 2023-08-01 21336, 2023

      • FraYoshi[m] joined the channel
      • 2023-08-01 21336, 2023

      • yyoung[m] joined the channel
      • 2023-08-01 21337, 2023

      • pixelpenguin joined the channel
      • 2023-08-01 21351, 2023

      • AbhinavOhri[m] joined the channel
      • 2023-08-01 21357, 2023

      • monkey
        aerozol: Hello! Welcome back:)
      • 2023-08-01 21357, 2023

      • monkey
        Yes, we will want mockups for LB radio ! :)
      • 2023-08-01 21357, 2023

      • monkey
        We're still in the development process but it certainly won't hurt to get the ball rolling.
      • 2023-08-01 21307, 2023

      • mayhem
        but, just to be clear, my current work is not going to be subject to this mock-up. I'm building an unlinked page for testing purposes.
      • 2023-08-01 21327, 2023

      • reosarevok
        Pratha-Fish: can you rebase https://github.com/metabrainz/musicbrainz-bot/pul… on top of current master?
      • 2023-08-01 21337, 2023

      • reosarevok
        (just skipping the now dupe commit should be fine)
      • 2023-08-01 21359, 2023

      • reosarevok
        bitmap: what are the plans for release editor reactification?
      • 2023-08-01 21327, 2023

      • reosarevok
        It would be nice to implement something like MBS-13200 but it might be worth waiting for it if it / alternative tracklists in React are coming soon rather than doing the work twice
      • 2023-08-01 21327, 2023

      • BrainzBot
        MBS-13200: Allow entering several languages/scripts for a release https://tickets.metabrainz.org/browse/MBS-13200
      • 2023-08-01 21320, 2023

      • mayhem
        monkey: when you have a moment, I could use some help adapting the code from the codepen to our codebase. loads of errors that make no sense to me.
      • 2023-08-01 21330, 2023

      • monkey
        mayhem: I'll be at the office later today, maybe around 3:30 or so. We can look at it together then if that works for you
      • 2023-08-01 21354, 2023

      • mayhem
        I think these might be easy for you to diagnose. let me post a gist
      • 2023-08-01 21311, 2023

      • mayhem
      • 2023-08-01 21303, 2023

      • mayhem
      • 2023-08-01 21350, 2023

      • lucifer
        mayhem: want me to fix those?
      • 2023-08-01 21300, 2023

      • monkey
        Right, this is where Typescript typing comes in.
      • 2023-08-01 21300, 2023

      • monkey
        You'll need to create a new type representing the props that each component receives.
      • 2023-08-01 21300, 2023

      • monkey
        Have a look at this example from the codebase: https://github.com/metabrainz/listenbrainz-server…
      • 2023-08-01 21302, 2023

      • mayhem
        sure, why not.
      • 2023-08-01 21312, 2023

      • mayhem
        yeah, I just realized that. I can do those.
      • 2023-08-01 21322, 2023

      • mayhem
        how about the form element one?
      • 2023-08-01 21339, 2023

      • mayhem
        that one I have no clue about. but will create new types now that I looked at my old code.
      • 2023-08-01 21346, 2023

      • monkey
        And same for the `prompt` it should be `(prompt:string)`
      • 2023-08-01 21300, 2023

      • monkey
        For the form
      • 2023-08-01 21336, 2023

      • monkey
        Hm, let me see.
      • 2023-08-01 21322, 2023

      • mayhem
        i dont understand where to pub `(prompt:string)`
      • 2023-08-01 21325, 2023

      • mayhem
        put
      • 2023-08-01 21311, 2023

      • monkey
        in generatePlaylistCallback: `async (prompt:string) => { `
      • 2023-08-01 21341, 2023

      • mayhem
        thx
      • 2023-08-01 21350, 2023

      • lucifer
        its only one field so you can use a state var for prompt
      • 2023-08-01 21328, 2023

      • mayhem
        ok
      • 2023-08-01 21330, 2023

      • mayhem
      • 2023-08-01 21339, 2023

      • mayhem
        for an array of strings, what should the type decl be?
      • 2023-08-01 21355, 2023

      • lucifer
      • 2023-08-01 21308, 2023

      • lucifer
        string[]
      • 2023-08-01 21353, 2023

      • monkey
        mayhem: For the form event, there is a gotcha I forgot that makes typescript unhappy. it should be: `const form = event.currentTarget;` instead of `const form = event.target;`
      • 2023-08-01 21340, 2023

      • mayhem
        what should be the type of
      • 2023-08-01 21342, 2023

      • mayhem
      • 2023-08-01 21351, 2023

      • mayhem
        onGenerate, since it is a function ref
      • 2023-08-01 21335, 2023

      • monkey
        `onGenerate: (prompt:string) => void;`
      • 2023-08-01 21328, 2023

      • mayhem
        getting there, down to three errors:
      • 2023-08-01 21330, 2023

      • mayhem
      • 2023-08-01 21334, 2023

      • mayhem
        updated code pushed.
      • 2023-08-01 21312, 2023

      • mayhem
        fixed error on line 118. Needed s/{}/""/g
      • 2023-08-01 21343, 2023

      • mayhem fixes the const form = event.currentTarget;` again, but still no luck
      • 2023-08-01 21356, 2023

      • mayhem fixes the error on line 66
      • 2023-08-01 21331, 2023

      • mayhem
        monkey: latest code pushed, stumped on this last one:
      • 2023-08-01 21333, 2023

      • mayhem
      • 2023-08-01 21337, 2023

      • mayhem fetches noms
      • 2023-08-01 21354, 2023

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
      • 2023-08-01 21306, 2023

      • reosarevok
        zas: what time was this server update today?
      • 2023-08-01 21343, 2023

      • mayhem
        in 1 hour and 17 minutes.
      • 2023-08-01 21329, 2023

      • reosarevok
        Ok, when is the announcement happening? on the hour?
      • 2023-08-01 21305, 2023

      • mayhem
        I suggested that we take the first hour and tweet and then prep all of our stuff. ideally finish before the end of the first hour, then wait until the top of the hour.
      • 2023-08-01 21318, 2023

      • mayhem
        16:00UTC. then start the update.
      • 2023-08-01 21344, 2023

      • mayhem
        anyone with some react knowledge available to help me with (hopefully) a quick question?
      • 2023-08-01 21347, 2023

      • mayhem
        lucifer, akshaaatt ?
      • 2023-08-01 21341, 2023

      • akshaaatt
        Sure mayhem. Ask
      • 2023-08-01 21314, 2023

      • mayhem
        thx
      • 2023-08-01 21304, 2023

      • mayhem
        in the template for serving a react page there is this block:
      • 2023-08-01 21306, 2023

      • mayhem
      • 2023-08-01 21335, 2023

      • mayhem
        lb-radio.js --- I see it into two manifest files, but how does a .tsx file become a js file in the dist dir?
      • 2023-08-01 21359, 2023

      • reosarevok
        I expect something like babel builds it into pure js
      • 2023-08-01 21319, 2023

      • mayhem
        but i gotta tell babel something, no?
      • 2023-08-01 21335, 2023

      • akshaaatt
        I’ll have to get to the codebase to point you to where we do this configuration
      • 2023-08-01 21324, 2023

      • akshaaatt is watching oppenheimer right now
      • 2023-08-01 21345, 2023

      • mayhem
        ha, ok, enjoy
      • 2023-08-01 21305, 2023

      • lucifer
        mayhem: yes
      • 2023-08-01 21318, 2023

      • mayhem
        lucifer: see above, plz
      • 2023-08-01 21319, 2023

      • lucifer
      • 2023-08-01 21331, 2023

      • mayhem
        thanks!
      • 2023-08-01 21343, 2023

      • akshaaatt
        listenbrainz/webserver/static_manager.py
      • 2023-08-01 21328, 2023

      • akshaaatt
        Noice. lucifer got it
      • 2023-08-01 21337, 2023

      • mayhem
        yerp. thanks though.
      • 2023-08-01 21307, 2023

      • mayhem
        awww yiss, page loaded. thanks akshaaatt & lucifer
      • 2023-08-01 21329, 2023

      • mayhem
        lucifer: can you please help me with this other issue that I've been stumped on?
      • 2023-08-01 21331, 2023

      • mayhem
      • 2023-08-01 21349, 2023

      • mayhem
      • 2023-08-01 21353, 2023

      • lucifer
        mayhem: try `(promptText as any) as string`
      • 2023-08-01 21336, 2023

      • mayhem
        where exactly?
      • 2023-08-01 21351, 2023

      • lucifer
        line 65 inside onGenerate
      • 2023-08-01 21317, 2023

      • mayhem
        compiles now!
      • 2023-08-01 21318, 2023

      • lucifer
        yup its a quick fix. for the proper fix, i would suggest use a state variable and drop formdata altogether.
      • 2023-08-01 21350, 2023

      • mayhem
        I think a quick fix is fine, this is not intended to be a permanent page.
      • 2023-08-01 21350, 2023

      • zas
        bitmap: around?
      • 2023-08-01 21328, 2023

      • bitmap
        zas: hi
      • 2023-08-01 21342, 2023

      • zas
        let's start with non-critical/redundant servers
      • 2023-08-01 21322, 2023

      • bitmap
        ok
      • 2023-08-01 21327, 2023

      • bitmap
        aphex first?
      • 2023-08-01 21328, 2023

      • zas
        Here is a list of all servers running docker -> https://github.com/metabrainz/metabrainz-ansible/…
      • 2023-08-01 21315, 2023

      • zas
        I upgrade packages on all servers first, should be quick
      • 2023-08-01 21319, 2023

      • zas
        then aphex
      • 2023-08-01 21302, 2023

      • bitmap
        I stopped the MB containers on aphex, so whenever you're ready
      • 2023-08-01 21322, 2023

      • zas
        hmmm there's a failure on JacksonFive regarding apt, but I'll look into this later
      • 2023-08-01 21327, 2023

      • zas
      • 2023-08-01 21338, 2023

      • zas
        ready for aphex?
      • 2023-08-01 21316, 2023

      • bitmap
        yep
      • 2023-08-01 21317, 2023

      • zas
        rebooting aphex
      • 2023-08-01 21318, 2023

      • zas
        which one next?
      • 2023-08-01 21335, 2023

      • zas
        aphex is back
      • 2023-08-01 21358, 2023

      • lucifer
        zas: i'll fix that jackson5 issue
      • 2023-08-01 21315, 2023

      • zas
        lucifer: that's something to fix in ansible
      • 2023-08-01 21327, 2023

      • bitmap
        hip next, I'll let you knwo when it's ready
      • 2023-08-01 21327, 2023

      • lucifer
        ah! okay
      • 2023-08-01 21355, 2023

      • zas
        lucifer: is that a specific config you did recently on spark servers?
      • 2023-08-01 21310, 2023

      • lucifer
        zas: nope it predates ansible.
      • 2023-08-01 21331, 2023

      • lucifer
        that repo needs to be replaced with a newer one.
      • 2023-08-01 21342, 2023

      • zas
        ok, so I guess you can fix it, but we'll have to manage this with ansible later
      • 2023-08-01 21359, 2023

      • bitmap
        zas: hip ready
      • 2023-08-01 21308, 2023

      • zas
        ok, rebooting hip
      • 2023-08-01 21345, 2023

      • zas
        bitmap: I'll do moroder too, that's mainly metrics / alerts server, so users shouldn't be impacted
      • 2023-08-01 21306, 2023

      • bitmap
        👍
      • 2023-08-01 21320, 2023

      • zas
        let's wait for hip to come back first
      • 2023-08-01 21333, 2023

      • zas
        hip is back
      • 2023-08-01 21307, 2023

      • zas
        rebooting moroder
      • 2023-08-01 21308, 2023

      • zas
        bitmap: can we reboot sentry next?
      • 2023-08-01 21304, 2023

      • zas
        moroder is back
      • 2023-08-01 21305, 2023

      • zas
        reosarevok: can you tweet about downtime?
      • 2023-08-01 21310, 2023

      • bitmap
        sure, I guess sentry is on the cloud?
      • 2023-08-01 21312, 2023

      • reosarevok
        I can!
      • 2023-08-01 21319, 2023

      • reosarevok
        How long, and starting when?
      • 2023-08-01 21322, 2023

      • reosarevok
        On the hour, right?
      • 2023-08-01 21326, 2023

      • bitmap
        zas: you can reboot ludwig too
      • 2023-08-01 21331, 2023

      • zas
        reosarevok: yup
      • 2023-08-01 21356, 2023

      • mayhem
        reosarevok: on the hour for an hour.
      • 2023-08-01 21301, 2023

      • reosarevok
        Ok
      • 2023-08-01 21302, 2023

      • mayhem
        I'll tweet LB
      • 2023-08-01 21317, 2023

      • reosarevok
        Really expecting it to be that long, or is that just a very conservative estimat?
      • 2023-08-01 21319, 2023

      • reosarevok
        *e
      • 2023-08-01 21337, 2023

      • mayhem
        somewhere in between.
      • 2023-08-01 21351, 2023

      • mayhem
        if we promise 20 minutes, we take an hour.
      • 2023-08-01 21307, 2023

      • zas
        rebooting sentry
      • 2023-08-01 21315, 2023

      • zas
        next will be ludwig
      • 2023-08-01 21340, 2023

      • reosarevok
        "We're going down for maintenance at 15 UTC (in 15 minutes or so). We're expecting to take at most an hour, but we'll let you know when we're back. Sorry for the inconvenience!" ?
      • 2023-08-01 21314, 2023

      • mayhem
        sure
      • 2023-08-01 21310, 2023

      • reosarevok
        Done
      • 2023-08-01 21324, 2023

      • mayhem
        done for LB.
      • 2023-08-01 21332, 2023

      • zas
        sentry is back, ludwig rebooting
      • 2023-08-01 21314, 2023

      • zas
        bitmap: I think we can do zappa too, I think everything is redundant on it
      • 2023-08-01 21349, 2023

      • bitmap
        yea, paco too (just jenkins is non-redundant)