Aw but also yay finally some critical feedback *rubs hands together*
2023-08-04 21600, 2023
aerozol
I’m not sure I understand the note about ’below the top bar’ though? Can anyone parse that?
2023-08-04 21629, 2023
jasje
aerozol: maybe move the sign in and search bar into the top bar aswell if you can
2023-08-04 21644, 2023
jasje
I’ve been getting confused all over the place
2023-08-04 21626, 2023
d4rkie_ joined the channel
2023-08-04 21640, 2023
d4rkie has quit
2023-08-04 21642, 2023
aerozol
Hmm, I’ll sleep on it (not sure if we’re revisiting that design atm, depends on what monkey’s up to too)
2023-08-04 21637, 2023
aerozol
I can’t find a ticket for being able to re-arrange tracks easier (not having to click the up/down button a hundred times), e.g. drag and drop. There must be one… can anyone find it?
2023-08-04 21656, 2023
fletchto99 has quit
2023-08-04 21615, 2023
fletchto99 joined the channel
2023-08-04 21600, 2023
fletchto99 has quit
2023-08-04 21616, 2023
fletchto99 joined the channel
2023-08-04 21608, 2023
mayhem
lucifer: any idea why the spark cluster is still unhappy?
2023-08-04 21627, 2023
lucifer
mayhem: dumps issue?
2023-08-04 21636, 2023
mayhem
yeah
2023-08-04 21602, 2023
lucifer
it usually resolves by 3rd when dumps have been imported but hasn't yet so i'll check .
[troi-recommendation-playground] 14mayhem opened pull request #106 (03main…add-user-stats-entity): Add stats, collection and recs entities, improve docs, break out classes https://github.com/metabrainz/troi-recommendation…
2023-08-04 21659, 2023
mayhem
lucifer: ^^ this PR looks long, but a chunk of it is code-refactor so its not as bad as it seems.
2023-08-04 21643, 2023
lucifer
mayhem: on it
2023-08-04 21650, 2023
mayhem
thanks!@
2023-08-04 21619, 2023
mayhem
monkey: you about?
2023-08-04 21644, 2023
monkey
I am about indeed
2023-08-04 21654, 2023
monkey
about this tall <----------------->
2023-08-04 21621, 2023
mayhem
pretty wide for a monkey
2023-08-04 21632, 2023
monkey
mayhem: I pushed two commits for the notifications container and brainzplayer. I'm going to take some more time to implement the feedback stuff properly in a more reusable manner
is there any case where a feed event is hideable but not deleteable.
2023-08-04 21658, 2023
jasje
So far, only events that can be deleted are the ones the user himself produces
2023-08-04 21615, 2023
jasje
and hideables are the ones that other user produce
2023-08-04 21619, 2023
jasje
lucifer^^
2023-08-04 21610, 2023
jasje
notification is one anomaly
2023-08-04 21621, 2023
jasje
it is produced by troi bot
2023-08-04 21626, 2023
jasje
but can be deleted by user.\
2023-08-04 21605, 2023
monkey
Why is that? Wouldn't it be simpler that "only events that can be deleted are the ones the user himself produces" as you say?
2023-08-04 21619, 2023
monkey
Sorry, I might be missing some context here, I haven't been following this project along
2023-08-04 21601, 2023
monkey
mayhem: some troi code is throwing an error and making my LB web component crash on startup, even after rebuilding the docker image. I've seen this one before, not sure how to resolve. It's been happening more and more; anything you or lucifer can do to make these changes not crash please?
This is on your `lb-radio-testing-interface` branch, up to date with remote
2023-08-04 21638, 2023
monkey
It currently takes me ~10 minutes to build the docker image so I'm not keen on trying random rebuilds
2023-08-04 21647, 2023
mayhem
sorry, but I need to step away right now.
2023-08-04 21600, 2023
mayhem
is there more context around that error?
2023-08-04 21602, 2023
monkey
Okidoke.
2023-08-04 21611, 2023
mayhem
give me more context and I will have a look when I return in a couple of hours.
2023-08-04 21614, 2023
mayhem
sorry.
2023-08-04 21617, 2023
monkey
I commented out the whole route in order to test my other changes I was working on. OK for now
2023-08-04 21629, 2023
mayhem
ok
2023-08-04 21616, 2023
lucifer
jasje: i am not sure, will have to check event manually.
2023-08-04 21627, 2023
lucifer
monkey: which branch?
2023-08-04 21646, 2023
monkey
`lb-radio-testing-interface`
2023-08-04 21640, 2023
jasje
monkey: yes that is true + notifications (not produced by user) are an exception
2023-08-04 21655, 2023
jasje
is there any other exception
2023-08-04 21659, 2023
jasje
lucifer: okeyss
2023-08-04 21600, 2023
monkey
I'm guessing requirements.txt should be updated, but I'm confused as to how it's working on rob's setup (unless he has uncommited requirements modifications)
the branch was updated on github and moved the files.
2023-08-04 21617, 2023
lucifer
but docker doesn't know about that.
2023-08-04 21632, 2023
lucifer
setting the exact commit will invalidate cache and rebuild.
2023-08-04 21601, 2023
monkey
Oooohh. I see, thanks for the help.
2023-08-04 21621, 2023
lucifer
just a sec, you may also need one more change
2023-08-04 21628, 2023
monkey
I don't see anything we can do to improve that then, other than me remembering to get the full commit hash
2023-08-04 21649, 2023
lucifer
yes, its recommended to always use the full commit hash.
2023-08-04 21607, 2023
lucifer
yeah i think that should work. if it doesn't, let me know and i can look further
2023-08-04 21610, 2023
monkey
Thx
2023-08-04 21643, 2023
monkey
I'm gonna keep my shitty workaround (commenting out the python code that uses the LBRadio patch) for now
2023-08-04 21643, 2023
vscode_
riksucks: and lucifer: any updates
2023-08-04 21645, 2023
vscode_
???
2023-08-04 21600, 2023
vscode_
on the questions I asked above
2023-08-04 21628, 2023
vscode_
Also I will not be able to attend Monday meeting where can I send the update?
2023-08-04 21648, 2023
lucifer
reosarevok: the review should be emailed to `reosarevok@metabrainz.org` right?
2023-08-04 21621, 2023
lucifer
vscode_: 1) for integrating the script in LB, it will run in a separate script like the existing spotify one. i am refactoring that script to allow for code reuse between the two services. i'll let you know once its done but for now its fine to work in a standalone script.
2023-08-04 21636, 2023
lucifer
for 2), i'll have to check apple music api docs.
2023-08-04 21646, 2023
lucifer
i'll get back to you on that.
2023-08-04 21659, 2023
reosarevok
lucifer: for the meeting?
2023-08-04 21614, 2023
reosarevok
community-manager@ ideally
2023-08-04 21600, 2023
lucifer
vscode_: for the storefront, i checked queried a random in two different storefronts and the data is same. except that the data has some links and those differ in url but point to same content. i also found https://developer.apple.com/documentation/applemu….
2023-08-04 21622, 2023
lucifer
i think let's start with a hardcoded storefront (`us`) seems fine.
2023-08-04 21638, 2023
lucifer
when we have collected a decent chunk of data, we can re-evaluate.
2023-08-04 21654, 2023
lucifer
reosarevok: yes, thanks
2023-08-04 21612, 2023
lucifer
vscode_: send your review as email to `community-manager@metabrainz.org`
2023-08-04 21613, 2023
reosarevok
Oh, I missed the previous message :) Yeah, do that - it's still me but others have access too In case I don't make it for whatever reason
2023-08-04 21649, 2023
monkey
lucifer: I'm refactoring the user feedback logic on LB frontend (making a custom hook so that we don't have to duplicate the logic on each page…) and I have a question:
