I'm working on the metadata cleaner again. and I am looking for examples of common useless guff that is found at the end of track names in parens.
e.g. (2018 remaster)
live, demo, master, remaster.
reosarevok
(bonus track)
or just (bonus)
mayhem
great, please send me more.
reosarevok
Arguably live or demo are not useless but I assume this is for some sort of canonical thing?
mayhem
not useless, but often not useful for finding a match.
this is to resolve a list of MBIDs to a local collection of files
arsh
mayhem: Sure I will starting on the feedback
mayhem
great.
and when you're done with that and are ready to improve the CSS, please ping monkey. He's volunteered to show you a few tricks to make the page look lots better with just a few changes.
monkey
"broad strokes" was the term I used I believe
mayhem
ok...
arsh
That’s great I will
mayhem
He's volunteered to show you a few tricks to make the broad strokes lots better with just a few changes.
better monkey?
monkey
He's volunteered to broad strokes a few strokes to broaden your strokes with just a few strokes.
mayhem
He's broadly stroked the broad strokes a few strokes to stoken your broads with just a few brokes.
yvanzo: also, https://tickets.metabrainz.org/browse/MBS-13233 seems a lot smaller than the others, wonder if it makes sense to do the autoselect - are we going to do that for every country's platform?
BrainzBot
MBS-13233: Autoselect the ticketing relationship for Eventfinda links
reosarevok
aerozol: ^ how big is that down there?
I'm thinking maybe it's enough for us to have a ticketing rel and people can hand-select it...
lucifer: I made some progress yesterday using react-testing-library along with Enzyme in our tests, as we discussed, and converted one test file (which took hours as I'm learning to use the library). Works a treat !
(i also had an open question on https://github.com/metabrainz/musicbrainz-serve... about whether the change would be accepted if i added more event handlers to completely emulate normal focus-cycling)
mayhem
zas: outsidecontext ^^
yvanzo
hi derat, thanks for contributions, will look into it
derat
yvanzo: thanks, much appreciated!
ssam joined the channel
(i've just been focusing on the UX things that i find most annoying when editing so far :-) )
yvanzo
(3006 depends on 3008 so I guess both will be reviewed at the same time)
derat
i think that they can be merged in an arbitrary order, but i wasn't sure if there's any way to express that. the roman numerals surprised me a bit, to be honest!
BrainzGit
[bookbrainz-site] 14architbaurai opened pull request #1008 (03master…BB-749): BB-749: Links that include "https://" as part of the non-protocol of the URL in Annotations break. https://github.com/metabrainz/bookbrainz-site/p...
yvanzo
derat: Ok but #3006 alone doesn’t resolve any issue, does it?
derat
yvanzo: #3006 enables tab, enter, tab, enter, etc. to be used to select the first recording for each track, which is the primary functionality i care about for MBS-13207. #3008 is nice to have since once the first recording has the focus, it fixes the normal radio button behavior of being able to use the arrow keys to select other recordings
derat: Ok I tested it locally and found a way to reproduce this specific issue separately :)
iconoclasthero joined the channel
derat: I tried the two patches together now and it makes funny things when using arrow keys to select the recording: the order of the suggested recordings may change.
derat
yvanzo: i'm not sure how #3006 could be contributing to that -- is it possible that you also see that just with #3008? i haven't been able to figure out how to test with a long list of recordings locally (probably because i don't have working search in my local setup), but i did notice some flickering that suggested to me that another search is
being performed whenever a new recording is selected. i'll try to see if i can repro what you're seeing locally...
Then track #1, there are 3 recordings for “Mr Self Destruct”.
You can switch the search field to use direct search (below when scrolling).
iconoclasthero has quit
(Direct search is a PG fallback when Solr isn’t available.)
derat
there must be something strange with my musicbrainz-docker setup. when i do the same thing, i see recordings listed in the dropdown after doing a direct search, but when i click one, it often doesn't show up as a radio button (although it *does* get associated with the track). this is without my changes
tbh, this seems a bit weird even on musicbrainz.org. when i create a new release as a dupe of an existing one, all of the tracks are associated with the expected recordings but the "edit" bubble for each only has a radio button for "Add a new recording". when i search for a track's name and click a recording, the track association is updated and
now there are radio buttons for both the original recording from the duplicated release and for "Add a new recording". if i click the original recording's radio button, the track association is updated and the recording that i selected previously gets a radio button too.
that is, i think i'm seeing exactly the behavior that you described on musicbrainz.org too. it's just a bit harder to trigger since you need to repeatedly click on radio buttons to focus them since the search field keeps stealing the focus
every time i click on a recording and then on "Add a new recording", the radio buttons get reshuffled. it looks like it's moving the last-selected recording up to the top of the list
yvanzo
derat: Correct, it’s just harder to trigger at the moment than with your patches, but definitely not cause by those. Will fill a separate issue about it.
bitmap: Please double-review derat’s PRs #3011, #3010, #3008 & #3006 when you have some time.
derat
yvanzo: thanks for all the comments! applying them now...
bitmap
i will try to check them today :)
aerozol
jasje: what new icon library are you using? Didn’t we already agree to using the same one as BookBrainz where possible, so we can start getting consistency across our platforms
The mention of animations causes me more concern than excitement ;D
Ah I see you and monkey have discussed it more (it looks), just catching up on chat now
derat has quit
outsidecontext: tweeted and reddit-ed re. 2.9.1, great job on the quick update! That shift+drag issue is a wild one!
tux0r
now mastodon it!
aerozol
tux0r: I was actually going to add some re. that to the next meeting :) But because of timezones and reo being away it would probably have to be the next one
(I have been reposting stuff to my personal mastodon account to test the waters)
tux0r
:-)
now that tweetdeck is dead as well, mastodon seems to be the last remaining alternative
(yes, kbin/firefish/misskey/.. exist and bluesky exists blah blah.. honestly, our bubble is on mastodon :p)
aerozol
I think there’s still a bunch of services vying to be the replacement, but basically I’ve decided that it’s not too much work to post to a bunch. But it does create more profiles for MeB to upkeep longterm so it’s not a no-brainer
tux0r
most of them use activitypub anyway
except bluesky
aerozol
Yeah, mastodon seems like “our” audience. But let’s not forget that we have a huge silent audience as well (the non-tech one). But I think we can hit both just fine
