oo seems nice but would'nt development become slow?
2023-09-19 26210, 2023
akshaaatt
Yes it will but it is a one time thing
2023-09-19 26214, 2023
jasje
if i need to change the components themselves
2023-09-19 26235, 2023
akshaaatt
Let me confirm with aerozol during the summit if he agrees with our color pallette, components etc
2023-09-19 26252, 2023
akshaaatt
These will be our brand identity and should not change for at least 2 years
2023-09-19 26211, 2023
akshaaatt
Doing dev work every 2 years would be fine
2023-09-19 26226, 2023
akshaaatt
But we need this if we want to maintain MB app also
2023-09-19 26235, 2023
akshaaatt
And give this as a refernce for iOS also
2023-09-19 26251, 2023
jasje
components for app aren't refined right now
2023-09-19 26259, 2023
jasje
we still have alot of use cases to cover
2023-09-19 26205, 2023
jasje
seems good on the outside
2023-09-19 26207, 2023
jasje
but
2023-09-19 26216, 2023
jasje
given the added complexity
2023-09-19 26232, 2023
akshaaatt
Yes, that is what the issue with having a DS is. But keep the components generic enough
2023-09-19 26242, 2023
jasje
I would be really dependent on you guys for any change
2023-09-19 26244, 2023
akshaaatt
We can extend the functionality in the app if need be
2023-09-19 26249, 2023
zas
akshaaatt: I will deploy your new key in few minutes
2023-09-19 26255, 2023
akshaaatt
Thanks zas!
2023-09-19 26217, 2023
akshaaatt
We have to make this move someday jasje, I fear we will end up getting really late and miss out and keep repeating things in every app.
2023-09-19 26219, 2023
akshaaatt
I see the need for MB app already. The design is outdated and makes me yawn to even think about fixing it
2023-09-19 26246, 2023
jasje
huh if you're going to bring in the mb app i see the advantages now
2023-09-19 26201, 2023
akshaaatt
yus exactly
2023-09-19 26232, 2023
zas
akshaaatt: done
2023-09-19 26233, 2023
jasje
but mb app heavily relies on website to do stuff
2023-09-19 26240, 2023
akshaaatt
Thanks zas!
2023-09-19 26245, 2023
jasje
thats a big turnoff for me
2023-09-19 26256, 2023
akshaaatt
Why jasje? We alreadt have many features in the app that people use
2023-09-19 26216, 2023
akshaaatt
Search, Barcode, Picard connectivity etc to name a few
2023-09-19 26221, 2023
akshaaatt
And those aren't going anywhere
2023-09-19 26241, 2023
jasje
Barcode and picard make sense
2023-09-19 26244, 2023
jasje
but
2023-09-19 26257, 2023
jasje
Search is something that is weak in the app rn
2023-09-19 26216, 2023
akshaaatt
Yeah we know that but it is still being used
2023-09-19 26222, 2023
jasje
and the MAIN thing, i.e., edit is not even on the app
2023-09-19 26230, 2023
jasje
its just go to website thing
2023-09-19 26237, 2023
akshaaatt
We are not fixing search there rn. We just need to maintain that app
2023-09-19 26210, 2023
akshaaatt
And make sure it moves along so that any dev in future can just pick it up and work on features instead of having to work about doing a revamp again and again
2023-09-19 26247, 2023
jasje
Um alright I think we can go along
2023-09-19 26256, 2023
akshaaatt
Great!
2023-09-19 26200, 2023
jasje
since I can see the Listen card being used everywhere
2023-09-19 26211, 2023
jasje
Plus the bottom nav and other stuff
2023-09-19 26214, 2023
akshaaatt
Let's keep this low priority and work on it in November or something
2023-09-19 26219, 2023
akshaaatt
Yus
2023-09-19 26234, 2023
akshaaatt
Just made sure I don't forget about it and made the addition
lucifer: ok, thanks for the updates. now -- thoughts on priorities?
2023-09-19 26254, 2023
mayhem
I think we should get the metadata viewer out, it should be a small task.
2023-09-19 26200, 2023
lucifer
mayhem: i think oauth, and wrapping up the 2 gsoc projects (apple music, labs api).
2023-09-19 26206, 2023
lucifer
yes that one makes sense too
2023-09-19 26206, 2023
mayhem
then we can ask akshaaatt to include it on the apps page.
2023-09-19 26224, 2023
mayhem
let me add labs api.
2023-09-19 26256, 2023
lucifer
i added it already
2023-09-19 26216, 2023
lucifer
point 5
2023-09-19 26218, 2023
lucifer
*6
2023-09-19 26237, 2023
mayhem
moved up.
2023-09-19 26204, 2023
mayhem
take a look now.
2023-09-19 26221, 2023
lucifer
looks good
2023-09-19 26227, 2023
mayhem
also, my plan to to review this document at the beginning of each month. in hopes up keeping it more up to date.
2023-09-19 26200, 2023
lucifer
yes makes esnse. i think we should have a monthly LB meeting
2023-09-19 26237, 2023
mayhem
lets we stopped doing those. lets have one starting in Nov. (because we're planning now and summit is in oct)
2023-09-19 26211, 2023
lucifer
yup that makes sense. summit will have a lb meet anyway
2023-09-19 26240, 2023
mayhem
ah yes.
2023-09-19 26253, 2023
mayhem
ok, I've got a calendar item to schedule a meeting each first of the month.
2023-09-19 26248, 2023
lucifer
sounds good.
2023-09-19 26238, 2023
lucifer
i looked at the roadmap and there's only similarity/popularity stuff that can be removed from the doc. which is pending for MLHD, currently only done for listens.
2023-09-19 26232, 2023
mayhem
ok, monkey and I will rework the rest of the doc now
2023-09-19 26233, 2023
mayhem
when monkey starts working on the album pages, we'll revisit which popularity data we may need that we dont have yet.
2023-09-19 26250, 2023
lucifer
makes sense
2023-09-19 26250, 2023
mayhem
and a prospective unicorn might be interested in some popularity data we dont have yet.
2023-09-19 26203, 2023
lucifer
ooooh mysterious
2023-09-19 26206, 2023
mayhem
also, the beatles problems.
2023-09-19 26214, 2023
lucifer
that might be the first LB client!
2023-09-19 26235, 2023
mayhem
oh, very good observation!
2023-09-19 26252, 2023
mayhem
I mean this client mostly needs MB data, but with some LB added in. but yes.
2023-09-19 26205, 2023
lucifer
yup makes sense
2023-09-19 26206, 2023
mayhem gently stuffs the 🦄 into the game bag
2023-09-19 26240, 2023
monkey
Mmmm, unicorn stuffing…
2023-09-19 26258, 2023
mayhem
the missing MB data page has a rendering problem currently:
mayhem: yes I know, that's for reference, I restarted sir
2023-09-19 26201, 2023
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #2580 (03master…add-listen-dropdown-resurrection): Resurrect "Add listen" dropdown menu in user dashboard https://github.com/metabrainz/listenbrainz-server…
2023-09-19 26227, 2023
mayhem
bitmap: reosarevok zas kellnerd : please add your arrival times to the summit wiki page so we know when to expect you.
mayhem: schedule didn't change since a long time, I think I have my train ticket since end of July and updated wiki asap. But yvanzo was unsure between 28 & 29, and decided to use the same train as me (which btw was only running every other day by this time, now they added more).
I tried to update the PR, and to re-run failed jobs, no success, and it doesn't fail at the same point each time
2023-09-19 26234, 2023
outsidecontext
zas: it worked previously. some networking thing again I guess
2023-09-19 26239, 2023
v6lur joined the channel
2023-09-19 26240, 2023
outsidecontext
what did you change on the code
2023-09-19 26245, 2023
outsidecontext
mayhem: will do
2023-09-19 26219, 2023
zas
outsidecontext: just expanded x = y if cond else z expression to make the code more readable and shorten lines, and dropped # nosec directive (since it was related to md5)
2023-09-19 26242, 2023
bitmap
zas: I'll work on replacing pink today
2023-09-19 26255, 2023
bitmap
mayhem: added
2023-09-19 26209, 2023
bitmap
zas: with serviceregistrator is there a way to "alias" a service name so it's available as two different names?
2023-09-19 26219, 2023
zas
bitmap: not at the moment. Also not sure 2 consul services can have common host/port, it would also duplicate health checks (not really an issue I think). Why do you want this?
rn if you want a direct connection to pg (not through pgbouncer) you use the postgres-master service. in the new setup this goes through haproxy, haproxy-postgres-primary
