#metabrainz

[listenbrainz-android] 14dependabot[bot] opened pull request #287 (03dev…dependabot/gradle/dev/com.airbnb.android-lottie-6.2.0): Bump com.airbnb.android:lottie from 6.1.0 to 6.2.0 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] opened pull request #288 (03dev…dependabot/gradle/dev/androidx.browser-browser-1.7.0): Bump androidx.browser:browser from 1.6.0 to 1.7.0 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] opened pull request #289 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-compose-2.7.0-rc01): Bump androidx.lifecycle:lifecycle-runtime-compose from 2.7.0-beta01 to 2.7.0-rc01 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] opened pull request #290 (03dev…dependabot/gradle/dev/com.airbnb.android-lottie-compose-6.2.0): Bump com.airbnb.android:lottie-compose from 6.1.0 to 6.2.0 https://github.com/metabrainz/listenbrainz-andr...

[listenbrainz-android] 14dependabot[bot] opened pull request #291 (03dev…dependabot/gradle/dev/com.android.tools.build-gradle-8.1.4): Bump com.android.tools.build:gradle from 8.1.3 to 8.1.4 https://github.com/metabrainz/listenbrainz-andr...

mooin!

lucifer: I didn't add that team to coreteam. too lazy to keep doing that, so I just made you Org Owner. go do it yourself. 😛

I'm still annoyed the Android app doesn't have a reference to Lt Commander Data

ApeKattQuest: that would be a good Easter egg

thanks mayhem!

atj: do you happen to have the logs from the uwsgi errors the other day?

lucifer: the best I have is this snippet I copied at the time https://www.irccloud.com/pastebin/MMb6Kd5J/

mayhem: ikr?

Got to see you using the app ApeKattQuest !

Good*

well..

i don't really get it

there was some sort of screen with moving images saying it can be used for these things i alreadyknew of. and thne asking ofr permissions wich i thikn i got right and after that it wantd to play music from where i don't know.

but when I tried using my music app (musicolet) it didn't seem to notice it

🤷

so...you liked it then

i don't really get it

:)

will it notice bandcamp app?

how can I make it understand musicolet? it plays and the song playing does show up in the notification part

place on the phone

and cna it run witouth having a banner where it wants to play whatever from.. i gues some music folder it scanned

I had the mp3 I use for ringtone, lol

it wants to work as a player (wich is fine) but i have my own player with my own set-up that i have fixed for this. i don't want it to fetch like, folders in various places that are things like music from games or apps or ringtones or what :D

having a "ignore this folder" would be good

even a bit where when yo ustart it it will ask you, "where do you keep music?" and thne you can tell it wich folder(s) to look at

whne you start it *first time

does the player have a "shuffle on album" feature? it needs that (one reason i used musicolet really, since apparently no other app did that)

idk if musicolet does it properly either. its hella complex :D

there should be a "listen to music from other apps in the background mode. and also you should tell it which apps to listen to. so it doesn't like, notice an alarm app or think some other random app is playing some music

i'd like it to only pay attention to bandcamp app and musicolet. probably not youtube

well that was my first impression. I'll try actually going into it later :D

ApeKattQuest: did you get to the part where you gave notification access to the app?

You can check by going to the settings page from the gear on the top bar

It has a section for Listening apps. You can check that list and confirm whether your apps are recognised properly

As for the music player.. that needs a revamp and your points are valid and should be fixed when we do that

alright! I'll test that next time I try the app!

hi , i was wondering where can i see the issues on which i can submit prs for ?

lookinto musicolet (I think it's open source?) it's very customisable

zcross: entire mebs is on github

we have a ticket tracker on jira

MBS-13090: [object Object] error on edit relationship screen

thanks

stick around and some one more knowledgable can help you further :)

I just needed to get to know from where can i pick up issues , I wanted to make some open source contributions.

atj, bitmap: https://github.com/metabrainz/artwork-redirect/...

also, zas maybe ^

"runit/systemd/systemv sees that consul-template has died so it restarts the consul-template process. This is evident from the following line of the log"

"2023/11/22 15:43:41 [DEBUG] (logging) enabling syslog on LOCAL0"

maybe if you're lucifer it's evident :P

atj: the line just after the log makes it evident to me.

but yes it might be that i am mistaken about it. i have been able to reproduce my hunch locally though.

lucifer reading the logs ;) https://usercontent.irccloud-cdn.com/file/fJJwS...

the more i read about consul-template the less i'm a fan. your explanation sounds pretty plausible.

the webp refuses to load for me on 3 different devices lol. all black.

atj: yeah i haven't been able to find out why consul-template interprets reload as exit

it's just a matrix screensaver :)

ahh!

i setup consul agent, consul-template, uwsgi demo app locally with some debug output

lucifer: i'll have a look at consul-template code to see if I can work out why it thinks the process has died

my interpretation of the log above https://www.irccloud.com/pastebin/9HQhOFbV/

it's probably sine unix signal nonsense due to SIGCHLD not being handled correctly

since this is local, there's no runit to restart consul-template again but that happens in prod and then the rest of the explanation in the comment follows.

s/sine/some/

oh i see, makes sense.

i was trying to read consul-template code as well but no success so far. go uhhhh

atj: is it possible to ask consul-template to run a command to reload the child process instead of sending a signal?

do you know what version of consul-template we're using?

0.33.0

lucifer: no i don't think it is possible, sadly

ah well :/

we could i guess write a wrapper script over uwsgi to capture SIGCHILD properly.

but would be better to eliminate consul-template totally if its easier.

ideally yes, but i'm not sure we have a good alternative at this point

i need to go now, will look into it more tomorrow.

sure thanks

atj: i think i figured it!!!

i straced the consul-template process and saw that it is sending the reload signal to all child processes.

see line 77 onwards.

reading consul-template docs and code, https://github.com/hashicorp/consul-template/bl...

"Note that on supporing systems (*nix, with sh) the setpgid flag is set on the exectution which ensures all signals are sent to all processes."

it is sending the signal to the entire process group.

as far as i understand from the docs and the code, it is not possible to disable this behaviour.

Yeah, I did read that

Just didn't think the worker's would die on SIGHUP

i reverted to a version of consul-template that doesn't do this. 0.18.5 the one we used previously.

it does not suffer from this issue because the SIGHUP is only sent to the master.

I wonder what the justification is for the change in behaviour

Good catch btw

>In the future it could be made configurable if needed.

yeah we need that or find a way to make uWSGI workers ignore SIGHUP

it seems that uWSGI internally also sends SIGHUP to its workers to gracefully shutdown so this needs to be fixed in consul-template itself

for the time being, i think --die-on-term is good enough because that's what is happening anyway with all these complex consul-template/uwsgi interactions.

nice find lucifer (I am glad MBS ditched consul-template...)

consul and consul-template aren't exactly my favourite pieces of software

bitmap: finally looking at https://github.com/metabrainz/musicbrainz-serve... - 1500 commits behind master :D

oof

probably no conflicts though :)

I was experimenting with an ansible role for deploying openresty on a completely separate server and somehow managed to take down CB due to consul-template DDoSing consul

Nah, not this time

when MBS used it it kept writing blank DBDefs.pm files, crashing the server, and also had the same issue with processes not dying -- probably the same as the uwsgi one

short of writing a wrapper around uwsgi I guess --die-on-term works (just not ideal since it may briefly cause 502s)

it still causes 502s because consul sends SIGHUPs to all child workers at once overriding the graceful reloads of uWSGI

yeah

removing consul-template is the only ideal solution tbh

bitmap: something like this inside run_in_transaction?

atj, bitmap: lolol reading the consul-template code, i found a fix. use `[]` format for commands instead of `""`. former disables setpgid behaviour.

tested on a local dev instance and it seems to work

wait what lol