#metabrainz

[metabrainz.org] 14amCap1712 opened pull request #451 (03master…upgrades): Upgrade python, consul-template, uWSGI https://github.com/metabrainz/metabrainz.org/pu...

[metabrainz.org] 14amCap1712 merged pull request #451 (03master…upgrades): Upgrade python, consul-template, uWSGI https://github.com/metabrainz/metabrainz.org/pu...

[metabrainz.org] 14amCap1712 merged pull request #450 (03master…which-is-becomes): Fixing small wording mess https://github.com/metabrainz/metabrainz.org/pu...

[metabrainz.org] release 03v-2023-11-28.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/metabrainz.org/re...

!m lucifer

You're doing good work, lucifer!

[listenbrainz-server] 14amCap1712 merged pull request #2624 (03master…dependabot/pip/pyarrow-14.0.1): Bump pyarrow from 10.0.1 to 14.0.1 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2642 (03master…dependabot/npm_and_yarn/adobe/css-tools-4.3.1): Bump @adobe/css-tools from 4.3.0 to 4.3.1 https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2636 (03master…fix-websockets): Fix websockets setup for development https://github.com/metabrainz/listenbrainz-serv...

lucifer: Triaged SEC tickets only 4 left :) includign 2 about werkzeug: https://tickets.metabrainz.org/issues/?filter=1...

yvanzo: thanks! taking a look

jasje: akshaaatt : how/when can I test the new LB app with the improved workflow??

I want to put up my #listenbrainzmonday but I get an error when I try to load time range ‘this week’ + template ‘designer top 10’ :(

“There was an error trying to load statistics for this user and time range: TypeError: Failed to fetch Please check the username or try another time range.”

Works fine when I enter another username

yea, works fine for me. lucifer? ^^

Does mine work if you put in ‘aerozol’ Rob?

Oh, looks like I somehow only listened to 8 albums this week… https://listenbrainz.org/user/aerozol/charts/?p...

That’s weird but I guess it’s possible :D

Maybe I was in a coma

seems to

so

The only broken one is template ‘designer top 10’

(I assume because I don’t have 10 albums)

inded, that borks.

how do you.. only listen to 10 albums.. in one whole week ??? :o

wait how does mine look

mostly for me, but this is the exception.

ApeKattQuest: Exactly!! How do you log a bug report for a human behavioural bug

mayhem: will fix

mayhem: should be on your device by the end of the week

we just have to update the beta app

👍

akshaaatt: is busy rn

mayhem: regarding the stats art error above: I had started PR LB#2595 if you think it it is relevant to add the fix to it

Art API: Add links and titles in generated stats art : https://github.com/metabrainz/listenbrainz-serv...

sounds like lucifer is on that. lucifer ^^

monkey: sure, i'll add the fix there

Thanks !

mayhem: release-colors cronjob for huesound has been broken for like ~4 months now. there was a simple bug in the program name to convert image to color, i fixed and ran the job, it worked fine but it refuses to terminate. probably an issue with concurrency, i am planning to rewrite it with a threadpoolexecutor.

I figured -- its taking some time to catch up -- I'm running it right now

its all caught up.

i synced it all last night but the watermark timestamps are all messed up so its executing 4 months of work everytime you launch it

my script is still running and seems to be fetching things as we speak.

ah. ok. let me stop it.

then I can start downloading the images to my local machine.

makes sense, i'll rewrite the script meanwhile.

k

yvanzo: https://github.com/metabrainz/musicbrainz-serve... has been approved by bitmap, should I merge it or are you planning to give it a second look before that? :)

Hi reosarevok, I didn’t complete/submit my review yet but found it's conflicting with the other PR for admin messages.

Well, that much is obvious, that's specifically why I asked for it to be reviewed and merged before that one

The template should be either moved to non-admin path or split under admin/non-admin paths.

It is all being moved to non-admin paths

IIRC from /admin/attributes to just /attributes

I mean the path in the repository, not in the URL.

Yes, so do I :) Maybe I forgot to move some files? IIRC the templates all move, but I might have missed some

Anything under /root/admin/ should be admin-only.

(https://github.com/metabrainz/musicbrainz-serve...)

Ok, cool!

But if you do find some stuff I might have missed on review do let me know and I'll fix that! :)

Ok thanks for having double-confirmed it :)

No worries :)

I think the right order for these would be merge the attributes one, you rebase/amend the admin one, we merge that, I rebase/amend the lowercasing one, we merge that

If that seems ok to you?

O agree

No huge rush, tomorrow would be fine too tbh

As long as we have at least a week and a bit for translators to reconfirm rows, it seems ok

Can do today

I can't describe how happy the existance of local and unpopular songs on MusicBrainz makes me. The editor community seriously irreplacable 🙏 https://usercontent.irccloud-cdn.com/file/7t3vm...

lucifer: I'm working on a PR to have test.sh set a env var to indicate tests are running. so far so good, but when trying to grant table perms, this happens when connected as the postgres user:

actually, never mind. grant != permissions.

👍

yet... "sqlalchemy.exc.ProgrammingError: (psycopg2.errors.InsufficientPrivilege) permission denied for sequence release_color_id_se"

I guess the test user is using the wrong pg user then.

mayhem: you are only granting privileges on tables, you need to grant privileges on sequences separately

is it possible to GRANT everyone in one go?

afaik not without making that user a superuser

but in general

hmm, I don't quite understand how things used to work before I mucked with them. :(

what do you want to do?

I set the PYTHON_TESTS_RUNNING in docker-compose.test.yml and then in init-db I want to check for that being set. if so, set up test db.

i see, there are a couple of complex interactions to it. i can fix it later today.

yes, I've found them.

but I think I see what needs doing now, I'll continue for a bit.

okay cool

yvanzo, bitmap: any idea what might cause MBS-13389 ? (to ISE rather than be caught earlier)

MBS-13389: Artist Creation https://tickets.metabrainz.org/browse/MBS-13389

no, that’s a second bug

but that’s also proving database constraints to be useful :)

it would be helpful to know if it could be a case of double submission.

(like clicking more than once on the submit button)

it shouldn't be possible (in theory...) unless the needs-disambiguation check failed

since we actually lock the table before we check for duplicates

I think I've seen stuff like this in sentry before

see Edit::Role::CheckDuplicates

I guess either is_disambiguation_needed failed, or the $duplicate_violation query

lucifer: when I do a ./develop.sh build I get the following error. have you seen this before?

mayhem: nope seeing for the first time

afk at the moment but can take a look in a few hours

bitmap: the fix for MBS-13391 is basically "convert it to React", right?

MBS-13391: UI does not behave consistently when trying to add an artist with a name already in use https://tickets.metabrainz.org/browse/MBS-13391

not necessarily, but it would probably help

I mean, I'm sure it can be fixed beforehand

What was the plan for converting the editors? First release, then all others will be trivial? Or can we get the smaller ones done sooner?

Oh, btw

MBS-13390 does seem new? I also hit it today

MBS-13390: Test server requires public e-mail address to test editing https://tickets.metabrainz.org/browse/MBS-13390

Did we change anything in test?

hmm, not that I can remember

re: converting the editors I'm about to submit a PR to refactor the artist credit editor

yvanzo: can you think what might have changed in test?

I don’t know, maybe it’s just running an old branch?

Yup, it is still running the Node 20 upgrade, at best.

reosarevok: I pushed master to test and launched a new build.

[listenbrainz-server] 14mayhem opened pull request #2645 (03master…use-unique-testing-env-var): Use unique testing env var for running tests https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-server] 14reosarevok opened pull request #3112 (03master…MBS-13388): MBS-13388: Handle vk.gy links https://github.com/metabrainz/musicbrainz-serve...

yvanzo: whoops, we missed the favicon_class for metalmusicarchives :) ^ that adds it too

👍

yvanzo: also, any thoughts on when a style IMPLEMENTATION REQUESTED ticket should be closed?

Once the implementation is sent for review? merged? released?

I cannot decide

Released seems the most precise but also by far the easiest to forget

I would close only when it is delivered.