paco: Putting musicbrainz-website-beta into maintenance mode...
2024-01-02 00238, 2024
reosarevok
Already up to date.
2024-01-02 00250, 2024
reosarevok
yvanzo: ^ that up to date is about docker-server-configs, right?
2024-01-02 00205, 2024
reosarevok
It's really confusing when printed like that, maybe we can add some context to it :)
2024-01-02 00242, 2024
reosarevok
Done
2024-01-02 00249, 2024
reosarevok runs off
2024-01-02 00204, 2024
Kladky joined the channel
2024-01-02 00217, 2024
mayhem
mooooin!
2024-01-02 00202, 2024
mayhem
outsidecontext: there is a new branch called add-artist-element-scan-using-subsonic that improves the subsonic workflow and it probably complete, save for the fetching the recording_mbid, which I've not found a way of doing yet. If you do, please let me know!
2024-01-02 00210, 2024
outsidecontext
moin
2024-01-02 00250, 2024
outsidecontext
mayhem: that sounds exciting. I'll give this a test and look into the recording MBID thing again. But at work now, will do so later today
Aside from paying people, not really. Out of town with K for a couple of days.
2024-01-02 00222, 2024
mayhem
Happy to answer questions though.
2024-01-02 00250, 2024
mayhem
(and I did work all day yesterday doing finances)
2024-01-02 00251, 2024
lucifer
ah cool, no worries.
2024-01-02 00208, 2024
akshaaatt
jasje please make PRs only to the dev branch. I see you making PRs directly to main branch. I am afraid I might miss checking that so can we not do that?
2024-01-02 00256, 2024
jasje
akshaaatt: its just the build type one.
2024-01-02 00215, 2024
akshaaatt
If anyone has ideas on how to make a different branch the default for PRs, let me know. I don't want to change the base branch.
2024-01-02 00243, 2024
akshaaatt
jasje but things should move from dev to main only. We cannot have code in main and dev being different
2024-01-02 00250, 2024
jasje
akshaaatt: the pr is deliberately pointing to main
2024-01-02 00200, 2024
akshaaatt
why? makes no sense
2024-01-02 00223, 2024
jasje
since that is not a feature but a bud configuration change
2024-01-02 00228, 2024
jasje
build*
2024-01-02 00255, 2024
akshaaatt
but why shouldn't it be there in the dev branch? The next time we do dev to main, we would end up having conflicts for no reason
2024-01-02 00228, 2024
jasje
oh I thought dependency updates were straight to main
yvanzo: yes, deploying it with Ansible would be great
2024-01-02 00248, 2024
zas
atj: ^^
2024-01-02 00209, 2024
zas
Best wishes to *
2024-01-02 00226, 2024
lucifer
reosarevok: hi! does any song that appear in a movie count as soundtrack? for instance, a lot of bollymood have multiple tracks that play during the movie, and the songs are often released only as part of the movie album. should such albums be marked with the soundtrack type?
2024-01-02 00236, 2024
reosarevok
I'd expect "the movie album" to be a soundtrack
2024-01-02 00218, 2024
reosarevok
But for example a "best of Bollywood" compilation wouldn't
2024-01-02 00211, 2024
lucifer
makes sense
2024-01-02 00255, 2024
q3lont joined the channel
2024-01-02 00217, 2024
relaxoMob joined the channel
2024-01-02 00201, 2024
q3lont has quit
2024-01-02 00224, 2024
pranavkonidena_ has quit
2024-01-02 00219, 2024
outsidecontext
mayhem, lucifer: FYI, the MetaBrainz account on the Ubuntu Snap Store is now marked as a verified publisher, see https://snapcraft.io/publisher/metabrainz-apps . If e.g. the LB app should be submitted we should make sure to publish it under the same account.
2024-01-02 00251, 2024
adhawkins
Does the server cache WS requests? I've made a change to a recording artist join phrase on a release, and the replication packet seems to have made it to my local server. However, the API request is returning the old join phrase...
2024-01-02 00226, 2024
yvanzo
Hi adhawkins, is it a browse, lookup, or search request?
(You won't be able to access that URL, but that's the request I'm making)
2024-01-02 00259, 2024
yvanzo
Thanks
2024-01-02 00222, 2024
adhawkins
If I make the same request direct to the metabrainz server, it returns the correct join phrase in the recording.
2024-01-02 00257, 2024
adhawkins
And if I look on the web interface for the local server, it seems to have the correct phrase too.
2024-01-02 00235, 2024
adhawkins
Disc 3 track 6, the name-credit on the recording has a join phrase if just '&', when it should be ' & '. I made an edit to fix that relatively recently, and it has passed.
2024-01-02 00200, 2024
yvanzo
adhawkins: All entities including artist credits are cached internally, but it should be uncached when the cache is updated/deleted when the database. Maybe it isn’t handled correctly on mirrors.
2024-01-02 00218, 2024
adhawkins
Ok. I'll restart the container and see if that fixes it.
2024-01-02 00250, 2024
yvanzo
It is cached in Redis. Try the following command: `sudo docker-compose exec redis sh -c "redis-cli --scan --pattern 'MB:artist_credit:*' | xargs redis-cli DEL"`
2024-01-02 00208, 2024
adhawkins
Too late, I restarted the containers. That does seem to have resolved it.
2024-01-02 00214, 2024
pranavkonidena_ joined the channel
2024-01-02 00216, 2024
yvanzo
👍
2024-01-02 00256, 2024
adhawkins
Would it eventually have resolved itself? I was being a bit impatient :)
2024-01-02 00224, 2024
yvanzo
Yes, the time to live is 1h.
2024-01-02 00232, 2024
yvanzo
(for entity cache)
2024-01-02 00248, 2024
adhawkins
Oh ok. Must be more patient then :)
2024-01-02 00214, 2024
bitmap
good morning
2024-01-02 00212, 2024
bitmap
adhawkins: there is a sample "post-process" script at admin/replication/hooks/post-process.sample which prunes the cache after each packet is applied, but it must be copied to admin/replication/hooks/post-process
2024-01-02 00231, 2024
adhawkins
Oh cool, will take a look at that. Thanks bitmap
2024-01-02 00222, 2024
bitmap
👍
2024-01-02 00243, 2024
yvanzo
bitmap: Never used it. Would it be worth copying to mirror setup by default?
2024-01-02 00248, 2024
bitmap
I think it would make sense as default behavior, but since post-process is gitignore'd, I guess it was added as a sample file to begin with.
2024-01-02 00245, 2024
bitmap
perhaps we could move it to post-process.default and execute it if post-process doesn't exist
2024-01-02 00250, 2024
yvanzo
I mean the Dockerfile could copy it.
2024-01-02 00232, 2024
bitmap
sure, just thinking about making it default for all setups
2024-01-02 00248, 2024
yvanzo
sure, it's just default recommended setup
2024-01-02 00257, 2024
bitmap
copying it in the Dockerfile sounds like a nice improvement for now
2024-01-02 00255, 2024
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #2690 (03master…singles-first-refined): Rank Singles/EPs before Albums with secondary types in mapping https://github.com/metabrainz/listenbrainz-server…
but otherwise if I add the `"recording_mbid": song["musicBrainzId"]` to the add_or_update_recording call in your code everything works
2024-01-02 00202, 2024
outsidecontext
only thing to consider is that there still needs to be a safeguard in case no recording ID is available for some tracks, otherwise the metadata call will fail
