#metabrainz

understood. If my import is faulty, can I undo it? can I create a test account, that I can delete after?

But you can test your importer by either having a separate test account, or by deleting all your listens from your account and trying again

Right, there's no undo, but you can wipe listens from an account if you're not planning on saving them

cool

monkey: thanks

monkey: using test.lb?

Also, you can export the listens before you wipe them, if you want to compare them later

lucifer: I think I did the testing I wanted, you can go ahead

thanks!

lucifer: I've been trying to figure out the musicbrainz auth on test. I think maybe something's missing here to recognize the test environment? https://github.com/metabrainz/listenbrainz-serv...

Comparing to the definition of the services that have separate entries for _BETA and _TEST: https://github.com/metabrainz/listenbrainz-serv...

Maybe it's not that, but for some reason test.LB considers I don't have MB credentials, evene after logout/login

monkey: the line in your first link calls the code in your second link

so not that for sure, i had forgotten about it earlier but i'll try to debug today.

Thanks. I do see it calls it, just wondering if there's something going on with the deploy_env or something

Anyway. Thanks for looking into it !

[listenbrainz-ios] 14gauravbhardwaj7 opened pull request #18 (03main…fix-model): Model cleanup and UX enhancements https://github.com/metabrainz/listenbrainz-ios/...

akshaaatt: hey!, I was getting my feed blank due to un-utilized parameters present in our model, I have removed them and refactored the top bar.

how long should I wait between submission batches (of 1000 listens)?

Schmias: there are ratelimiting headers in responses which provide the info

bitmap, yvanzo: can you see any reason why we wouldn't want MBS-13407 ? (so, an option on artist rename to either change all previously uncredited rels to the new name, or keep them credited to the old one)

MBS-13407: Blank relationship credited-as text values should be populated with the prior name when an entity is renamed https://tickets.metabrainz.org/browse/MBS-13407

[bookbrainz-site] 14MonkeyDo closed pull request #980 (03master…asyncentity): BB-672: Rewrite entity folder using async/await https://github.com/metabrainz/bookbrainz-site/p...

you can enter the artist's (current) name as a relationship credit to work around that (if it's actually meant to be fixed), but I agree an option to rename blank ones may be useful (dunno about "almost always not intended")

I know you can, but that needs to be done on a case per case basis, so it can be a ton :)

I agree that often it's intended, for typos and such, but I can also see that "Artist renamed themselves" cases often should *not* have this change happen :)

It seems sensible when an artist is changing their name in real life, not when their name is changed in the database for some other reason such as cleanup which might be the most frequent case.

sure, just if you're originally entering them you should usually set it if it's not meant to change

That's very much non-obvious to users though :)

(since it's not like that for ACs)

Maybe the UI should also be improved to make it clearer how to originally enter credits.

IMO either they should be entered by default like for ACs, or there should be an option to change it or not

Possibly both?

yeah I agree it's not obvious

if we have an option to change them all, entering them by default might make sense

I have even seen editors arguing to empty the credited field if it is identical to the entity's (current) name.

(as in we should disallow blank credits and have an option to change ones that match the current artist name)

Is it something that would be easier implemented in React?

kellnerd[m]: I guess it's understandable, since we don't have documentation for it

yvanzo: not significantly, since the UI would just be a checkbox, I think

👍

Yeah, at least until you had to update a lot of rels to the old name after the entity has been renamed 😅

So I would definitely be in favor of filling the credit field by default.

storing blank credits was mostly an implementation detail (since it'd takes less space in the DB when most would match the artist name anyway)

I guess this wouldn't even be a schema change, or would it?

it shouldn't be

shouldn’t indeed

and we could continue to store them as blank credits as long as it's the same to the user (i.e., fill the field with the artist name in the UI, and only blank it on the server if it matches)

Oh, so just show the same as the artist in the credit field if it's actually blank, but make sure the process of changing them either fills them in or leaves them blank in which case they'll show the new artist?

Well, new name

I also thought that it seems like it was an implementation detail to take less space rather than a feature. Maybe (new) blank credits should rather be used as “no specific credit”?

reosarevok: yes, I think so

"no specific credit" is pretty much how they work now, yeah. it's just that it's very unclear to the user

Yeah, dunno. FWIW I sometimes do something like "recording-level credits get a relationship credit but work-level credits do not so that they will match the artist name"

I guess that wouldn't work with the new understanding.

But it feels honestly more straightforward to always have a credit, like we do with ACs

aerozol: ^ opinion, when around? :)

Maybe have a checkbox “This is specifically how this artist is credited here” to fill the field even though it is the same name.

(And leave it blank as we already do otherwise.)

`RateLimit-Reset-In` is always a one digit number. so it would be safe to wait for 10 seconds between batches

Schmias: ideally you should make it variable and wait for the number of seconds returned by RateLimit-Reset-In for the next call. The exact duration can vary

ok

[17:09] <bitmap> if we have an option to change them all, entering them by default might make sense <-- I've wantd this for ages

I've seen some people actually remove ac on relationships if it was identical to the (current) name, which I thoguht annoying

I don't know the exact configuration behind it (lucifer surely can tell), but from my use I think I have seen it significantly higher then 10 seconds in situations where the rate limit is actually exhausted.

ah yes kellnerd said

filling the credit in defult +11 to that

Schmias: see also https://listenbrainz.readthedocs.io/en/latest/u...

Woops, matrix bridge was hanging for 7 minutes.

Schmias: This is what I do in my client: https://github.com/kellnerd/listenbrainz-ts/blo...

So in addition to what outsidecontext said, I am only delaying the next request if the request limit has actually been reached.

I decided to wait the amount of seconds in `'X-RateLimit-Reset-In'` to be safe.

the 'You have listened to … songs so far' number doesn't update often, does it?

or fast

could you check if my import is okay?

please 🙏

sorry, did anyone answer me?

Yes

See https://chatlogs.metabrainz.org/libera/metabrai... :)

i was Schmias84 back then

and nobody did 😬

Not to your latest question indeed.

Go home eslint, you're drunk. https://usercontent.irccloud-cdn.com/file/FG3B3...

Schmias: What did you want to check in your imports? it looks good at first glance

monkey: I just wanted to make sure I used the right fields

I do see some playlist listens from youtube, I don't currently know of a good way to deal with them and I sometimes just decide to remove them manually https://usercontent.irccloud-cdn.com/file/wWrCC...

Not much we can do here I guess

Yep, the fields look fine for what I've looked at Schmias

You may want to add a submission_client as described in https://listenbrainz.readthedocs.io/en/latest/u...

i.e. the name of the submission client you're writing

it's just a script. I could publish it on github before submission and then put a link there

It can be useful down the line to isolate submissions from a particular script or version thereof

makes sense

thanks for your input monkey

You're welcome :)

mōrena!

🐟!

box said to use coconut powder/milk but I usd cream and some yogurt and rømme

ecellent

reosarevok: bitmap: yvanzo: I think I understand the relationship credit discussion… I have also thought it can look weird when sometimes there are specific artist credits, sometimes not. Especially after renames and merges

fish!

tbh it has annoyed me whne i fill in the ac on rels because it's *spesifically this name* and thne someone has gone and removed it on the grounds that it's "the smae as the artist name" (sometimes that'll change you know so i wanted to helgardere myself to make sure those relAC wasn't changed)

Yeah, I think it would be clearer if it was always there tbh

I know it might be a headache with the code (e.g. not sure if it’s worth the trouble), but there could be a default like [artist name] (maybe displayed in grey). That can be toggled/is changed upon rename. When someone explicitly types something in it becomes locked in (even if the same as the artist name). I haven’t thought it through completely though

Otherwise yeah, auto setting to artist credit is probably 👍

Example, post-merge: https://beta.musicbrainz.org/artist/cf8c4952-39...

so thne you cna whne changing or merging be like "yes I want it chnage identical artist rel AC

I don’t know if that’s quite right, because sometimes there might be a specific credit for the old name, while in other cases it’s just whatever/should be renamed

option. incase the rename/merge is a typo edit

i mean ys

hench giving the option to do or not rename credits

if there are spesific ones with the old name thne will have to be edited. much like we do AC on releases