#metabrainz

/

      • ssam has quit
      • 2024-02-20 05108, 2024

      • ssam joined the channel
      • 2024-02-20 05102, 2024

      • bitmap
        I mean depending on how PG plans the query, it could be quicker to do it per-edit, since we have more information (a specific editor ID and whether the flag is set)
      • 2024-02-20 05109, 2024

      • reosarevok
        Hmm
      • 2024-02-20 05111, 2024

      • reosarevok
        Ok
      • 2024-02-20 05120, 2024

      • reosarevok
        I thought something like "UPDATE editor SET privs = privs - $BEGINNER_FLAG WHERE member_since > NOW() - INTERVAL '2 weeks' AND EXISTS (SELECT 1 FROM edit WHERE edit.editor = editor.id AND edit.autoedit = 0 AND edit.status = ' . $STATUS_APPLIED . ' OFFSET 9)" would do them all in one go
      • 2024-02-20 05126, 2024

      • reosarevok
        And be a lot faster than sending a ton of queries
      • 2024-02-20 05128, 2024

      • reosarevok
        But maybe not?
      • 2024-02-20 05120, 2024

      • reosarevok
        (I just realized we're doing "EXISTS (SELECT 1 FROM edit WHERE edit.editor = editor.id AND edit.autoedit = 0 AND edit.status = ' . $STATUS_APPLIED . ' OFFSET 9) AS has_ten_accepted_edits" every time we load an editor, which seems... eh)
      • 2024-02-20 05103, 2024

      • bitmap
        I don't think it will be slow whether it's done in one query or many
      • 2024-02-20 05101, 2024

      • bitmap
        just saying that even if the batch query only takes 1s, the edit check on its own (for a single editor ID) might take sub-1ms, and we probably aren't handling 1,000 beginners per hour
      • 2024-02-20 05112, 2024

      • reosarevok
        Well, we can try that then :)
      • 2024-02-20 05115, 2024

      • bitmap
        (the privs and member_since would already be loaded as part of the editor, so could be checked in Perl)
      • 2024-02-20 05129, 2024

      • sudip_ has quit
      • 2024-02-20 05110, 2024

      • bitmap
        ok, apparently the batch one only takes ~450 ms, but the individual editor check (using my ID) takes < 0.1 ms :P https://gist.github.com/mwiencek/56e7185274b925bf…
      • 2024-02-20 05104, 2024

      • reosarevok
        I honestly have no idea how many beginner editors we do per hour but yes, I'm going to assume it's not thousands
      • 2024-02-20 05156, 2024

      • bitmap
        yeah, also doesn't factor in connection latency, but probably won't make much difference either way, heh
      • 2024-02-20 05123, 2024

      • reosarevok
        bitmap: hmm, we do remove privs from deleted editors, right?
      • 2024-02-20 05147, 2024

      • reosarevok
        So for the LimitedEditors report, the query would go from
      • 2024-02-20 05150, 2024

      • reosarevok
      • 2024-02-20 05156, 2024

      • bitmap
        yeah, we do
      • 2024-02-20 05102, 2024

      • reosarevok
        To just
      • 2024-02-20 05104, 2024

      • reosarevok
      • 2024-02-20 05105, 2024

      • reosarevok
        ?
      • 2024-02-20 05150, 2024

      • bitmap
        makes sense
      • 2024-02-20 05146, 2024

      • reosarevok
        Does seem more sensible :)
      • 2024-02-20 05103, 2024

      • reosarevok
        Ok, so we would want new editors to have default beginner privs
      • 2024-02-20 05118, 2024

      • reosarevok
        We *could* change the default for that field, but that would again be a schema change
      • 2024-02-20 05124, 2024

      • reosarevok
        What alternatives do we have?
      • 2024-02-20 05153, 2024

      • reosarevok
        Just insert the privs in sub register?
      • 2024-02-20 05126, 2024

      • reosarevok
        Or is there a situation where that wouldn't cover all needs?
      • 2024-02-20 05156, 2024

      • reosarevok
        I assume we don't want to add it by default in Editor->insert since we might actually have cases where we don't want to have it added
      • 2024-02-20 05124, 2024

      • reosarevok
        So in there I guess I'll just do privs => $data->{privs} // 0,
      • 2024-02-20 05153, 2024

      • bitmap
        I'm guessing that's the only place we call insert anyway, but
      • 2024-02-20 05108, 2024

      • reosarevok
        Maybe we use it for some tests
      • 2024-02-20 05113, 2024

      • reosarevok
        But yea, didn't check
      • 2024-02-20 05127, 2024

      • bitmap
        most likely
      • 2024-02-20 05144, 2024

      • reosarevok
        I guess this also would mean we could stop doing the whole "insert 10 fake edits so people can vote" thing in tests
      • 2024-02-20 05148, 2024

      • reosarevok
        Which would be nice
      • 2024-02-20 05105, 2024

      • bitmap
        ah yeah, that will be a nice improvement too
      • 2024-02-20 05103, 2024

      • Ansh[m] has quit
      • 2024-02-20 05124, 2024

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #3180 (03master…MBS-13492): MBS-13492: Move beginner status to a privilege flag https://github.com/metabrainz/musicbrainz-server/…
      • 2024-02-20 05146, 2024

      • reosarevok
        Ok, draft up, will continue tomorrow (with small, meaningless bits like actually unsetting the flag ever)
      • 2024-02-20 05120, 2024

      • yvanzo
        bitmap, lucifer, reosarevok: Have you seen this message before? https://www.irccloud.com/pastebin/VBtIOWIw/solr9-…
      • 2024-02-20 05114, 2024

      • lucifer
        yvanzo: yes.
      • 2024-02-20 05136, 2024

      • lucifer
        iirc it happened when the manual changes to be made to the mmd-schema classes are not applied.
      • 2024-02-20 05111, 2024

      • bitmap
        that's what I remember, too
      • 2024-02-20 05119, 2024

      • yvanzo
        That’s weird because it is the message I’m getting with solr9-new where the submodule mmd-schema has the required changes to propOrder.
      • 2024-02-20 05120, 2024

      • yvanzo
        bitmap, lucifer: Thanks, I decompiled DiscList.class and it is indeed missing count and offset.
      • 2024-02-20 05113, 2024

      • yvanzo
        Ok, it’s likely the mb-solr Dockerfile indirectly regenerating the Java classes.
      • 2024-02-20 05157, 2024

      • steinke has quit
      • 2024-02-20 05155, 2024

      • yvanzo
        Fixed!
      • 2024-02-20 05159, 2024

      • BrainzGit
        [design-system] 14dependabot[bot] opened pull request #124 (03master…dependabot/npm_and_yarn/ip-2.0.1): Bump ip from 2.0.0 to 2.0.1 https://github.com/metabrainz/design-system/pull/…
      • 2024-02-20 05135, 2024

      • bobbyflips joined the channel
      • 2024-02-20 05140, 2024

      • lucifer
        monkey, atj: hi! can either of you try to logout and login to beta.lb?
      • 2024-02-20 05148, 2024

      • bobbyflips has quit
      • 2024-02-20 05151, 2024

      • BrainzGit
        [listenbrainz-server] 14Aerozol merged pull request #2789 (03master…add-YTMusic2listenbrainz-link): Update add-data.html with YTMusic2listenbrainz script https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05120, 2024

      • aerozol[m] joined the channel
      • 2024-02-20 05120, 2024

      • aerozol[m]
        lucifer: I just logged into beta.lb without trouble, if that helps
      • 2024-02-20 05125, 2024

      • lucifer
        aerozol[m]: if you could do it on test.lb now, that would certainly help
      • 2024-02-20 05130, 2024

      • lucifer
        actually wait a sec
      • 2024-02-20 05113, 2024

      • lucifer
        yup ready now
      • 2024-02-20 05116, 2024

      • aerozol[m]
        No issues here
      • 2024-02-20 05123, 2024

      • aerozol[m]
        (just logged in again)
      • 2024-02-20 05136, 2024

      • lucifer
        thanks
      • 2024-02-20 05104, 2024

      • aerozol[m]
        lucifer: ansh: mayhem: monkey: isabelxxx posted some interesting background info and a github link to an existing ‘genre explorer’/map project that looks cool. If you’re interesting it’s on https://tickets.metabrainz.org/browse/LB-1509?
      • 2024-02-20 05105, 2024

      • BrainzBot
        LB-1509: Genre explorer
      • 2024-02-20 05142, 2024

      • aerozol[m]
        preeeettty
      • 2024-02-20 05103, 2024

      • aerozol[m] uploaded an image: (888KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/matrix.org/LmMQraihGDaMLhyqQtPGcexr/image.png >
      • 2024-02-20 05124, 2024

      • aerozol[m] uploaded an image: (132KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/matrix.org/qKjerqrgFjoZHpxxQXvSwZfB/image.png >
      • 2024-02-20 05134, 2024

      • aerozol[m]
        Also very cool to compare different databases (thanks @UltimateRiff for the find and post)
      • 2024-02-20 05143, 2024

      • discordbrainz
        <02UltimateRiff> one of the devs pinged me about it when they saw I created the ticket for the genre explorer~
      • 2024-02-20 05129, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #2792 (03master…fix-tokens-again): Fix MB OAuth token storage yet again https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05114, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2791 (03master…LB-1516): LB-1516: Prevent None output rows in top artist recordings https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05151, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2790 (03master…fix-created): LB-1513: Create feed event endpoints return created in float format https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05119, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2782 (03master…add-popularity-index): Add missing indexes to popularity data https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05124, 2024

      • technmad joined the channel
      • 2024-02-20 05106, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #2793 (03master…fresh-releases-duration): Add a threshold to fresh releases calculation https://github.com/metabrainz/listenbrainz-server…
      • 2024-02-20 05119, 2024

      • lucifer
        aerozol[m]: ^
      • 2024-02-20 05141, 2024

      • lucifer
        i have set the threshold to 10 at the moment, i can do a run to generate the data tomorrow.
      • 2024-02-20 05148, 2024

      • technmad
        I have been going through issue tacker, I was looking for frontend related issue but had a harder time finding those. Is there a way to segregate those issues, any filter criteria in particular
      • 2024-02-20 05115, 2024

      • bobbyflips joined the channel
      • 2024-02-20 05120, 2024

      • bobbyflips has quit
      • 2024-02-20 05158, 2024

      • ssam has quit
      • 2024-02-20 05117, 2024

      • technmad has quit
      • 2024-02-20 05105, 2024

      • aerozol[m]
        lucifer: awesome, thanks for tackling this!
      • 2024-02-20 05109, 2024

      • ssam joined the channel
      • 2024-02-20 05155, 2024

      • aerozol[m]
        technmad: did you have a project in mind? e.g. MusicBrainz, ListenBrainz, Picard, BookBrainz
      • 2024-02-20 05148, 2024

      • discordbrainz
        <09technmad> I'm currently looking into ListenBrainz
      • 2024-02-20 05146, 2024

      • technmad joined the channel
      • 2024-02-20 05152, 2024

      • technmad39 joined the channel
      • 2024-02-20 05156, 2024

      • technmad39 has quit
      • 2024-02-20 05116, 2024

      • technmad has quit
      • 2024-02-20 05137, 2024

      • technmad joined the channel
      • 2024-02-20 05149, 2024

      • bobbyflips joined the channel
      • 2024-02-20 05130, 2024

      • Sophist-UK has quit
      • 2024-02-20 05112, 2024

      • Sophist-UK joined the channel
      • 2024-02-20 05109, 2024

      • aerozol[m]
        I would see if there’s anything you like the look of in the good-first-bug or web pages components: https://tickets.metabrainz.org/projects/LB?select…
      • 2024-02-20 05138, 2024

      • technmad has quit
      • 2024-02-20 05151, 2024

      • aerozol[m]
        Open tickets in the ‘web pages’ component: https://tickets.metabrainz.org/browse/LB-1496?jql…
      • 2024-02-20 05152, 2024

      • BrainzBot
        LB-1496: Inspect Listen dialog keeps disappearing.
      • 2024-02-20 05123, 2024

      • technmad joined the channel
      • 2024-02-20 05150, 2024

      • technmad has quit
      • 2024-02-20 05103, 2024

      • technmad joined the channel
      • 2024-02-20 05111, 2024

      • bobbyflips has quit
      • 2024-02-20 05120, 2024

      • technmad has quit
      • 2024-02-20 05134, 2024

      • technmad joined the channel
      • 2024-02-20 05155, 2024

      • discordbrainz
        <09technmad> @reosarevok Thanks for the direction. I'll start going through the issues in Client and Web Pages components
      • 2024-02-20 05118, 2024

      • technmad has quit
      • 2024-02-20 05145, 2024

      • Kladky has quit
      • 2024-02-20 05139, 2024

      • ssam has quit
      • 2024-02-20 05136, 2024

      • ssam joined the channel