#metabrainz

I mean depending on how PG plans the query, it could be quicker to do it per-edit, since we have more information (a specific editor ID and whether the flag is set)

Hmm

Ok

I thought something like "UPDATE editor SET privs = privs - $BEGINNER_FLAG WHERE member_since > NOW() - INTERVAL '2 weeks' AND EXISTS (SELECT 1 FROM edit WHERE edit.editor = editor.id AND edit.autoedit = 0 AND edit.status = ' . $STATUS_APPLIED . ' OFFSET 9)" would do them all in one go

And be a lot faster than sending a ton of queries

But maybe not?

(I just realized we're doing "EXISTS (SELECT 1 FROM edit WHERE edit.editor = editor.id AND edit.autoedit = 0 AND edit.status = ' . $STATUS_APPLIED . ' OFFSET 9) AS has_ten_accepted_edits" every time we load an editor, which seems... eh)

I don't think it will be slow whether it's done in one query or many

just saying that even if the batch query only takes 1s, the edit check on its own (for a single editor ID) might take sub-1ms, and we probably aren't handling 1,000 beginners per hour

Well, we can try that then :)

(the privs and member_since would already be loaded as part of the editor, so could be checked in Perl)

ok, apparently the batch one only takes ~450 ms, but the individual editor check (using my ID) takes < 0.1 ms :P https://gist.github.com/mwiencek/56e7185274b925...

I honestly have no idea how many beginner editors we do per hour but yes, I'm going to assume it's not thousands

yeah, also doesn't factor in connection latency, but probably won't make much difference either way, heh

bitmap: hmm, we do remove privs from deleted editors, right?

So for the LimitedEditors report, the query would go from

yeah, we do

To just

?

makes sense

Does seem more sensible :)

Ok, so we would want new editors to have default beginner privs

We *could* change the default for that field, but that would again be a schema change

What alternatives do we have?

Just insert the privs in sub register?

Or is there a situation where that wouldn't cover all needs?

I assume we don't want to add it by default in Editor->insert since we might actually have cases where we don't want to have it added

So in there I guess I'll just do privs => $data->{privs} // 0,

I'm guessing that's the only place we call insert anyway, but

Maybe we use it for some tests

But yea, didn't check

most likely

I guess this also would mean we could stop doing the whole "insert 10 fake edits so people can vote" thing in tests

Which would be nice

ah yeah, that will be a nice improvement too

[musicbrainz-server] 14reosarevok opened pull request #3180 (03master…MBS-13492): MBS-13492: Move beginner status to a privilege flag https://github.com/metabrainz/musicbrainz-serve...

Ok, draft up, will continue tomorrow (with small, meaningless bits like actually unsetting the flag ever)

bitmap, lucifer, reosarevok: Have you seen this message before? https://www.irccloud.com/pastebin/VBtIOWIw/solr...

yvanzo: yes.

iirc it happened when the manual changes to be made to the mmd-schema classes are not applied.

that's what I remember, too

That’s weird because it is the message I’m getting with solr9-new where the submodule mmd-schema has the required changes to propOrder.

bitmap, lucifer: Thanks, I decompiled DiscList.class and it is indeed missing count and offset.

Ok, it’s likely the mb-solr Dockerfile indirectly regenerating the Java classes.

Fixed!

[design-system] 14dependabot[bot] opened pull request #124 (03master…dependabot/npm_and_yarn/ip-2.0.1): Bump ip from 2.0.0 to 2.0.1 https://github.com/metabrainz/design-system/pul...

monkey, atj: hi! can either of you try to logout and login to beta.lb?

[listenbrainz-server] 14Aerozol merged pull request #2789 (03master…add-YTMusic2listenbrainz-link): Update add-data.html with YTMusic2listenbrainz script https://github.com/metabrainz/listenbrainz-serv...

lucifer: I just logged into beta.lb without trouble, if that helps

aerozol[m]: if you could do it on test.lb now, that would certainly help

actually wait a sec

yup ready now

No issues here

(just logged in again)

thanks

lucifer: ansh: mayhem: monkey: isabelxxx posted some interesting background info and a github link to an existing ‘genre explorer’/map project that looks cool. If you’re interesting it’s on https://tickets.metabrainz.org/browse/LB-1509?

LB-1509: Genre explorer

preeeettty

Also very cool to compare different databases (thanks @UltimateRiff for the find and post)

<02UltimateRiff> one of the devs pinged me about it when they saw I created the ticket for the genre explorer~

[listenbrainz-server] 14amCap1712 opened pull request #2792 (03master…fix-tokens-again): Fix MB OAuth token storage yet again https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2791 (03master…LB-1516): LB-1516: Prevent None output rows in top artist recordings https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2790 (03master…fix-created): LB-1513: Create feed event endpoints return created in float format https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 merged pull request #2782 (03master…add-popularity-index): Add missing indexes to popularity data https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 opened pull request #2793 (03master…fresh-releases-duration): Add a threshold to fresh releases calculation https://github.com/metabrainz/listenbrainz-serv...

aerozol[m]: ^

i have set the threshold to 10 at the moment, i can do a run to generate the data tomorrow.

I have been going through issue tacker, I was looking for frontend related issue but had a harder time finding those. Is there a way to segregate those issues, any filter criteria in particular

lucifer: awesome, thanks for tackling this!

technmad: did you have a project in mind? e.g. MusicBrainz, ListenBrainz, Picard, BookBrainz

<09technmad> I'm currently looking into ListenBrainz

I would see if there’s anything you like the look of in the good-first-bug or web pages components: https://tickets.metabrainz.org/projects/LB?sele...

Open tickets in the ‘web pages’ component: https://tickets.metabrainz.org/browse/LB-1496?j...

LB-1496: Inspect Listen dialog keeps disappearing.

<09technmad> @reosarevok Thanks for the direction. I'll start going through the issues in Client and Web Pages components