monkey: thx for the suggestion, it helps a lot! another thought: desc is default for confidence, asc for other types. simplest way is to make asc default for confidence, but i'm not sure if that's what we want for users?
2024-04-05 09658, 2024
yellowhatpro joined the channel
2024-04-05 09604, 2024
ericd has quit
2024-04-05 09631, 2024
hirigaray has quit
2024-04-05 09639, 2024
hirigaray joined the channel
2024-04-05 09614, 2024
huhridge joined the channel
2024-04-05 09647, 2024
huhridge has quit
2024-04-05 09656, 2024
Kladky joined the channel
2024-04-05 09600, 2024
huhridge joined the channel
2024-04-05 09615, 2024
outsidecontext
zas: Good morning. Just as information, I'm working on the tests for the collection class. Just need to pause because of work, will submit a PR later today
2024-04-05 09607, 2024
huhridge has quit
2024-04-05 09627, 2024
Sciencentistguy has quit
2024-04-05 09628, 2024
Sciencentistguy joined the channel
2024-04-05 09637, 2024
zas
outsidecontext: ok, np :)
2024-04-05 09630, 2024
pranav[m] joined the channel
2024-04-05 09630, 2024
pranav[m]
Hey, hi akshaaatt (IRC) ! Any update on my PR?
2024-04-05 09646, 2024
fletchto99 has quit
2024-04-05 09649, 2024
fletchto99 joined the channel
2024-04-05 09618, 2024
huhridge joined the channel
2024-04-05 09657, 2024
huhridge has quit
2024-04-05 09602, 2024
outsidecontext
zas: just wanted to be sure we don't work both on it in parallel :)
2024-04-05 09602, 2024
monkey[m] joined the channel
2024-04-05 09602, 2024
monkey[m]
ericd (IRC): Personally I think desc should be the default for dates and confidence, and asc the default for alphabetical sorting. I think asc as the default for confidence is not what users want. So I guess when the sorting mode changes you can set the asc/desc accordingly, probably overwriting the user's previous choice. Either that, or have a separate hasSelectedSortOrder boolean (or something like that) stored in the state to decide
2024-04-05 09602, 2024
monkey[m]
whether to set the sort order when changing mode.
2024-04-05 09602, 2024
monkey[m]
Does that make sense?
2024-04-05 09614, 2024
discordbrainz
<07munishk> Hi @mayhem, I am working on the PR. It had worked earlier for lucifer as is so I am figuring out it maybe issue with packages
2024-04-05 09628, 2024
mayhem
ok, great.
2024-04-05 09641, 2024
discordbrainz
<07munishk> Trying running it on different environments
2024-04-05 09658, 2024
mayhem
do the tests pass locally for you? they dont for me.
2024-04-05 09659, 2024
discordbrainz
<07munishk> Not for me
2024-04-05 09608, 2024
discordbrainz
<07munishk> But had passed for lucifer
2024-04-05 09639, 2024
mayhem
well, work to make them pass for yourself first, then see about getting them to pass on github
2024-04-05 09635, 2024
discordbrainz
<07munishk> Yep, working on it
2024-04-05 09653, 2024
d4rkie has quit
2024-04-05 09619, 2024
huhridge joined the channel
2024-04-05 09625, 2024
d4rkie joined the channel
2024-04-05 09623, 2024
huhridge has quit
2024-04-05 09642, 2024
huhridge joined the channel
2024-04-05 09649, 2024
ansh
monkey[m]: Are you using test.LB?
2024-04-05 09605, 2024
mayhem
not i
2024-04-05 09613, 2024
monkey[m]
Ansh negative, working locally on your PR review comments, feel free to use it !
2024-04-05 09643, 2024
lucifer
munishk: i took a look at the PR, i think you missed my message on the changes needed to the url in the test last time. i commented it on the pr, that should get it working.
2024-04-05 09603, 2024
relaxoMob has quit
2024-04-05 09606, 2024
tux0r has quit
2024-04-05 09643, 2024
revi joined the channel
2024-04-05 09619, 2024
discordbrainz
<07munishk> Thank you @lucifer
2024-04-05 09624, 2024
pranav[m] has quit
2024-04-05 09626, 2024
tux0r joined the channel
2024-04-05 09620, 2024
relaxoMob joined the channel
2024-04-05 09625, 2024
akshaaatt
Hi pranav[m] ! Just reviewed your PR and I have left some comments
2024-04-05 09615, 2024
relaxoMob has quit
2024-04-05 09624, 2024
pranav[m] joined the channel
2024-04-05 09624, 2024
pranav[m]
Went thru the review akshaaatt (IRC) will make the reqd changes by tonight..
I’m not sure that we need shards for anything but recordings
2024-04-05 09622, 2024
yvanzo
but if you think that we should have at least 2 shards for any collection with a dump > 1G, maybe works should be sharded too.
2024-04-05 09626, 2024
atj
I'm not sure to be honest, it's total guess work at this point
2024-04-05 09634, 2024
yvanzo
same for me
2024-04-05 09651, 2024
atj
I think I was looking at > 5G?
2024-04-05 09623, 2024
atj
It's latency vs. parallelism from what I understand.
2024-04-05 09625, 2024
yvanzo
I looked at the dump size, not at the collection in solr data.
2024-04-05 09642, 2024
yvanzo
the number of entries is probably more pertaining.
2024-04-05 09645, 2024
atj
I was looking at the index size in the Grafana dashboard
2024-04-05 09659, 2024
atj
yeah, you're probably right
2024-04-05 09638, 2024
yvanzo
Last thing I would look into maybe is whether it is worth having 5 rather than 4 shards for recordings, given that we have 5 nodes only, if one node is down, there will be one node leading 2 shards.
2024-04-05 09609, 2024
atj
do you mean 4 shards rather than 5?
2024-04-05 09622, 2024
yvanzo
yes
2024-04-05 09624, 2024
yvanzo
That is 40% of recordings instead of 25% if leading only 1 from 4 shards.
2024-04-05 09635, 2024
yvanzo
If we have only 4 shards, it might be more resilient.
2024-04-05 09628, 2024
atj
well with 3 replicas every node will have several shards?
2024-04-05 09638, 2024
yvanzo
yes but not as leader
2024-04-05 09658, 2024
yvanzo
I assume that leader have more workload, but that is a total guess
2024-04-05 09620, 2024
atj
yeah, I don't know how the queries are distributed
2024-04-05 09615, 2024
ajhalili2006 joined the channel
2024-04-05 09651, 2024
Tarun_0x0 has quit
2024-04-05 09653, 2024
Tarun_0x0 joined the channel
2024-04-05 09622, 2024
minimal joined the channel
2024-04-05 09617, 2024
relaxoMob has quit
2024-04-05 09618, 2024
relaxoMob joined the channel
2024-04-05 09655, 2024
BrainzGit
[musicbrainz-server] 14reosarevok opened pull request #3226 (03master…flow-component-syntax-reports): Migrate React report components to Flow component syntax https://github.com/metabrainz/musicbrainz-server/…
