ansh (IRC): I have LB#2844 to test on test.LB, mind if I deploy it there?While I'm testing that I'll rebuild an image for the single-page-app branch and deploy that when I'm done. Sounds good?
also are you working on refactoring any other component right now?
monkey[m]
Yes, Huesound/Colorplay
Almost done with that one actually.
That leaves us with Playlist, Playlists and Recommendations components, and with lower priority the Raw Recommendations page, Missing Data and PlayerPage
ansh
Recommendations, playlistPage, playerpage, and missing MBData are done from my side. Just need to re-write some tests
So, looks like we can hopefully merge the BrainzPlayer PR too next week
lucifer
mayhem: click on your profile picture on the top of the home page in the mobile app and then tap on sound capsule in the menu that appears
monkey[m]
ansh (IRC): Great !
I'm going to do a last round of testing the spa branch, and I guess after that we can merge it, no?
discordbrainz
<11YoMo12> Trying to edit relationships, is it slow just for me?
Ah, I think I found it ansh (IRC) : We're using a Link element inside a toast message, but the ToastContainer element is not a child of the RouterProvider, so it does not have acces to the context. Let me test that theory
ansh
I think this is the correct reason.
Even the NiceModal Provider does not have access to the routeProvider. Opening a modal breaks
monkey[m] wants to move to React-Bootstrap and avoid all that shit
ansh
hmm, we have three modals to fix. CBReviewModal, CreateOrEditPlaylistModal, and AddListenModal
monkey[m]
ansh, deploying fix now
Or so I thought. It's not working
ansh
monkey[m]: I found a fix. Pushing....
monkey[m]
Ah hang on
Just deployed a new version
ansh
I checked your latest commit, it does not navigate on clicking
monkey[m]
Damn
monkey[m] fixes local setup
I think the other two modals are fine, as the Link is in the message that is show in a toast and by that point the modal is closed
lucifer
mayhem: the PR looks good, i pushed minor fixes. will run playlists job once and let you know if it works. fine to merge after that
mayhem
which of the two?
troi or LB?
monkey[m]
Nice one ansh (IRC) . It's weird that we have to do that at the moment, but we'll properly fix it at some point in the near future
ansh
monkey[m]: I've deployed the fix, It is working now
monkey[m]
Yusss
Thanks
ansh
Yep! I'll note this down. I also feel we need to cache couple of more API calls, like in fresh releases, lb radio, and music neighbourhood. It would make the experience much better
monkey[m]
Yep. And redo music neighborhood and user stats to use react-query and url search params
But I think we're lookign pretty good for a merge of step 2
ansh
Also, I believe I've testing all the buttons now, and we're good to merge the branch.
monkey[m] uploaded an image: (14KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/moviebrainz.org/ovshKuOrNWlbmHtxzKXEyqQZ/image.png >
monkey[m]
A vision of pure chaos:
(Relax, it's a feature branch...)
lucifer
mayhem: playlists work, fine to merge.
mayhem
woah
lucifer
lots of 429 spotify errors.
though.
huhridge has quit
mayhem
ok, now for the troi PR -- that needs merging before the LB PR.
monkey[m]
I noticed the brainzplayer code tries ceaselessly to refresh the token
the spotify token*. Could explain some of those 429
mayhem
oh. we should investigate this right quick!
ansh
monkey[m]: 147 file changes 🤯
monkey[m]
Yeah...you worked hard on this !
huhridge joined the channel
Partial rewrite of the codebase
Found a little issue BTW :) Same CSS issue I fixed a couple days ago with the secondary navbar
ansh
I'm going for dinner, I'll review this PR after that
monkey[m]
Kewl. Or tomorrow, eh, at this point we aren't in a rush to merge
bitmap
yvanzo: I haven't seen any reports of replication issues yet. the JSON dump mirror (which is running PG v16) also accepted the packet fine
yvanzo
bitmap: so it is only an issue with new dumps? :)
bitmap
I can't rule out that the packet containing this recording would fail to apply on some setups. it's difficult to correlate with anything -- looking at the PG source, it depends on a lot of variables...
yvanzo
Okay, I don’t understand how it can be an issue when creating the database only and not when applying replication packets, but I didn’t dig enough.
My current WIP is to create an Edit role CheckStringLength that would take a list of fields with limited length (name, sort_name…).
What do you think of this approach? (See also the backlogs)
bitmap
thanks, I'm already working on the index changes, so I'll handle the SQL and you can handle the validation?