In some places where we have removed `target= _blank`, we might review those once again. I believe external pages should be opened in a new tab
huhridge has quit
huhridge joined the channel
minimal joined the channel
Tarun_0x0[m] has quit
relaxoMob has quit
relaxoMob joined the channel
Tarun_0x0[m] joined the channel
Kladky has quit
Kladky joined the channel
derat joined the channel
derat
bitmap: on irc now. probably faster than going back and forth on github :-)
bitmap
derat: good idea :)
I think the only issue remaining was the "Primary alias" title. shortening it might be fine, but reosarevok and yvanzo can give their thoughts when they're around
"... in your language" was nice to give more context to the string though
Tarun_0x0[m] has quit
derat
okay, great. i already shortened it, but i'm happy to change it to whatever. another option might be adding a primary_alias_locale or similar field to Entity::Artist and then mapping that back to a human-friendly string for the title (presumably using the same code as the aliases page)
bitmap
yeah, that's an option
or primary_alias could become an Entity::Alias instead of Str
derat
yeah, maybe i'll go ahead and try to do that now in any case...
bitmap
btw, i think this might be our first valid use of <i> 😆
derat
then again, i think that the JSON representation from WebService/JSONSerializer.pm is already saving just the name as "primaryAlias", so it might be confusing if the perl analogue is an Entity::Alias instead
hah. yeah, i double-checked that it was correct to use <i> here instead of <em> :-P
bitmap
ah true...we should probably rename that to primaryAliasName tbh
huhridge has quit
if you'd rather add the locale as a separate property for now I'm fine with that though
derat
i'll probably wait to see what the others think for now
huhridge joined the channel
bitmap
👍
derat
okay, stepping away from the computer for a while. thanks for the review!