#metabrainz

/

      • thejoker88140 joined the channel
      • thejoker8814 has quit
      • thejoker88140 is now known as thejoker8814
      • Maxr1998_ joined the channel
      • Maxr1998 has quit
      • the4oo4 has quit
      • the4oo4 joined the channel
      • aerozol[m] joined the channel
      • aerozol[m] uploaded an image: (201KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/matrix.org/dmYSKexmFjpBjTabIAHZQCKX/image.png >
      • aerozol[m]
        ^ finito! I’ll be using this template for release updates going forward. I’ll make a header image for the LB website (e.g. to show up when you link it) based on this as well, hopefully
      • DarthGandalf has quit
      • aerozol[m] uploaded an image: (284KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/matrix.org/OtsCRpgpJtuehbTDqJlPMHDJ/ListenBrainz%20website%20header-01%202024-04-26_Github.png >
      • monkey, what do you think of the above, to add a preview image? I just followed the same format as what we have for Picard. We can also use it as the Social Preview for the LB Github repository (same as with Picard, again)
      • aerozol[m] uploaded an image: (195KiB) < https://matrix.moviebrainz.org/_matrix/media/v3/download/matrix.org/nNJuVVTIieJWEFfPmSESeCxH/image.png >
      • Will be nice to have a good preview pic in, I haven’t been able to re-share LB on FB since this post :P
      • huhridge joined the channel
      • huhridge has quit
      • huhridge joined the channel
      • aerozol[m] has quit
      • Kladky joined the channel
      • huhridge has quit
      • d4rk-ph0enix has quit
      • d4rk-ph0enix joined the channel
      • d4rk-ph0enix has quit
      • d4rk-ph0enix joined the channel
      • Attila46 joined the channel
      • ansh
        monkey[m]: On the search page, we should show the percentage of similarity right? If the similarity b/w two people is 26%, right now it shows 2.6 on prod (and 2.6% on test.LB)
      • huhridge joined the channel
      • DarthGandalf joined the channel
      • huhridge has quit
      • atj
        yvanzo: can you switch Sir from test to prod without doing a full re-index?
      • monkey[m] joined the channel
      • monkey[m]
        aerozol: Looks glorious! Such an improvement!
      • Haven't seen the picard preview image I think, but any improvement over the pixel soup above gets a green light from me, and your design exceeds that by far
      • Real nice.
      • Funny that we're finally finding a use for this split name logo format
      • SigHunter has quit
      • SigHunter joined the channel
      • ansh (IRC): agreed on the topic of external links. I went through them but it won't hurt if you want to do another pass
      • huhridge joined the channel
      • BrainzGit
        [troi-recommendation-playground] 14mayhem merged pull request #135 (03main…integration-fixes): Integration fixes https://github.com/metabrainz/troi-recommendati...
      • lucifer
        mayhem: there are 153 oauth applications in CB, mostly localhost dev installations for LB and BB. there are a few external users too but I used the above query and I cannot see any active users for those. https://www.irccloud.com/pastebin/7URWSZVk/
      • monkey[m]
        lucifer (IRC), ansh (IRC) : I'd like to put our big single-page-app feature branch on beta.LB for about a week to give users time to test it.
      • If that's all right with you, please merge any other pending PRs that are ready today so that we can deploy to prod today, and delay the next prod deployment until late next week
      • lucifer
        hence, i am thinking if i should just replace CB's oauth provider with MeB's. the only affected users would be LB users trying to write reviews who will need to reconnect CB accounts.
      • mayhem
        ok and these affected users will simply need to log in again?
      • monkey[m]
        And BB users too
      • lucifer
        disconnect and reconnect CB from settings.
      • BB too yes, only 65 connected accounts at the moment though.
      • mayhem
        I'm fine with that, if monkey is too.
      • monkey[m]
        Probably fine yes
      • lucifer
        great thanks!
      • monkey[m]: i would suggest deploy to prod from feature branch itself just in case we need to deploy some other urgent fixes to prod between now and next week's release.
      • *deploy to beta
      • monkey[m]
        You mean to beta?
      • Ya
      • Well, I'd love to merge this giant PR to avoid merge conflicts, since it touches 140-something files...
      • lucifer
        good point, i guess we can do release to prod from feature branch if any urgent fixes come up
      • monkey[m]
        That sounds manageable\
      • lucifer
        yup
      • monkey[m]
        👍️
      • lucifer
        yvanzo, reosarevok, bitmap: would have time for a meeting about MeB OAuth again next week, maybe an hour prior to regular meeting time or should we do that after next month's schema change?
      • BrainzGit
        [troi-recommendation-playground] release 03v2024.04.26.0 has been published by 14mayhem: https://github.com/metabrainz/troi-recommendati...
      • huhridge has quit
      • [listenbrainz-server] 14mayhem merged pull request #2850 (03master…troi-integration): Troi integration https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        ansh, monkey[m] , lucifer : any PRs that should get merged for today's release?
      • monkey[m]
        Nothing that is finishes and tested from my side
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2843 (03master…chunk-listens): Chunk listens received in API requests before writing to RMQ https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
      • mayhem
        ah yes.
      • lgtm. shall I merge?
      • lucifer
        yes
      • thanks!
      • mayhem
        np
      • BrainzGit
        [listenbrainz-server] 14mayhem merged pull request #2852 (03master…fix-spark-reader): Rollback transaction after processing message in spark reader https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] release 03v-2024-04-26.0 has been published by 14mayhem: https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        aerozol: ^^ Big LB Radio update, including country element. New parser, new syntax, better error messages. faster. better mode distinction.
      • monkey[m]
        mayhem (IRC): Actually I'll have to deploy again
      • mayhem
        por que?
      • monkey[m]
        Forgot I was working on the spotify connection retry limit stuff as we speak
      • Finishing that off now
      • mayhem
        k
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2854 (03master…spotify-connect-retry): Limit Spotify connection attempts https://github.com/metabrainz/listenbrainz-serv...
      • aerozol[m] joined the channel
      • aerozol[m]
        monkey: does that mean I should hold with sharing v-2024-04-26.0?
      • monkey[m]
        Yes please
      • monkey[m] checks the clock
      • Ummm. You all right aerozol ?
      • mayhem listens to "country:(vietnam)"
      • Ah, 11PM, that's not too bad
      • aerozol[m]
        Lucy’s been away for like 7 weeks now and my sleep schedule has SLIPPED, let me tell you haha
      • monkey[m]
        Hehe
      • aerozol[m]
        (back in a week!!(
      • monkey[m]
        self-jet-lag
      • mayhem
        aerozol[m]: I'd love to hear from you about what you think about the distinction between easy/medium/hard now.
      • they should be more pronounced now.
      • monkey[m]
        ansh (IRC): Can I please get a quick sanity check on LB#2854 ?
      • BrainzBot
        Limit Spotify connection attempts: https://github.com/metabrainz/listenbrainz-serv...
      • aerozol[m]
        mayhem: keen as! Probably not tonight, but hopefully this weekend. I’m super excited about the country feature
      • mayhem
        👍
      • monkey[m]
        On a related note aerozol, after some brainstorming with mayhem we thought maybe the wording for the current easy/medium/hard modes could be comfortable/curious/adventurous or something along those lines.
      • Would love your opinion on it (maybe tomorrow, eh?)
      • later* (not tomorrow)
      • aerozol[m]
        Maybe a discussion for another time, but I’m keen to talk about sharing genre tags across releases in a release group, or just up from releases into the release group. Maybe recordings up into releases as well, something like that. We have a problem with that, and fixing it is going to make the radio way better (as well as YIM and tagging local files)
      • Agreed re. changing the mode names, I’m sure we can come up with a good trio
      • monkey[m]
        Kewl
      • aerozol: You can go ahead and share the LB release actually
      • My other change is really only internal stuff, so no worries
      • aerozol[m]
        Shared
      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #3225 (03master…flow-component-syntax): MBS-13558 (I): Migrate React components to Flow component syntax https://github.com/metabrainz/musicbrainz-serve...
      • relaxoMob has quit
      • [listenbrainz-server] 14MonkeyDo merged pull request #2854 (03master…spotify-connect-retry): Limit Spotify connection attempts https://github.com/metabrainz/listenbrainz-serv...
      • monkey[m]
        Anything else to merge LB team? Doing another release
      • mayhem has nothing
      • Yeah, I reckon that's it
      • BrainzGit
        [listenbrainz-server] release 03v-2024-04-26.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • monkey[m]
        mayhem (IRC): Am I free to deploy to beta.LB before prod? I see a mayhem-test image there
      • mayhem
        yes, go for it.
      • all that is now on prod.
      • monkey[m]
        K
      • Updating LB prod too
      • huhridge joined the channel
      • mayhem
      • aerozol[m]: ^
      • monkey[m]
        ansh (IRC): Anything else you see that needs fixing or missing for the SPA branch? Thinking of merging it now and deploying to beta, then writing a blog post to ask for beta testers.
      • We will still of course be able to open and deploy a follow-up PR if and when we finds more things to fix
      • ansh
        Nope
      • I believe it's ready for merge
      • huhridge has quit
      • Satyaraj[m] joined the channel
      • Satyaraj[m]
        monkey: lucifer (IRC) Could you please take a look at this whenever you get time?
      • monkey[m]
        Will do Satyaraj
      • relaxoMob joined the channel
      • mayhem
        two new albums. Thanks Fresh Releases!
      • monkey[m]
        ansh (IRC): I see a failin test that seems related to the changes in the SPA branch. Specifically the changes in api_compat.py (https://github.com/metabrainz/listenbrainz-serv...)
      • Could you please have a look at that?
      • ansh
        sure, I'll fix
      • monkey[m]
        Thanks
      • Looking at another test that seems unrelated
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #2855 (03master…fix-settings-test): Add delay in test for deletion page https://github.com/metabrainz/listenbrainz-serv...
      • ansh
        monkey[m]: Is there a way to test individual python test file instead of running all the tests?
      • monkey[m]
        Yep, simply ./test.h relative-file-path
      • mayhem (IRC): There are some failing daily_jams tests that seem related to the recent troi changes: https://github.com/metabrainz/listenbrainz-serv...
      • Sorry, one test only
      • mayhem
        hmmm. thanks.
      • monkey[m]
        Freshly based off of master
      • Nice, thanks ansh!
      • Will wait for test to pass and then merge. Other failing tests are unrelated to the feature branch
      • zerodogg has quit