bitmap: ^ any suggestions on what else if anything needs to happen there?
Oh no, flow 235.1 brings 49 new errors :D
Due to "obj[key] where obj is not a dictionary object and key is a string used to not error and just silently return any. We now error on this pattern." it seems
Also, the paste-a-date plugin has [Violation] Listener added for a 'DOMNodeInserted' mutation event. warnings in Chrome now, we should look into moving ahead with https://github.com/metabrainz/musicbrainz-serve...
[musicbrainz-server] 14reosarevok merged pull request #3238 (03master…MBS-13533-fixes-yellowhatpro): MBS-13533: Fix order of cover art in release group artwork https://github.com/metabrainz/musicbrainz-serve...
d4rk joined the channel
d4rkie has quit
BrainzGit has quit
BrainzGit joined the channel
FichteFoll has quit
FichteFoll joined the channel
lucifer
bitmap, yvanzo, reosarevok: reminder of oauth meeting tonight one hour prior to regular meeting time. mayhem also if you'd like to join.
mayhem: just read you sslcom blog post. Reminder me of checking the app signing for picard. So we must deal with this in October this year. I set myself a reminder.
derat joined the channel
mayhem
ok, cool. anyone but ssl.com -- and we haven't gotten a lot of traction on this, but some people commented that this is common for ssl.com. sigh
derat: the interesting thing is it loads just fine locally
That's why I thought maybe it was connected with a clash in the way things are stored in beta vs prod
For example, the new stuff from your load_related_info won't be in prod
If prod is supposed to cache the artist after the load_related_info call and then beta tries to access it for the same artist, it will be missing stuff
But I haven't read the code to check if that's the case
If it is the case, then I'm not sure there's a lot you can do other than put that bit of the load_related_info code in prod - we're probably doing a prod hotfix release today or tomorrow for the truncated name patch from yvanzo so we could also add this for you if needed
outsidecontext
mayhem: yes, definitely not them. Unfortunately the last time I check other options were more expensive. But let's actually have a look at the situation in september / october, then we can evaluate the options.
mayhem
good plan
reosarevok
In that case we'd need to patch in the changes to load_related_info *and* the primary alias utils function
derat
reosarevok: it sounds like there's a lot going on with prod vs. beta that i'm unaware of. :-) so it's the case that beta may use entities that have been loaded by prod?
reosarevok
But let's maybe also check with bitmap once he's around :)
Yeah, they share a cache and we've had issues with this kind of thing before
That's why I'm guessing that's probably the issue
btw, aerozol on #mb said "Hmm, is anyone else on beta having trouble with the tracklist editor artist search? If I seed artists and then press the ‘search’ button, it won’t search, unless I delete a character or type something new into the field. Pressing ‘edit’ and then search works. If it’s not just me I will make a bug report"
Do you think this might be related to your PR too in some way?
derat
reosarevok: i think this code needs more time to bake before it makes it to prod. what about a small patch to just avoid crashing in the case where the aliases are undefined?
reosarevok
That would be a possibility too. Putting the code for calculating and loading aliases in prod seems relatively safe to me as well though, assuming this is the issue. But let's see what yvanzo and bitmap think
derat
re tracklist artist search, hmm, it's not immediately obvious to me how this could be causing that. it'd be good to know if any JS errors are being logged. i'll see if i can repro that
reosarevok
Yeah, it might be unrelated, just thought I'd ask :)
derat
i wasn't able to repro the tracklist editor seach issue on my first attempt, so a ticket would probably be useful. when i seed a (single-artist) bandcamp release on beta, switch to the tracklist editor, and click the magnifying glass on a track credit, i get the usual spinner and autocomplete
discordbrainz
<11sound.and.vision> hello musicbrainz friends.... this entity (Black) won't load in Beta https://beta.musicbrainz.org/artist/738457fb-62... throws error "Can't use an undefined value as an ARRAY reference..." etc loads fine in prod
derat
re putting the load_related_info changes in prod, you have much more faith in my perl code than i do :-)
Tarun_0x0 has quit
reosarevok
sound.and.vision: we were just talking about that issue :)
We'll try to have a fix today or tomorrow, but if need be please use prod for any artists you get that problem with for now
discordbrainz
<11sound.and.vision> oh my bad, thank-you in advance 😄
reosarevok: derat: we just need to add the `aliases` Moose attribute to the artist class in prod, then clear the cache. my bad for not thinking of that during review
yvanzo
reosarevok: Thanks!
derat
bitmap: glad the fix sounds straightforward! is that something that you're able to do? :-)
