[listenbrainz-android] 14dependabot[bot] opened pull request #441 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #442 (03dev…dependabot/gradle/dev/androidx.test.espresso-espresso-core-3.6.1): Bump androidx.test.espresso:espresso-core from 3.6.0 to 3.6.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #443 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-viewmodel-compose-2.8.3): Bump androidx.lifecycle:lifecycle-viewmodel-compose from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #444 (03dev…dependabot/gradle/dev/androidx.test.ext-junit-1.2.1): Bump androidx.test.ext:junit from 1.2.0 to 1.2.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #445 (03dev…dependabot/gradle/dev/androidx.test-monitor-1.7.1): Bump androidx.test:monitor from 1.7.0 to 1.7.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #446 (03dev…dependabot/gradle/dev/androidx.test-runner-1.6.1): Bump androidx.test:runner from 1.6.0 to 1.6.1 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #447 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-livedata-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-livedata-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #448 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.9.0): Bump io.sentry.android.gradle from 4.7.0 to 4.9.0 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] closed pull request #439 (03dev…dependabot/gradle/dev/io.sentry.android.gradle-4.8.0): Bump io.sentry.android.gradle from 4.7.0 to 4.8.0 https://github.com/metabrainz/listenbrainz-andr...
[listenbrainz-android] 14dependabot[bot] opened pull request #449 (03dev…dependabot/gradle/dev/androidx.lifecycle-lifecycle-runtime-ktx-2.8.3): Bump androidx.lifecycle:lifecycle-runtime-ktx from 2.8.2 to 2.8.3 https://github.com/metabrainz/listenbrainz-andr...
[musicbrainz-server] 14JadedBlueEyes opened pull request #3313 (03master…MBS-13676): MBS-13676: Remove alignment spacing when there is no cover art indicator https://github.com/metabrainz/musicbrainz-serve...
Maxr1998_ joined the channel
Maxr1998 has quit
yellowhatpro[m]
yvanzo bitmap : hi, there are couple of edits that have data but their row does not exist in edits table, should I take it into account?
I was actually checking for each edit and edit note if the editor is spammer or not, but since for a particular edit in `edit_data` having no row in `edit` table, I don't know about the editor.
I am checking for the condition before extracting the URL from edit_data or edit_note.
Will add tests soon related to new logics.
So far, app works good, and I think now I should start working on the network req part of the archival task.
Kladky joined the channel
atj[m] joined the channel
atj[m]
[@yellowhatpro](https://matrix.to/#/@yellowhatpro:matrix.org): could you add a join on `editor` to your initial edit query and add the condition to the where?
It would save the additional lookup for each edit
I may be misunderstanding something though
reosarevok[m]
Jade: I took a look at your PR, found some issues with it and some issues that were there before but I didn't know about 😅
Anyway, if you have the time, feel free to look into my comments - if you don't and you have enough to do with gsoc, just let me know and I can look into it myself further :)
Jade: if you want to test the RG search properly, feel free to make that change temporarily and revert for pushing ^
Jade[m]
reosarevok[m]: Thanks! I'll see if I can figure out how git cherry-pick works 😆
reosarevok[m]
Honestly, it's a one liner, I wouldn't bother
But if you want to, just git cherry-pick commithash should work if you have fetched my repo
Lotheric joined the channel
yvanzo[m]
Hi yellowhatpro, thanks, it looks good. Looking forward for tests. The above suggested improvement makes sense, you might even want to retrieve the edit type at the same time.
monkey[m]
lucifer: Hi! I'm trying to test LB#2910 but I can't really without a paying apple music account. Do you have a trick to test it, or are you willing to lend me your token for testing ? (promise, I won't use it for anything)
yvanzo: for moving the history page out of statistics - would you create a separate `/history` folder just for it, or put it under `/doc` since it's kind of a doc, or something else entirely?
yvanzo[m]
reosarevok:
I was suggesting /root/history
reosarevok[m]
So a separate folder under /root, and a separate Controller for it as well?
yvanzo[m]
yes
reosarevok[m]
Ok, I was thinking it felt like overkill but maybe it's cleaner after all
I was thinking we'd make it just l() for the strings in statistics/MusicBrainzHistory (probably just history/History after this)
And keep only titles and descriptions as l_history
Is that not the plan? :)
mayhem[m]
"It only works in practice, its a disaster in theory". I really need to add to that to my email sig
reosarevok[m]
yvanzo: if you mean adding a context to `'{date} - {title}'` to explain what that is about, that makes sense to me, anyway - not sure if that was the idea
yvanzo[m]
reosarevok: The initial plan was just to move the strings extracted from the database to a separate domain.
reosarevok[m]
Yes, I know, and that we're still doing. I was at first going to move the strings on the page itself to the same domain but you convinced me not to - I'm just not sure if you want me to move them to server given we both seem to agree this isn't really statistics
I think it makes sense, but I didn't quite get if you think "adding translation context keys to the event’s titles and descriptions" would be needed only if I moved those strings to `history` as well, or if you meant something else, yvanzo
yvanzo[m]
OK, let’s pick the simplest solution and not mix history data with code in this new domain.
reosarevok[m]
Seems good to me - so, server is fine for the few strings? I can probably even move them from statistics to server in the po files with the same kind of bash loop I used to move the events themselves to history, so that seems good
yvanzo[m]
The code can even stay in its current domain for now, and we can revisit those when revisiting statistics again (about the duplication issue we discussed earlier).
reosarevok[m]
Hmm, ok, I can live with that - still move it to root/history though or just not touch it at all for now?
(if you prefer not moving anything for now, that might be simpler for this PR so that'd be fine too)
yvanzo[m]
simpler! :)
reosarevok[m]
Ok!
minimal joined the channel
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #2927 (03master…fix-album-no-length): Manual submission modal: Only send duration_ms if non-null https://github.com/metabrainz/listenbrainz-serv...
lucifer[m]
monkey: sure, can do.
monkey[m]
Thanks! In the meantime I asked ansh to test for me, so I think we are probably sorted :)
pite joined the channel
lucifer[m]
ah okay, cool.
reosarevok[m]
yvanzo: I think I managed to make the PR better and more to your liking - do check when you have some time but no rush
