#metabrainz

[musicbrainz-android] 14dependabot[bot] opened pull request #238 (03dev…dependabot/github_actions/dev/yutailang0119/action-android-lint-4): Bump yutailang0119/action-android-lint from 3 to 4 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14dependabot[bot] opened pull request #239 (03dev…dependabot/gradle/dev/com.google.devtools.ksp-2.0.0-1.0.24): Bump com.google.devtools.ksp from 2.0.0-1.0.23 to 2.0.0-1.0.24 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14dependabot[bot] opened pull request #240 (03dev…dependabot/gradle/dev/androidx.paging-paging-runtime-ktx-3.3.1): Bump androidx.paging:paging-runtime-ktx from 3.3.0 to 3.3.1 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14dependabot[bot] opened pull request #241 (03dev…dependabot/gradle/dev/lifecycle-2.8.4): Bump lifecycle from 2.8.3 to 2.8.4 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14dependabot[bot] opened pull request #242 (03dev…dependabot/gradle/dev/io.coil-kt-coil-compose-2.7.0): Bump io.coil-kt:coil-compose from 2.6.0 to 2.7.0 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14akshaaatt merged pull request #238 (03dev…dependabot/github_actions/dev/yutailang0119/action-android-lint-4): Bump yutailang0119/action-android-lint from 3 to 4 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14akshaaatt merged pull request #239 (03dev…dependabot/gradle/dev/com.google.devtools.ksp-2.0.0-1.0.24): Bump com.google.devtools.ksp from 2.0.0-1.0.23 to 2.0.0-1.0.24 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14akshaaatt merged pull request #240 (03dev…dependabot/gradle/dev/androidx.paging-paging-runtime-ktx-3.3.1): Bump androidx.paging:paging-runtime-ktx from 3.3.0 to 3.3.1 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14akshaaatt merged pull request #242 (03dev…dependabot/gradle/dev/io.coil-kt-coil-compose-2.7.0): Bump io.coil-kt:coil-compose from 2.6.0 to 2.7.0 https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] 14akshaaatt merged pull request #241 (03dev…dependabot/gradle/dev/lifecycle-2.8.4): Bump lifecycle from 2.8.3 to 2.8.4 https://github.com/metabrainz/musicbrainz-andro...

[listenbrainz-server] 14amCap1712 merged pull request #2945 (03master…fix-mbid-mapping-explain): Make release_name optional https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] 14amCap1712 opened pull request #2949 (03master…dump-improvements): Add created field to dumps https://github.com/metabrainz/listenbrainz-serv...

https://mubr.app/ mayhem monkey lucifer

<akshaaatt[m]> "https://mubr.app/ mayhem..." <- Related to an idea I had where I'd put the "listening now" from my LB account on my website

I've seen a couple of people do something similar with lastfm as well

Jade: hey! I was just reviewing your recent commits. I see you've made a lot of improvements to the Dockerfile and build -- do you think it's ready enough that I can spin up a test version somewhere?

Yep!

It should be as simple as docker pull metabrainz/mb-mail-service:latest and docker run metabrainz/mb-mail-service

awesome, remind me, all configuration is still performed through environment variables?

Yep

Should be a functional docker compose definition

ok, it looks like there aren't really any config options that need to change dynamically, so that should be fine

I'll work on setting that up on one of our machines today and try sending out a mail

did you have any luck making progress with the MBS integration?

I know roughly what I need to do, I think

I'm doing the editor message one first

I think that's the splace where I need to make the changes

And I'm guessing that I can use the JSON package?

s/splace/space/

I'm not 100% confident in my perl, but I've cracked open the manual so I am making a bit of progress

yeah, we use JSON::XS generally, use JSON::XS qw( encode_json ); is the import you want

encode_json will give back utf8-encoded data

For this one specifically, where does $opts{subject} come from? Is it something set by the user?

I ask because I don't think it was in the figma design

yeah, it's part of the form they submitted

e.g. https://musicbrainz.org/user/Bitmap/contact

OK. I'm generating the actual subject line from a translation string at the moment

It might be worth asking aerozol for thoughts on how this fits into the new design?

sure, do you have a link to the design you're referring to?

On the Dev: Dump page

Specifically, I'm looking at the edit note design, as that's the closest

There's also the 'send to self' option

right, I think it will be very similar to the edit note one, except the subject will have to be configurable

I can do the subject as an interpolation, which is what's already happening for edit notes

I'm thinking that it's probably a good idea to not let users send emails with entirely arbitrary subjects from a metabrainz

* a metabrainz address

yeah, maybe. though we don't restrict the body in any case, and I don't think we've had any real issues with this form in the past (which is actually kinda surprising)

Hah yeah, I would've thought it'd be a prime target for spam!

yeah, I guess they just have far more efficient ways of sending out messages to harvested emails from botnets and such already, maybe it's too primitive for them :P

So far I've got this... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

Does it look roughly right to you?

if you're encoding that to JSON later, instead of my @body = (...) use my $body = {...} (which creates a hash reference)

and `push @body, $key, value` becomes `$body->{$key} = $value`

so... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

yup, as a small style thing, you don't need to quote the keys when using `key =>` or `$foo->{key}` (as long as they look like identifiers)

Is a - in there OK, for headers?

you'll have to quote them if they contain -

letters, numbers, and underscores are fine though

* ```perl... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

Does that look OK?

I'm not sure about the `to_json($body->to_hash))` bit but I think it looks okay

what's `$body->to_hash`?

This is me copy and pasting from the wrong places, oops

to_json should be encode_json too

(I assume the $_request scalar was declared previously since it has no my)

You assume wrong 😅

Fined, thanks :)

haha

https://github.com/metabrainz/musicbrainz-serve... has a recent example of a POST request using LWP, you can also just pass the POST thing directly if you prefer

(slightly different since that's not posting JSON)

Right, that should be functional

Now to figure out how to test it

And push the template in mb-mail-service 😅

don't forget a semi-colon at the end of the $header_params (Perl will actually choke there)

if you enable DB_STAGING_TESTING_FEATURES in lib/DBDefs.pm, you'll enable an "Edit user" tab from any user profile, and you can set an email for them (tick "Skip verification")

OK!

<08wileyfoxyx> MBS-13697

MBS-13697: Statistics page tabs displayed in English when switching to Timeline tab while having different UI language https://tickets.metabrainz.org/browse/MBS-13697

So I got the normal SMTP sending to work on my local instance

However I'm having trouble getting the LWP instance

`$self->lwp->request` results in "Can't locate object method "lwp" via ..."

`$self->model('MB')->context->lwp->request` results in "can't locate object "model" ..."

What am I missing here?

have you tried `$self->c->lwp->request`?

there is a has 'c' in Email.pm

Sorry about the delay, I got snagged for an imprompu website consultation lol

<bitmap[m]> "have you tried `$self->c->lwp->..." <- Thisn works, thank you!

s/Thisn/This/

It's working! 🎉

Is there a ticket for this already, or should I make one?

Jade[m]: I don't think there is, can you? thanks!

Will do :)

Jade: is that the 'contact user' button/form? Let me know if you need design changes, but I think it should fit into one of those templates. Since it's from another user you might like to use the speech bubble box again 😎

aerozol[m]: Yep!

<Jade[m]> "Screencast from 2024-08-01 19-41..." <- This is it, if you can load the video

Oh nice, looks great!

[musicbrainz-server] 14reosarevok opened pull request #3348 (03master…MBS-13718): MBS-13718: Support The Session composer pages https://github.com/metabrainz/musicbrainz-serve...