#metabrainz

/

      • minimal has quit
      • 2024-08-30 24345, 2024

      • pite has quit
      • 2024-08-30 24318, 2024

      • yellowhatpro[m]
        bitmap yvanzo hi, sorry I was not around yday.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/SpZHZoqMKFHzJlYtKrmzsrmC>)
      • 2024-08-30 24314, 2024

      • d4rk-ph0enix has quit
      • 2024-08-30 24339, 2024

      • d4rkie joined the channel
      • 2024-08-30 24304, 2024

      • Kladky joined the channel
      • 2024-08-30 24330, 2024

      • Kladky has quit
      • 2024-08-30 24332, 2024

      • Kladky joined the channel
      • 2024-08-30 24332, 2024

      • reosarevok[m]
        Jade: no need for a box for the links, yes, put them just by the label ideally
      • 2024-08-30 24329, 2024

      • derat[m]1 has quit
      • 2024-08-30 24313, 2024

      • reosarevok[m]
        mayhem: snark aside, do you have a workaround for the dependency clashing? :)
      • 2024-08-30 24357, 2024

      • SigHunter has quit
      • 2024-08-30 24342, 2024

      • SigHunter joined the channel
      • 2024-08-30 24317, 2024

      • BrainzGit
        [listenbrainz-server] 14anshg1214 merged pull request #2969 (03master…listen-cover-art-util): Album art util: Return early if there is no listen https://github.com/metabrainz/listenbrainz-server…
      • 2024-08-30 24312, 2024

      • SigHunter has quit
      • 2024-08-30 24312, 2024

      • SigHunter joined the channel
      • 2024-08-30 24314, 2024

      • mayhem[m]
        <reosarevok[m]> "mayhem: snark aside, do you have..." <- have you tried bumping the mbdata depedency to 27.1.0 ?
      • 2024-08-30 24337, 2024

      • reosarevok[m]
        I can, if we're sure there's no big reason it's below, I guess :)
      • 2024-08-30 24318, 2024

      • reosarevok[m]
        Seems to work
      • 2024-08-30 24324, 2024

      • reosarevok[m]
        At least for this easy code check
      • 2024-08-30 24300, 2024

      • reosarevok[m]
        Ok, code tested, dumb mistake fixed, should work now
      • 2024-08-30 24347, 2024

      • reosarevok[m]
        CI tests are failing, again because of the mbdata mismatch - I won't touch that though, someone who has a clearer view of the project should check whether it's safe to just update. lucifer possibly.
      • 2024-08-30 24350, 2024

      • mayhem[m]
        again, and you changed the mbdata dependency?
      • 2024-08-30 24344, 2024

      • reosarevok[m]
        I did locally, which works
      • 2024-08-30 24350, 2024

      • reosarevok[m]
        I'm just not going to push that to the repo
      • 2024-08-30 24314, 2024

      • reosarevok[m]
        Since I know the PR works but I don't know if that'll break something elsewhere that I did not test :)
      • 2024-08-30 24349, 2024

      • mayhem[m]
      • 2024-08-30 24316, 2024

      • BrainzGit
        [listenbrainz-server] 14dependabot[bot] opened pull request #2971 (03master…dependabot/npm_and_yarn/webpack-5.94.0): Bump webpack from 5.76.0 to 5.94.0 https://github.com/metabrainz/listenbrainz-server…
      • 2024-08-30 24343, 2024

      • BrainzGit
        [bookbrainz-site] 14dependabot[bot] opened pull request #1116 (03master…dependabot/npm_and_yarn/webpack-5.94.0): chore(deps-dev): bump webpack from 5.76.0 to 5.94.0 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24351, 2024

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #1116 (03master…dependabot/npm_and_yarn/webpack-5.94.0): chore(deps-dev): bump webpack from 5.76.0 to 5.94.0 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24332, 2024

      • BrainzGit
        [bookbrainz-site] 14dependabot[bot] opened pull request #1117 (03master…dependabot/npm_and_yarn/micromatch-4.0.8): chore(deps): bump micromatch from 4.0.4 to 4.0.8 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24307, 2024

      • BrainzGit
        [metabrainz.org] 14amCap1712 merged pull request #475 (03master…cancel-recurring-updates): MEB-163: Update the docs for cancelling payments https://github.com/metabrainz/metabrainz.org/pull…
      • 2024-08-30 24318, 2024

      • lucifer[m]
        reosarevok: sorry for the delay, fixed now.
      • 2024-08-30 24308, 2024

      • BrainzGit
        [metabrainz.org] 14dependabot[bot] opened pull request #476 (03master…dependabot/npm_and_yarn/webpack-5.94.0): Bump webpack from 5.88.1 to 5.94.0 https://github.com/metabrainz/metabrainz.org/pull…
      • 2024-08-30 24311, 2024

      • BrainzGit
        [metabrainz.org] 14amCap1712 merged pull request #476 (03master…dependabot/npm_and_yarn/webpack-5.94.0): Bump webpack from 5.88.1 to 5.94.0 https://github.com/metabrainz/metabrainz.org/pull…
      • 2024-08-30 24348, 2024

      • reosarevok[m]
        No worries, lucifer :)
      • 2024-08-30 24317, 2024

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #145 (03main…apple_lookup): Exporting playlist to Apple Music https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24346, 2024

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #146 (03main…weeklyjams): LB-1599: Weekly Mix export to Spotify fails (description too long) https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24305, 2024

      • rimskii[m]
        Hi, lucifer ! Just saw PRs being merged (yay)! Thanks for it
      • 2024-08-30 24305, 2024

      • rimskii[m]
        Could you please guide me on the next steps?
      • 2024-08-30 24347, 2024

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #147 (03main…soundcloud_lookup): SoundCloud Export & Lookup https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24325, 2024

      • BrainzGit
        [troi-recommendation-playground] release 03v2024.08.30.0 has been published by 14amCap1712: https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24350, 2024

      • mayhem[m]
        luc
      • 2024-08-30 24300, 2024

      • mayhem[m]
        lucifer: are you going to do a LB release?
      • 2024-08-30 24314, 2024

      • mayhem[m]
        I'd like to sneak the nosim fix in if possible.
      • 2024-08-30 24343, 2024

      • lucifer[m]
        rimskii: thanks to you :). as for the next steps, you can probably follow up on your LB PRs and update it with latest version of troi. other than that you can start working on your blogpost.
      • 2024-08-30 24326, 2024

      • lucifer[m]
        mayhem[m]: nothing else to release at the moment, but i can do one for the nosim one if you'd like
      • 2024-08-30 24304, 2024

      • mayhem[m]
        let me do some testing to make sure I don't break anything else.
      • 2024-08-30 24313, 2024

      • lucifer[m]
        sure sounds good
      • 2024-08-30 24353, 2024

      • rimskii[m]
        sure, thanks! :)
      • 2024-08-30 24319, 2024

      • Gerjan joined the channel
      • 2024-08-30 24352, 2024

      • LupinIII has quit
      • 2024-08-30 24327, 2024

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #1117 (03master…dependabot/npm_and_yarn/micromatch-4.0.8): chore(deps): bump micromatch from 4.0.4 to 4.0.8 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24313, 2024

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo merged pull request #1115 (03master…dependabot/npm_and_yarn/webpack-dev-middleware-7.4.2): chore(deps-dev): bump webpack-dev-middleware from 7.2.1 to 7.4.2 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24331, 2024

      • mayhem[m]
        monkey or Anton
      • 2024-08-30 24351, 2024

      • mayhem[m]
        ansh: monkey any idea why this might be happening? https://test.listenbrainz.org/explore/lb-radio/?p…
      • 2024-08-30 24354, 2024

      • monkey[m] joined the channel
      • 2024-08-30 24354, 2024

      • monkey[m]
        Yes?
      • 2024-08-30 24303, 2024

      • mayhem[m]
        "a.replace is not a function"
      • 2024-08-30 24335, 2024

      • monkey[m]
        No, that's new to me. But I can replicate here.
      • 2024-08-30 24356, 2024

      • monkey[m]
        Weird, I was using LBRadio just a couple days ago
      • 2024-08-30 24315, 2024

      • mayhem[m]
        works in prod, but this most recent master branch it doesn't. :(
      • 2024-08-30 24323, 2024

      • monkey[m]
        mayhem: Looks like some util function is expecting a string at track.identifier but got an array of strings instead
      • 2024-08-30 24332, 2024

      • monkey[m]
        Not sure if implementation is wrong or what
      • 2024-08-30 24320, 2024

      • monkey[m]
        Hmm, specs at https://musicbrainz.org/doc/jspf suggests it should be a string, I probably implemented from that
      • 2024-08-30 24313, 2024

      • mayhem[m]
        there were recently some changes in our code to be compliant with the spec. track.identifier was involved.
      • 2024-08-30 24357, 2024

      • monkey[m]
        Where is that spec defined?
      • 2024-08-30 24315, 2024

      • mayhem[m]
        as per our spec, which you just linked. :)
      • 2024-08-30 24343, 2024

      • monkey[m]
        At https://xspf.org/jspf it does show identifier as a list
      • 2024-08-30 24345, 2024

      • mayhem[m]
        let me read the troi code.
      • 2024-08-30 24326, 2024

      • monkey[m]
        Looks like the frontend code in question has been changed to support both string and string array, so that's why it works in prod
      • 2024-08-30 24340, 2024

      • mayhem[m]
        track["identifier"] = ["https://musicbrainz.org/recording/" + str(e.mbid)]
      • 2024-08-30 24348, 2024

      • mayhem[m]
        lists in the troi code.
      • 2024-08-30 24335, 2024

      • mayhem[m]
        monkey[m]: let me merge master again and try again
      • 2024-08-30 24316, 2024

      • mayhem[m]
        wait, sorry. wrong branch. 🤦
      • 2024-08-30 24331, 2024

      • mayhem[m]
        let me start over again. sorry to bug you monkey
      • 2024-08-30 24339, 2024

      • monkey[m]
        :p
      • 2024-08-30 24342, 2024

      • monkey[m]
        All good
      • 2024-08-30 24321, 2024

      • minimal joined the channel
      • 2024-08-30 24325, 2024

      • bitmap[m]
        <yellowhatpro[m]> "bitmap yvanzo hi, sorry I was..." <- > <@yellowhatpro:matrix.org> bitmap yvanzo hi, sorry I was not around yday.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/FCbcXIiwySpxqGqBxjHauMXa>)
      • 2024-08-30 24311, 2024

      • BrainzGit
        [troi-recommendation-playground] 14mayhem opened pull request #149 (03main…troi-fixes): Artist nosim fix https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24329, 2024

      • mayhem[m]
        lucifer: this is the nosim fix on the troi side.
      • 2024-08-30 24337, 2024

      • mayhem[m]
        I ❤️ the play queue on LB.
      • 2024-08-30 24341, 2024

      • mayhem[m]
        !m ansh & monkey
      • 2024-08-30 24342, 2024

      • BrainzBot
        You're doing good work, ansh & monkey!
      • 2024-08-30 24343, 2024

      • yellowhatpro[m]
        bitmap: ono, should I give toml-cli a try?
      • 2024-08-30 24343, 2024

      • yellowhatpro[m]
        I mean it's not too late ig 😓
      • 2024-08-30 24343, 2024

      • yellowhatpro[m]
      • 2024-08-30 24327, 2024

      • yellowhatpro[m]
        Earlier I was actually also trying to parse toml with yq, but it was not able to parse it.
      • 2024-08-30 24327, 2024

      • yellowhatpro[m]
        Then I got too frustrated it with so switched to yaml
      • 2024-08-30 24327, 2024

      • bitmap[m]
        <yellowhatpro[m]> "Earlier I was actually also..." <- > <@yellowhatpro:matrix.org> Earlier I was actually also trying to parse toml with yq, but it was not able to parse it.
      • 2024-08-30 24327, 2024

      • bitmap[m]
        > Then I got too frustrated it with so switched to yaml
      • 2024-08-30 24327, 2024

      • bitmap[m]
        I didn't see that `yq` could also allegedly parse TOML. do you remember what the issue was?
      • 2024-08-30 24313, 2024

      • yellowhatpro[m]
        not sure I forgor, but it was something like could not find the given key (like .database.pg_host)
      • 2024-08-30 24354, 2024

      • bitmap[m]
        `yq -p toml '.retry_task.retry_interval' < config/default.toml` works fine for me, for instance
      • 2024-08-30 24355, 2024

      • yellowhatpro[m]
        oohh
      • 2024-08-30 24359, 2024

      • yellowhatpro[m]
        ok I'll check it
      • 2024-08-30 24328, 2024

      • yellowhatpro[m]
        I'll change the config back to toml then
      • 2024-08-30 24312, 2024

      • bitmap[m]
        it fails with a weird error about arrays if I don't specify -p toml, even though the --help say it "tries to auto-detect the file format based off the extension." (I guess it doesn't try very hard.)
      • 2024-08-30 24322, 2024

      • bitmap[m]
        * it fails with a weird error about arrays if I don't specify -p toml, even though the --help says it "tries to auto-detect the file format based off the extension." (I guess it doesn't try very hard.)
      • 2024-08-30 24350, 2024

      • Gerjan has quit
      • 2024-08-30 24358, 2024

      • kellnerd[m] joined the channel
      • 2024-08-30 24359, 2024

      • kellnerd[m]
        Well, stdin does not have a .toml extension 😛
      • 2024-08-30 24321, 2024

      • minimal has quit
      • 2024-08-30 24317, 2024

      • bitmap[m]
        turns out I can't read very well!
      • 2024-08-30 24301, 2024

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo opened pull request #1118 (03master…array-move): chore: Remove dependency to array-move package https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24348, 2024

      • BrainzGit
        [bookbrainz-site] 14MonkeyDo closed pull request #1039 (03master…dependabot/npm_and_yarn/array-move-4.0.0): chore(deps): bump array-move from 3.0.1 to 4.0.0 https://github.com/metabrainz/bookbrainz-site/pul…
      • 2024-08-30 24319, 2024

      • pite joined the channel
      • 2024-08-30 24343, 2024

      • lucifer[m]
        monkey: mayhem `track.identifier` can be a string or an array of strings.
      • 2024-08-30 24309, 2024

      • lucifer[m]
        the first is historical LB implementation and the second is spec compliant updates made a few weeks ago.
      • 2024-08-30 24359, 2024

      • monkey[m]
        Yup, I traced back the commit 3 months ago :+1: Thanks for confirming
      • 2024-08-30 24325, 2024

      • lucifer[m]
        great
      • 2024-08-30 24333, 2024

      • lucifer[m]
        monkey: did you see my OAuth related message?
      • 2024-08-30 24312, 2024

      • lucifer[m]
        mayhem: should i merge and release troi and then LB?
      • 2024-08-30 24337, 2024

      • ericd[m] has quit
      • 2024-08-30 24301, 2024

      • monkey[m]
        <lucifer[m]> "[@monkey:chatbrainz.org](https:/..." <- Sorry, I forgot to respond as i was AFK. To be honest I don't remember either. Let me check
      • 2024-08-30 24353, 2024

      • monkey[m]
        https://github.com/metabrainz/metabrainz.org/pull… is open, has review comments I have to incorporate, after a good rebase. Will take care of that
      • 2024-08-30 24333, 2024

      • mayhem[m]
        <lucifer[m]> "mayhem: should i merge and..." <- sure, please!
      • 2024-08-30 24348, 2024

      • monkey[m]
        lucifer: https://github.com/metabrainz/metabrainz.org/pull… is up to date now. It has the UI parts but also a lot of other stuff. not sure if you wanted only the UI, in which case we might want to cherry-pick or create a new branch with UI modifications only.
      • 2024-08-30 24324, 2024

      • nbin_ has quit
      • 2024-08-30 24308, 2024

      • nbin joined the channel
      • 2024-08-30 24336, 2024

      • lucifer[m]
        [@monkey:chatbrainz.org](https://matrix.to/#/@monkey:chatbrainz.org) i don't think that PR has the pages I am talking about, page to list Oauth applications created and granted access to by the user and pages to create and edit Oauth applications
      • 2024-08-30 24314, 2024

      • monkey[m]
        I don't think any work was started on those pages. Do you remember if we have designs for them?
      • 2024-08-30 24310, 2024

      • monkey[m]
        Looks like we don't really mention them in the roadmap document either, I think it fell between the cracks.
      • 2024-08-30 24330, 2024

      • lucifer[m]
        monkey: yeah i think so.
      • 2024-08-30 24349, 2024

      • monkey[m]
        I see some designs in figma.
      • 2024-08-30 24300, 2024

      • monkey[m]
      • 2024-08-30 24335, 2024

      • lucifer[m] uploaded an image: (107KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/IMoJEEPVdERgTWieSJrqCJUX/image.png >
      • 2024-08-30 24339, 2024

      • lucifer[m] uploaded an image: (44KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/GKxzBKqbsPIkyaDOVBehwidq/image.png >
      • 2024-08-30 24347, 2024

      • lucifer[m]
        the pages that need to be designed.
      • 2024-08-30 24301, 2024

      • monkey[m]
        I see, thanks. I can adapt the mockups style and rework those pages. Where do you want me to work? Separate PR?
      • 2024-08-30 24311, 2024

      • lucifer[m]
        yes separate PR would be good.
      • 2024-08-30 24328, 2024

      • monkey[m]
        Will be a Monday thing, but it's on the list
      • 2024-08-30 24302, 2024

      • lucifer[m]
        sure sounds good, i'll update my branch based on latest master and you can branch off that.
      • 2024-08-30 24334, 2024

      • lucifer[m]
        it has react webpack and other basic structure setup so should make your work a little easier.
      • 2024-08-30 24353, 2024

      • monkey[m]
        Nice
      • 2024-08-30 24308, 2024

      • pite has quit
      • 2024-08-30 24332, 2024

      • pite joined the channel
      • 2024-08-30 24341, 2024

      • pite has quit
      • 2024-08-30 24319, 2024

      • BrainzGit
        [metabrainz.org] 14amCap1712 opened pull request #477 (03master…new-new-oauth): MeB OAuth - latest iteration https://github.com/metabrainz/metabrainz.org/pull…
      • 2024-08-30 24335, 2024

      • lucifer[m]
        monkey: ^
      • 2024-08-30 24315, 2024

      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #149 (03main…troi-fixes): Artist nosim fix https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24340, 2024

      • BrainzGit
        [listenbrainz-server] 14anshg1214 opened pull request #2972 (03master…fix-queue-delete): fix: Queue track deletion https://github.com/metabrainz/listenbrainz-server…
      • 2024-08-30 24341, 2024

      • BrainzGit
        [troi-recommendation-playground] release 03v2024.08.30.1 has been published by 14amCap1712: https://github.com/metabrainz/troi-recommendation…
      • 2024-08-30 24335, 2024

      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #2973 (03master…amCap1712-patch-1): Update troi to v2024.08.30. https://github.com/metabrainz/listenbrainz-server…
      • 2024-08-30 24351, 2024

      • pite joined the channel
      • 2024-08-30 24308, 2024

      • ansh[m]
        mayhem: Can I use test.lb for some time?
      • 2024-08-30 24347, 2024

      • mayhem[m]
        Yes sure.
      • 2024-08-30 24304, 2024

      • derat[m] joined the channel
      • 2024-08-30 24304, 2024

      • derat[m]
        bitmap: mind merging https://github.com/metabrainz/musicbrainz-server/… if it looks okay to you? reo and aerozol already okayed it