#metabrainz

/

      • d4rkie has quit

        • 2024-09-09 25303, 2024

      • d4rkie joined the channel

        • 2024-09-09 25319, 2024

      • Strykar has quit

        • 2024-09-09 25328, 2024

      • Strykar joined the channel

        • 2024-09-09 25304, 2024

      • pite has quit

        • 2024-09-09 25335, 2024

      • Kladky joined the channel

        • 2024-09-09 25331, 2024

      • Kladky has quit

        • 2024-09-09 25345, 2024

      • Kladky joined the channel

        • 2024-09-09 25350, 2024

      • d4rkie has quit

        • 2024-09-09 25316, 2024

      • d4rkie joined the channel

        • 2024-09-09 25333, 2024

      • SigHunter has quit

        • 2024-09-09 25336, 2024

      • SigHunter joined the channel

        • 2024-09-09 25323, 2024

      • lucifer[m]1
        zas: hi! can you please add test.critiquebrainz service to gateways?

        • 2024-09-09 25301, 2024

      • lucifer[m]1
        also, there is a new database critiquebrainz_test_db that needs to be added pg_hba.conf on production databases but I guess we'll need bitmap for that?

        • 2024-09-09 25315, 2024

      • BrainzGit
        [critiquebrainz] 14amCap1712 opened pull request #518 (03master…new-oauth): Test MeB OAuth provider https://github.com/metabrainz/critiquebrainz/pull…

        • 2024-09-09 25330, 2024

      • zas[m] joined the channel

        • 2024-09-09 25330, 2024

      • zas[m]
        lucifer: done, check https://test.critiquebrainz.org/

        • 2024-09-09 25354, 2024

      • zas[m]
        for db stuff, yes, check with bitmap

        • 2024-09-09 25312, 2024

      • lucifer[m]1
        great, thanks!

        • 2024-09-09 25355, 2024

      • ansh[m] has quit

        • 2024-09-09 25320, 2024

      • BobSwift[m] has quit

        • 2024-09-09 25335, 2024

      • minimal joined the channel

        • 2024-09-09 25330, 2024

      • Sophist-UK joined the channel

        • 2024-09-09 25343, 2024

      • Sophist_UK joined the channel

        • 2024-09-09 25302, 2024

      • Sophist_UK has quit

        • 2024-09-09 25359, 2024

      • monkey[m] has quit

        • 2024-09-09 25335, 2024

      • BrainzGit
        [musicbrainz-server] 14derat opened pull request #3377 (03master…copy_all): MBS-13757: Support unchecking recordings to update https://github.com/metabrainz/musicbrainz-server/…

        • 2024-09-09 25329, 2024

      • mayhem[m]
        lucifer: I didn't get around to working on the leaderboard page API call definitions yet (too much BS work atm). have you done any work on this front?

        • 2024-09-09 25340, 2024

      • lucifer[m]1
        [@mayhem:chatbrainz.org](https://matrix.to/#/@mayhem:chatbrainz.org) i didn't start yet because I figured we might want to do [@aerozol:matrix.org](https://matrix.to/#/@aerozol:matrix.org) 's suggestions first but can do before meeting if not

        • 2024-09-09 25335, 2024

      • mayhem[m]
        that suggestion is tricky on a number of fronts and will require more discussion at the summit. for now, we should proceed with the plans as laid out in the doc. let me finish off more stupid stuff and then take a stab at the API defs.

        • 2024-09-09 25324, 2024

      • mayhem[m]
        well, stupid stuff... plus... paying you, lol.

        • 2024-09-09 25350, 2024

      • BrainzGit
        [listenbrainz-server] 14anshg1214 opened pull request #2977 (03master…ansh/add-secondary-types): Add RG Secondary Types in cache https://github.com/metabrainz/listenbrainz-server…

        • 2024-09-09 25307, 2024

      • lucifer[m]1
        Sure I am around to discuss in half an hour

        • 2024-09-09 25317, 2024

      • mayhem[m]
        ok, let me hurry up with the boring shit.

        • 2024-09-09 25302, 2024

      • ansh[m] joined the channel

        • 2024-09-09 25302, 2024

      • ansh[m]
        lucifer: Hi! Can you please review LB#2977. I need secondary types for RG in the frontend, therefore updating the cache.

        • 2024-09-09 25303, 2024

      • BrainzBot
        Add RG Secondary Types in cache: https://github.com/metabrainz/listenbrainz-server…

        • 2024-09-09 25331, 2024

      • mayhem[m]
        lucifer: ready to start thinking about API endpoints

        • 2024-09-09 25326, 2024

      • mayhem[m]
        should this page be paginated? if so, add count/offset args to the API endpoint?

        • 2024-09-09 25315, 2024

      • lucifer[m]1
        mayhem: hi! so we will have an endpoint to retrieve the most recent donors and the biggest donors? both paginated?

        • 2024-09-09 25341, 2024

      • lucifer[m]1
        do we also want to do historical leaderboards? top donors of last year etc?

        • 2024-09-09 25344, 2024

      • mayhem[m]
        paginated yes.

        • 2024-09-09 25312, 2024

      • mayhem[m]
        I am unsure about the top donors page -- since we agreed that we didn't want to show amounts, showing a top donor page without amounts seems... strange. no?

        • 2024-09-09 25347, 2024

      • lucifer[m]1
        oh i thought we wanted to show amounts.

        • 2024-09-09 25358, 2024

      • lucifer[m]1
        so its not a leaderboard? just a list of patrons?

        • 2024-09-09 25357, 2024

      • mayhem[m] doesn't trust his bring

        • 2024-09-09 25306, 2024

      • mayhem[m]
        brain: brain. not bring.

        • 2024-09-09 25323, 2024

      • mayhem[m]
        so I double checked with monkey and we do want to show amounts.

        • 2024-09-09 25326, 2024

      • mayhem[m]
        so, then yes.

        • 2024-09-09 25346, 2024

      • lucifer[m]1
        right, iiuc. we settled on a recent donor lists and a leaderboard with amounts.

        • 2024-09-09 25307, 2024

      • monkey[m] joined the channel

        • 2024-09-09 25308, 2024

      • monkey[m]
        We could still have a leaderboard without amounts, but it's not as clear nor as enticing

        • 2024-09-09 25324, 2024

      • mayhem[m]
        I was just confused as usual. :)

        • 2024-09-09 25344, 2024

      • lucifer[m]1
        since we are doing leaderboards, do we want historical ones as well?

        • 2024-09-09 25305, 2024

      • mayhem[m]
        historical in which sense?

        • 2024-09-09 25319, 2024

      • lucifer[m]1
        last year's, last month's etc.

        • 2024-09-09 25339, 2024

      • mayhem[m]
        for now, lets keep it simple and just recent donations and top donations, paginated.

        • 2024-09-09 25349, 2024

      • lucifer[m]1
        sure will do.

        • 2024-09-09 25333, 2024

      • lucifer[m]1
        about storing flair in database, i think a JSONB column in the "user" table would make sense.

        • 2024-09-09 25343, 2024

      • mayhem[m]
        yep.

        • 2024-09-09 25302, 2024

      • lucifer[m]1
        okay so endpoints to store and update the flair.

        • 2024-09-09 25329, 2024

      • mayhem[m]
        where does caching of that info happen?

        • 2024-09-09 25337, 2024

      • lucifer[m]1
        redis.

        • 2024-09-09 25304, 2024

      • lucifer[m]1
        actually, no need to cache it.

        • 2024-09-09 25316, 2024

      • lucifer[m]1
        we always read the "user" table for username.

        • 2024-09-09 25328, 2024

      • lucifer[m]1
        so reading flair is another column in the same query.

        • 2024-09-09 25333, 2024

      • mayhem[m]
        ah, ok.

        • 2024-09-09 25342, 2024

      • lucifer[m]1
        the donation endpoints will be cached in redis.

        • 2024-09-09 25346, 2024

      • lucifer[m]1
        updated hourly i guess.

        • 2024-09-09 25338, 2024

      • mayhem[m]
        ok, leaderboard API endpoints defined in the doc.

        • 2024-09-09 25338, 2024

      • lucifer[m]1
        cool will implement.

        • 2024-09-09 25355, 2024

      • mayhem[m]
        all 4 of those?

        • 2024-09-09 25359, 2024

      • mayhem[m]
        or just 2?

        • 2024-09-09 25300, 2024

      • lucifer[m]1
        sure

        • 2024-09-09 25316, 2024

      • lucifer[m]1
        all 4. can divide if you prefer.

        • 2024-09-09 25336, 2024

      • mayhem[m]
        it would be great if you can do all 4 -- this week is looking like a business heavy week for me.

        • 2024-09-09 25350, 2024

      • lucifer[m]1
        no worries, can do all.

        • 2024-09-09 25301, 2024

      • mayhem[m]
        I just realized that I really need to do Q3 finances at least a bit to arrive at a financial picture I can present at the summit.

        • 2024-09-09 25304, 2024

      • mayhem[m]
        great, thanks.

        • 2024-09-09 25348, 2024

      • pite joined the channel

        • 2024-09-09 25305, 2024

      • lucifer[m]1
        mayhem: there is an issue with donations in MeB, only username is stored and not user id. so issues with donors who changed musicbrainz username.

        • 2024-09-09 25357, 2024

      • mayhem[m]
        feck.

        • 2024-09-09 25335, 2024

      • mayhem[m]
        well, if we change that and store UID as well, then LB leaderboard page would be fine going forward, yes?

        • 2024-09-09 25358, 2024

      • lucifer[m]1
        yes.

        • 2024-09-09 25325, 2024

      • mayhem[m]
        we should probably do that first then, I guess.

        • 2024-09-09 25322, 2024

      • lucifer[m]1
        we can handle usernames too for historical donors too. plus least create a copy script to copy over user ids for previous ones.

        • 2024-09-09 25330, 2024

      • lucifer[m]1
        mayhem[m]: sure

        • 2024-09-09 25335, 2024

      • mayhem[m]
        great -- I think don't worry about resolving historical donors who have renamed their accounts. lets deal with those by hand as they arives -- there may not be any. or at least very few.

        • 2024-09-09 25303, 2024

      • mayhem[m]
        * think don't we need to worry about

        • 2024-09-09 25317, 2024

      • PBryan[m] has quit

        • 2024-09-09 25329, 2024

      • The_Buhs has left the channel

        • 2024-09-09 25332, 2024

      • mayhem[m]
        monkey: ansh https://community.metabrainz.org/t/german-wikiped…

        • 2024-09-09 25359, 2024

      • monkey[m]
        Huh.

        • 2024-09-09 25353, 2024

      • reosarevok[m] joined the channel

        • 2024-09-09 25353, 2024

      • reosarevok[m]
        Mine is in French

        • 2024-09-09 25353, 2024

      • monkey[m]
        HUH.

        • 2024-09-09 25355, 2024

      • reosarevok[m]
        There's no English, so we default to whatever seems next best

        • 2024-09-09 25359, 2024

      • reosarevok[m]
        That's what we do in MB anyway

        • 2024-09-09 25304, 2024

      • reosarevok[m]
        Not sure how LB does it

        • 2024-09-09 25315, 2024

      • monkey[m]
        This in french for me too, but I assumed that it was because of my setup: https://musicbrainz.org/artist/a9fe9e6a-9b16-42d1…

        • 2024-09-09 25319, 2024

      • mayhem[m]
        doesn't LB use the MB endpoint?

        • 2024-09-09 25325, 2024

      • reosarevok[m]
        Then that'd be why :)

        • 2024-09-09 25326, 2024

      • monkey[m]
        In LB, we just fetch from MB directly

        • 2024-09-09 25336, 2024

      • mayhem[m]
        ok, let me respond.

        • 2024-09-09 25353, 2024

      • mayhem[m]
        but, why is it that we don't serve the same language consistently?

        • 2024-09-09 25355, 2024

      • mayhem[m]
        is that a bug?

        • 2024-09-09 25307, 2024

      • reosarevok[m]
        We do serve consistently to the same user, in general

        • 2024-09-09 25315, 2024

      • monkey[m]
        Possibly? I do see it in german on the LB page https://listenbrainz.org/artist/a9fe9e6a-9b16-42d…

        • 2024-09-09 25323, 2024

      • monkey[m]
        But in frenhc using https://musicbrainz.org/artist/a9fe9e6a-9b16-42d1…

        • 2024-09-09 25350, 2024

      • reosarevok[m]
        It might be that MB detects you prefer French, but the call in the backend to LB doesn't have that info

        • 2024-09-09 25358, 2024

      • reosarevok[m]
        bitmap might have ideas too :)

        • 2024-09-09 25341, 2024

      • monkey[m]
        The issue being that the call is not made on the back-end, but directly in the front-end. I see it in my network tab

        • 2024-09-09 25328, 2024

      • monkey[m]
        reosarevok[m]: Most likely something like that, but not sure why the call from LB front-end is served GE instead of FR 🤔

        • 2024-09-09 25338, 2024

      • monkey[m]
        DE*

        • 2024-09-09 25342, 2024

      • reosarevok[m]
        Both you and I have French on our MB user languages

        • 2024-09-09 25303, 2024

      • reosarevok[m]
        mayhem: what do you see in https://musicbrainz.org/artist/a9fe9e6a-9b16-42d1… ?

        • 2024-09-09 25321, 2024

      • mayhem[m]
        Swahili.

        • 2024-09-09 25322, 2024

      • mayhem[m]
        odd.

        • 2024-09-09 25339, 2024

      • mayhem[m]
        ah, no. its german. I confuse swahili and german all the time.

        • 2024-09-09 25350, 2024

      • reosarevok[m]
        heh

        • 2024-09-09 25304, 2024

      • reosarevok[m]
        Ok, so each one of us gets the language we have on our user defined languages, as intended

        • 2024-09-09 25305, 2024

      • reosarevok[m]
        That's good

        • 2024-09-09 25316, 2024

      • reosarevok[m]
        Now, what happens with the LB request I dunno :)

        • 2024-09-09 25327, 2024

      • reosarevok[m]
        When logged out I get DE

        • 2024-09-09 25347, 2024

      • mayhem[m]
        🙈🙉🙊

        • 2024-09-09 25348, 2024

      • reosarevok[m]
        So I guess DE is just the default unless you have FR selected

        • 2024-09-09 25314, 2024

      • monkey[m]
        Ah, fair enough, thanks. In incognito mode I get the German version. So since we do the LB front-end call without a cookie attached, I suppose, it does not fetch my user info and the FR hint

        • 2024-09-09 25359, 2024

      • reosarevok[m]
        Yeah

        • 2024-09-09 25325, 2024

      • reosarevok[m]
        We could maybe modify the endpoint to only send English (or whatever the requested language) and return nothing otherwise, I guess?

        • 2024-09-09 25338, 2024

      • reosarevok[m]
        As in, having a param for language

        • 2024-09-09 25352, 2024

      • reosarevok[m]
        Since LB is more... eh, maybe dumbed down is not the right word 😅

        • 2024-09-09 25358, 2024

      • reosarevok[m]
        Slick-intended? :D

        • 2024-09-09 25308, 2024

      • reosarevok[m]
        Maybe the clash of languages is more jarring than for MB users

        • 2024-09-09 25333, 2024

      • reosarevok[m]
        "non-weirdo-friendly"? :p

        • 2024-09-09 25345, 2024

      • monkey[m]
        Not sure if no extract is better than an extract in another language, but it might be nice to let users know this is 'normal' as there is no article in $language

        • 2024-09-09 25322, 2024

      • reosarevok[m]
        I think for many people it might be tbh

        • 2024-09-09 25331, 2024

      • reosarevok[m]
        But your choice (as in the LB team's)

        • 2024-09-09 25359, 2024

      • kellnerd[m] joined the channel

        • 2024-09-09 25300, 2024

      • kellnerd[m]
        In BB I've implemented the language selection based on the accept-language header before falling back to English (and the alias languages): https://github.com/metabrainz/bookbrainz-site/pul…

        • 2024-09-09 25310, 2024

      • kepstinbrainz joined the channel

        • 2024-09-09 25311, 2024

      • kepstinbrainz
        shouldn't it prefer to use the selected UI language above the browser language? since people can change that separately.

        • 2024-09-09 25314, 2024

      • kellnerd[m]
        In MB that happens IIRC, but neither LB nor BB have alternative UI languages yet.

        • 2024-09-09 25322, 2024

      • reosarevok[m]
        When do we make LB translatable? I'd love to work on translating it 😅

        • 2024-09-09 25313, 2024

      • mayhem[m]
        perhaps next year. but let us get some complaints about it being only in english first. ;)

        • 2024-09-09 25346, 2024

      • reosarevok[m]
        heh

        • 2024-09-09 25306, 2024

      • reosarevok[m]
        Well, I guess the main point is that the people who would use it in their language might not even find them otherwise, but I agree it's not urgent

        • 2024-09-09 25319, 2024

      • reosarevok[m]
        Just something that I'd enjoy working on

        • 2024-09-09 25316, 2024

      • Jigen
        are we really doing the "browser guess the language based on browser settings" for lb? uh, cna we not. i HATE when websites/apps do that

        • 2024-09-09 25305, 2024

      • Jigen
        we can do a banner "we guessed your language blah, yo ucna change it at link" for the first time someone visits though. that's a good idea

        • 2024-09-09 25335, 2024

      • kepstinbrainz
        honestly, if the ui isn't translated then you probably should always be using the english wikipedia extracts