zas: hi! can you please add test.critiquebrainz service to gateways?
also, there is a new database critiquebrainz_test_db that needs to be added pg_hba.conf on production databases but I guess we'll need bitmap for that?
lucifer: I didn't get around to working on the leaderboard page API call definitions yet (too much BS work atm). have you done any work on this front?
lucifer[m]1
[@mayhem:chatbrainz.org](https://matrix.to/#/@mayhem:chatbrainz.org) i didn't start yet because I figured we might want to do [@aerozol:matrix.org](https://matrix.to/#/@aerozol:matrix.org) 's suggestions first but can do before meeting if not
mayhem[m]
that suggestion is tricky on a number of fronts and will require more discussion at the summit. for now, we should proceed with the plans as laid out in the doc. let me finish off more stupid stuff and then take a stab at the API defs.
lucifer: ready to start thinking about API endpoints
should this page be paginated? if so, add count/offset args to the API endpoint?
lucifer[m]1
mayhem: hi! so we will have an endpoint to retrieve the most recent donors and the biggest donors? both paginated?
do we also want to do historical leaderboards? top donors of last year etc?
mayhem[m]
paginated yes.
I am unsure about the top donors page -- since we agreed that we didn't want to show amounts, showing a top donor page without amounts seems... strange. no?
lucifer[m]1
oh i thought we wanted to show amounts.
so its not a leaderboard? just a list of patrons?
mayhem[m] doesn't trust his bring
mayhem[m]
brain: brain. not bring.
so I double checked with monkey and we do want to show amounts.
so, then yes.
lucifer[m]1
right, iiuc. we settled on a recent donor lists and a leaderboard with amounts.
monkey[m] joined the channel
monkey[m]
We could still have a leaderboard without amounts, but it's not as clear nor as enticing
mayhem[m]
I was just confused as usual. :)
lucifer[m]1
since we are doing leaderboards, do we want historical ones as well?
mayhem[m]
historical in which sense?
lucifer[m]1
last year's, last month's etc.
mayhem[m]
for now, lets keep it simple and just recent donations and top donations, paginated.
lucifer[m]1
sure will do.
about storing flair in database, i think a JSONB column in the "user" table would make sense.
mayhem[m]
yep.
lucifer[m]1
okay so endpoints to store and update the flair.
mayhem[m]
where does caching of that info happen?
lucifer[m]1
redis.
actually, no need to cache it.
we always read the "user" table for username.
so reading flair is another column in the same query.
mayhem[m]
ah, ok.
lucifer[m]1
the donation endpoints will be cached in redis.
updated hourly i guess.
mayhem[m]
ok, leaderboard API endpoints defined in the doc.
lucifer[m]1
cool will implement.
mayhem[m]
all 4 of those?
or just 2?
lucifer[m]1
sure
all 4. can divide if you prefer.
mayhem[m]
it would be great if you can do all 4 -- this week is looking like a business heavy week for me.
lucifer[m]1
no worries, can do all.
mayhem[m]
I just realized that I really need to do Q3 finances at least a bit to arrive at a financial picture I can present at the summit.
great, thanks.
pite joined the channel
lucifer[m]1
mayhem: there is an issue with donations in MeB, only username is stored and not user id. so issues with donors who changed musicbrainz username.
mayhem[m]
feck.
well, if we change that and store UID as well, then LB leaderboard page would be fine going forward, yes?
lucifer[m]1
yes.
mayhem[m]
we should probably do that first then, I guess.
lucifer[m]1
we can handle usernames too for historical donors too. plus least create a copy script to copy over user ids for previous ones.
mayhem[m]: sure
mayhem[m]
great -- I think don't worry about resolving historical donors who have renamed their accounts. lets deal with those by hand as they arives -- there may not be any. or at least very few.
ah, no. its german. I confuse swahili and german all the time.
reosarevok[m]
heh
Ok, so each one of us gets the language we have on our user defined languages, as intended
That's good
Now, what happens with the LB request I dunno :)
When logged out I get DE
mayhem[m]
🙈🙉🙊
reosarevok[m]
So I guess DE is just the default unless you have FR selected
monkey[m]
Ah, fair enough, thanks. In incognito mode I get the German version. So since we do the LB front-end call without a cookie attached, I suppose, it does not fetch my user info and the FR hint
reosarevok[m]
Yeah
We could maybe modify the endpoint to only send English (or whatever the requested language) and return nothing otherwise, I guess?
As in, having a param for language
Since LB is more... eh, maybe dumbed down is not the right word 😅
Slick-intended? :D
Maybe the clash of languages is more jarring than for MB users
"non-weirdo-friendly"? :p
monkey[m]
Not sure if no extract is better than an extract in another language, but it might be nice to let users know this is 'normal' as there is no article in $language
