#metabrainz

/

      • reosarevok[m]
        Jade: are you around and do you wanna start? :)
      • Guess not. kellnerd? :)
      • kellnerd[m]
        Yes and no πŸ˜›
      • (Need a few more minutes please)
      • reosarevok[m]
        Ok. I'll just start πŸ˜…
      • yvanzo[m]
        That’s a self double yes! πŸ˜‰
      • reosarevok[m]
        Hi! This week I worked on finally getting our MBS code working with Eslint 9, which also involved un-spaghettiing the guess case code a bit
      • (it's still a mess)
      • I also spent some time looking into STYLE-2555 (more comments on https://community.metabrainz.org/t/split-withdr... always welcome although it seems we have a reasonably good idea where to move with it)
      • BrainzBot
        STYLE-2555: Change 'Withdrawn' Release Status, add 'Expunged' https://tickets.metabrainz.org/browse/STYLE-2555
      • reosarevok[m]
        And updating MBS-1658 so that maybe we can test it - I should throw it up on test tomorrow
      • BrainzBot
        MBS-1658: My Collection: add free text comment field https://tickets.metabrainz.org/browse/MBS-1658
      • reosarevok[m]
        I also worked on MBS-9253 which apparently aerozol is very excited about
      • BrainzBot
        MBS-9253: List EP release groups above singles on artist pages https://tickets.metabrainz.org/browse/MBS-9253
      • reosarevok[m]
        And the usual support and community and whatnot plus some Spanish translation
      • bitmap: what about you?
      • bitmap[m]
        hi
      • last week I continued working on the React components for loading/editing alternative tracklists...the state management is pretty close to working, and I'll probably be able to write the edit submission code this week
      • I also reviewed various PRs and submitted one to disable cover art/image editing for the time being (deployed by yvanzo today)
      • fin. mayhem want to go next?
      • mayhem[m]
        hello!
      • last week was a rough week -- I mostly spent the time recovering from travel/jetlag and being sick. so very not fun,
      • but I did get moving on finishing the accounting mess I discovered in mid-september. with lucifer
      • 's help I've managed to now get the accounts to balance again.
      • took days to get that sorted out. I'm not nearly caught up on everything business and am hoping to return to some technical work soon.
      • fin. lucifer go!
      • lucifer[m]
        hi all!
      • reosarevok[m]
        He also does accounting? 😱
      • Still on my list: JadedBlueEyes, kellnerd, pranav, MonkeyPython, monkey, ansh, atj, akshaaatt, yellowhatpro, derat, yvanzo, theflash_, zas, rimskii, jasje, ericd
      • lucifer[m]
        last week, i worked on finishing and shipping the user data exports.
      • other than that, i progressed on last.fm backend importer.
      • that's it for me. monkey next?
      • monkey[m]
        Hello!
      • Last week I finished improving the artist page on LB with "better" (at least simpler) album sorting. Thanks to those who participated for their help and feedback
      • I also reviewed and prodded some PRs we have in progress
      • On the BB side I worked on migrating to Bootstrap 5 with React-Bootstrap 2, and also taking care of old depe3ndencies
      • As well as some security tickets
      • That's mostly it for me, a few other small bugs squashed and PRs merged.
      • derat: you're up !
      • reosarevok[m]
        derat is not on today's list :)
      • Oh, he is
      • derat should not be on today's list 🫣
      • yvanzo[m]
        but he doesn’t seem to be up.
      • monkey[m]
        Woops. rimskii you're up !
      • reosarevok[m]
        Yeah, he did say he'd skip a couple weeks :)
      • yvanzo[m]
        You can also use Matrix to see who is actively following messages.
      • reosarevok[m]
        yvanzo: go for now maybe? :)
      • Still on my list: JadedBlueEyes, kellnerd, pranav, MonkeyPython, ansh, atj, akshaaatt, yellowhatpro, theflash_, zas, rimskii, jasje, ericd
      • yvanzo[m]
        Yes and yes!
      • Last week, I reviewed security alerts and patched MBS as needed.
      • I prepared migrating services to the new server, and did some maintenance.
      • Disabled our services related to the Internet Archive until they fully recovered.
      • Updated MB servers today as bitmap mentioned it to temporarily turn off images editing.
      • Thanks to derat, Divyansh Gupta, and Serial-ATA for their contributed code changes!
      • yellowhatpro: go!
      • yellowhatpro[m] joined the channel
      • yellowhatpro[m]
        hi everyone!
      • last week was all about convocation
      • I recently got graduated and now I am back home for some time for Diwali
      • gonna be AFK for sometime
      • That's it from my side, jasje next?
      • jasje[m]
        Hi everyone!
      • reosarevok[m]
        Still on my list: JadedBlueEyes, kellnerd, pranav, MonkeyPython, ansh, atj, akshaaatt, theflash_, zas, rimskii, ericd
      • jasje[m]
        Last week, I was working on some DX changes that would enable us to easily support dialogs in a drop in component manner.
      • Re iterated on some usages of dialogs in profile tab
      • Pushed and more one the way
      • Other than that
      • Went to an event where i was invited as a speaker :P
      • Made people aware about projects at MeB
      • I hope we get slight influx in contributions
      • Fingers crossed
      • Thats it for me
      • ansh: next?
      • ansh[m] joined the channel
      • ansh[m]
        Hi Everyone!
      • Last week, I mainly spent time on some tickets and reviewing couple of PRs.
      • I also worked on the user flair settings page and a bit on the new recordings page.
      • That’s it for me
      • zas: next?
      • zas[m]
        Hey
      • Last week I took care of SOLR cluster instabilities we had on Thursday/Friday, likely related to some queries from bots
      • Everything is now back to normal
      • I also upgraded systems, Grafana & Discourse (and we have a pending upgrade for SOLR / Java to do this week)
      • I ordered a new AX102 server which finally arrived today (selda), it is now ready for us to migrate services to it, thanks to the help of atj for noble (24.04) minor Ansible fixes
      • Plus usual user support, MB edits, etc. theflash__ (IRC) ?
      • or kellnerd ?
      • kellnerd[m]
        Sure
      • Hi and sorry for the earlier delay, I just came back from dinner.
      • Last week I had to deal with some annoying API changes which caused Harmony to seed bad data, this time Spotify was the culprit.
      • While I was already at addressing forum feedback, I did some more QoL improvements and spent time replying to the feedback, which took longer than expected 🫠
      • Also dealt with some userscript issues / reviewed PRs, and thought about MB style tickets.
      • Which means I only found little time for GSoC, reviewing my latest work before the summit and reading my notes about the next steps πŸ˜…
      • That's it, what about you MonkeyPython?
      • reosarevok[m]
        MonkeyPython (IRC)
      • kellnerd[m]
        Or atj?
      • yvanzo[m]
        Who’s left and has never been called? akshaaatt atj, pranav, ericd
      • kellnerd[m]
        Nobody? πŸ˜”
      • yvanzo[m]
        zas, reosarevok: The agenda items were from last week?
      • zas[m]
        yes
      • reosarevok[m]
        Yes, although maybe zas' item is still relevant
      • If not, that's about it
      • yvanzo[m]
        OK, thanks everyone!
      • reosarevok[m]
        For my topic: the person agreed to change the username, which is nice
      • zas[m]
        Well, AX102 is here, we'll proceed with the move tomorrow, PR was opened by yvanzo already.
      • reosarevok[m]
        I see atj is actually around :) In case he wants to say something?
      • zas[m]
        bitmap: perhaps a word about rate limit & harmony?
      • yvanzo[m]
        monkey, lucifer: There are a few more security updates to look into :) https://tickets.metabrainz.org/issues/?filter=1...
      • bitmap[m]
        sure, I was wondering last week about kellnerd's messages related to Harmony hitting the mbws rate limit (I guess it's on the same machine as a-tisket too)
      • since these tools are so important for MB editors maybe we can increase the mbws rate limit for this machine?
      • kellnerd[m]
        It's not too bad yet fwiw, but since the MB provider and the external artist/label link seeding have been added, I am seeing MB warning responses more frequently
      • zas[m]
        I have nothing against it, I just need IP used for it and we can have a specific limit for it. Do you have any idea about the number of refused requests due to rate limit?
      • bitmap[m]
        ok, I was only unsure how much of a problem it is and what rate limit would be appropriate
      • kellnerd[m]
        Not too many, I will check the logs...
      • zas[m]
        kellnerd: ping me when you have some numbers, I'll prepare the changes anyway
      • MonkeyPython
        augh
      • RL iskickingmy ass k
      • reosarevok[m]
        Hi MonkeyPython (IRC), wanna review? Or is that the review, which seems fair too πŸ˜…
      • MonkeyPython
        [18:18] MonkeyPython my review for today is "too much IRL shit getting in the way of doing online shit" (I'm exhausted lol)
      • [18:18] MonkeyPython This week I will again not have much time because RL stuff. but monkey pls hit me up the 2-3 tickets/bbcommunity posts of highest importance so I can get started, thanks :D (reading is a free move idk :D)
      • [18:18] MonkeyPython ""
      • [18:18] MonkeyPython and that's it, next who can go is idk whoever is a fish today
      • <-- sleep
      • reosarevok[m]
        Oh, if you sent that to me via IRC, sorry, I did not have IRC logged in on Windows right now
      • [cough] which is why we use the email, but :)
      • MonkeyPython
        T_T ok
      • reosarevok[m]
        Anything else for today or should we stop? :)
      • Ok, seems like we're done :)
      • Thanks everyone, and see you next Monday!
      • </BANG>
      • dseomn_ joined the channel
      • kellnerd[m]
        <zas[m]> "kellnerd: ping me when you..." <- There are only 18 "Your requests are exceeding the allowable rate limit." warnings within the last 45 hours (since the last restart), 50 since last Monday. They are usually many minutes/hours aparts, repeated errors within a few seconds only occurred 4 times.
      • dseomn has quit
      • dseomn_ is now known as dseomn
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged and not empty as it is bridged to IRC; see https://musicbrainz.org/doc/ChatBrainz for details | Agenda: Reviews
      • I still have two ideas, one already implemented, how Harmony could be improved a little.
      • I think they mostly happen in situations when the MBID resolver (which might issue a burst of requests and follows the X-RateLimit headers) exhausts the limit and stops. Then a single lookup request from the MB provider (which does 5 req/5s because it unfortunately can't use the same MB client) is enough to trigger the warning πŸ€”
      • bitmap[m]
        what about a-tisket, do you know how frequently that makes mbws requests?
      • kellnerd[m]
        No idea, I don't have access to the process to check the logs (if they are useful to determine this at all), you would have to ask atj.
      • Probably less than Harmony as a-tisket doesn't resolve as many artists to MBIDs? Nevertheless a-tisket takes a longer time to load for an (uncached) release with many artists to resolve, so it might spread the MB requests more evenly than I thought... But I haven't checked the code.
      • bitmap[m]
        sounds like we should at least double the number of allowed requests (20 per 10s) if you have two clients already following the standard rate limit, at a minimum. and if it's still running into problems due to a-tisket it could be tweaked further
      • kellnerd[m]
        "Following the standard rate limit" 😁 Only the MB provider in Harmony does that in a narrow sense (5 req/5 s), MBID resolving only obeys to the rate limit headers πŸ™‰
      • > Resolving external IDs to MBIDs took 6959 ms and 29 API requests
      • (Request burst example from my last test)
      • But that is an exception, a bog standard release with one or two artists takes much less requests to resolve to MBIDs.
      • MonkeyPython
        kellnerd[m]: *any* chance of an optionof https://community.metabrainz.org/t/harmony-musi... ?? πŸ₯Ί
      • πŸ™
      • kellnerd[m]
        Sorry, having such an option is more work than it sounds with a dumb static page (which Harmony currently is).
      • I could probably implement a userscript hack more quickly than to integrate it into the website cleanly at this point 😭
      • MonkeyPython
        +++ i'm fine with that aproach!
      • kellnerd[m] sent a js code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/ldltMgdYCpeIfXEFhZzmRYJq