reosarevok: I was picking up CB-427 again. I wanted to confirm on what all things will be returned by the endpoint. Is there anything else that you'd like the endpoint to return other than these? https://p.ip.fi/5PDC
I think that's all MB would need (and a lot more, but I guess that's fine as long as it doesn't make the call hit CB a lot harder than it needs to)
I think all I'd need is to be able to call like "release group with MBID X" and get the most recent review, the latest review, the review count (for reviews with text, ideally) and the average rating
I guess `sort => 'published_on',` is no longer relevant if you return the most recent anyway (I assume if you return more than one latest, those will be sorted so that the most recent is first?)
But `review_type => 'review',` would still make sense to us
ansh[m]
reosarevok[m]: In the new endpoint we're returning both `5 top_reviews` and `5 latest_reviews`
reosarevok[m]: Cool! I'll add that here
reosarevok[m]
I only need the toppiest top and latestiest last right now but if I can just take the first for each that's fine
(Those are words now)
What might be confusing is that we don't want the ratings to filter out numeric ratings tho
Only the returned top and latest reviews
I mean, IMO that makes sense, but it should be documented :)
That review_type affects the returned review bits but not the rating bits
ansh[m]
Yes, that's clear. I'll add this information clearly in the API documentation too
derat[m]
<reosarevok[m]> "derat: do you have time / intere..." <- i was thinking of looking at it this week but i'm not sure if i'll get to it, and my perl is still awful, so please feel free to go for it. :-) i was thinking it might make sense to try to add load_primary_alias methods across the board for more entity types so the localized names can be shown in more places, but i'm not sure of the performance implications of doing that.
I think it does make sense, but we'll have to look at the implications while testing it :)
ansh: if it makes sense to save bandwidth for CB / speed up responses, you can also have a parameter to ask for the bare minimum MB needs vs all, but you know better than me how efficient that'd be
ansh[m]
<reosarevok[m]> "ansh: if it makes sense to..." <- Yes, I was also thinking on the same lines. We're are already caching couple of things internally to reduce the response time, but yes, i'll evaluate multiple options
BrainzGit
[listenbrainz-server] 14mayhem opened pull request #3033 (03master…timescale-write-hail-mary): timescale robustness improvement, might be futile, lol https://github.com/metabrainz/listenbrainz-serv...
mayhem[m]
monkey: I reviewed the timescale writer, but there isn't much that can be changed. see the PR desc for details.
mayhem, ansh : What did we decide in the end regarding flairs eligibility? Donations need to be >= 5$ and are valid for a month starting from donation date? Is that correct?
(Reviewing texts and explanations regarding flairs)
mayhem[m]
yes right, yes
monkey[m]
Thanks
One month seems short in retrospect, but ¯_ (ツ)_/¯.
mayhem[m]
on MB we have a nag dialog for taggers users and we don't show the nag for a month for $4. plus inflation, seems like a good starting point.
and I am not dead set on that. if people complain, then we'll reconsider.
aerozol: I am getting ready to release the Atom feeds code. How would you like to coordinate this release?
reosarevok[m]
For a flair I'd expect even $1 would be enough, but then, I expect out of a $1 donation after fees we get like 5 cents, so... 😅
kellnerd[m]
What about annual donations? I would expect someone who donates 60$ each year to keep the flair all year and not just for a month. With respect to fees we should probably not encourage those people to switch to smaller monthly donations where less money reaches MetaBrainz.
thumay joined the channel
thumay has quit
minimal joined the channel
pite joined the channel
monkey[m]
Fair point. I think we probably need to review this
reosarevok[m]
Yeah, agreed that if there's a minimum per month, then minimum * x should mean x months
(a usual subscription service would even say x + 1 months! :p )
mayhem[m]
team: is anyone editing the post welcoming julian? you've locked me out.
can you please exit?
we really need to leave wordpress.
mayhem[m] uploaded an image: (40KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/ATUiJJlLvYmFNdWnWSStgxjU/image.png >
<reosarevok[m]> "Yeah, agreed that if there's a..." <- I took care of this already [@monkey:chatbrainz.org](https://matrix.to/#/@monkey:chatbrainz.org), [@kellnerd:matrix.org](https://matrix.to/#/@kellnerd:matrix.org), [@reosarevok:chatbrainz.org](https://matrix.to/#/@reosarevok:chatbrainz.org)
SigHunter has quit
SigHunter joined the channel
aerozol[m]
Nice words for the LB team:
Aerozol[m]1 uploaded an image: (23KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/AxYxWkoinerqtMdnkBOPRDUq/image.png >
Hey mayhem, can’t wait for the feeds to go live! Still been using mine. There is some outstanding tidying to do that was never addressed. I don’t think it’s a big job tbh (but correct me if I’m wrong), and would make it a bit less haphazard. Take a look
Unless some of this has been addressed but the doc isn’t updated, in which case great. Otherwise have a look and let me know if there’s someone we can task with the changes, or if you want me to try tackle what parts I can
monkey: reosarevok: I think having a monthly flair cost $5 will up donations considerably tbh. I also feel for those who can’t afford it or are in countries where the exchange rate makes that prohibitive. I still think eventually having a flair for 100k MB edits, 1mil MB edits, etc, could make it feel balanced (and that’s a substantial number/a few years of editing to reach, so I don’t think it would impact donations much if at
all). Just seeding the idea some more :D
mayhem[m]
aerozol: ah, I see. I didn't remember that these things were pending. I guess the release is off then.
[15:15] kellnerd[m] What about annual donations? I would expect someone who donates 60$ each year to keep the flair all year and not just for a month. <-- THIS forever
hmm
we could.. we could have some simplistic "only 1 dollah" level flairs which people who can't pay more can get. 🤔
but in order to get the ful scazoozzle, you need like 5 bucks or something
if only 1 then you get a selection of3-4 pre made ones.
but 5 or more it's full 9 yards of customization
aerozol[m]: ^^
Kladky joined the channel
aerozol[m]
AFAIK we have to be a little bit careful because we can't make it look like users are "buying" something, to pass the donation definition for legal stuff
Also I don't know if $1 /month is even worth the fees for MeB 🤔 even though it might be reachable for more users
