#metabrainz

[listenbrainz-server] 14Aerozol opened pull request #3126 (03master…improve-link-listens-text): LB-1724 Improve 'link listens' / 'link with musicbrainz' text https://github.com/metabrainz/listenbrainz-serv...

monkey: some lb local vibes here. I love how this is going to slowly happen. with or without us.

theme/theme.less, I see.

mayhem: In the Meb repo look into this file frontend/css/theme/variables.less

ahh, thanks!

zas: have you seen the prices they charge for .org renewals now? we need to move to a new provider. Sigh.

[metabrainz.org] 14mayhem opened pull request #497 (03master…fix-fonts): MEB-165: Make fonts as dark as allowed as per our guidelines. https://github.com/metabrainz/metabrainz.org/pu...

quicky for you, monkey

lucifer, mayhem : mapping information is not part of the data dumps currently, despite the PR merged and deployed last week. I think it is because the background-tasks container is still running an old version. Is it safe to deploy the newest image to that container?

i"m not sure. I'll leave lucifer to answer that.

[metabrainz.org] 14mayhem merged pull request #497 (03master…fix-fonts): MEB-165: Make fonts as dark as allowed as per our guidelines. https://github.com/metabrainz/metabrainz.org/pu...

sorry, user listens dumps* not data dumps

I think they key is to check to make sure no background tasks are currently scheduled. if there are none, we can restart. I just dont know how to check.

[metabrainz.org] release 03v-2025-01-14.0 has been published by 14mayhem: https://github.com/metabrainz/metabrainz.org/re...

empty. let me restart, monkey

mayhem: with newest image please ! Or I can do it if you prefer

go for it.

but before you make the actual restart, let me check the queue again, ok?

K

mayhem: i'm ready to press enter

go!

restarted, thanks

Hi monkey

I cant think of any other place to change volume

except the render function 🤔

Did you try calling setVolume somewhere?

not yet

but I believe ready event listener also gets called only once when its ready to stream

but lemme try putting it there

ok so I am able to change volume from has_player_state_changed listener but the listener fires randomly... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

monkey:

tried in many places

cant think of any other place to put it :(

same issue everywhere

I don't have any better suggestions I'm afraid. will have to try it myself

<monkey[m]> "I don't have any better suggesti..." <- ok it works when i put it in componentdidchange... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

:)

so now only 1 problem is there,... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

i'll have to look into it closer, when i have a moment i'll check your PR

I am having a problem with listenbrainz-server. I have followed the steps in the documentation and the website is running. But whenever I am running the ./develop.sh up command, the files in frontend/js/src are being recreated. When I am comparing the file content, it is the same but they are being shown as modified in my git status.

Also whenever I am making changes in the frontend, they are not being automatically compiled. On making changes, I have to close and run again the project to view changes.

It would be really helpful if someone could help me fix this issue.

how do you invoke develop.sh? I normally use "./develop.sh up web static_builder"

the static builder is what compiles all the JS/CSS stuff.

I am using "./develop.sh up" command only for running it at the beginning. Do I have to run "./develop.sh up web static_builder" in case I want to view the changes in the frontend after editing?

yes

Ok, thanks for the help.

ansh: monkey ok to have the LB meeting tomorrow?

yes

<gaurav993[m]1> "I am using "./develop.sh up..." <- actually on, running ./develop.sh up should start all the containers, including the static_builder.

no8

no*

gaurav993: Check your docker logs for possible errors thrown by the static_builder container.

Also be aware you'll need to hard refresh the web page to see changes. I set my browser developer console to "disable cache when devtools is open"

(in devtools Preferences>Network)

<monkey[m]> "gaurav993: Check your docker..." <- I checked the console, there were no errors. Disable cache options is already on. The problem is whenever i am making changes in frontend code, there were no changes in the websites, nor in the console.

There should definitely be some ouput from docker containers in your terminal

Check that and see if static-builder throws an error

<mayhem[m]> "ansh: monkey ok to have the LB..." <- Yes

monkey[m]: The console showed 0 errors and 27 warnings when I first ran the ./develop.sh up command. On checking static-builder logs in docker, there is no changes in it on making changes in frontend code.

lucifer: monkey ansh LB meeting tomorrow at 1600 UTC then?

(normal time for it, just on wednesday)

gaurav993[m]1: That is suspicious. Check where the last line of output from static_builder, and if it is about the container exiting, something is going wrong.

monkey[m]: The last line was webpack.Progess 100% and no changes since then. I think the changes made in frontend are not being detected.

could you try another file in src, maybe a .tsx file you haven't touched yet, and make an obvious change then check the logs, just to be certain

If still no change detected, then maybe there is an issue with docker or permissions or something like that.

monkey[m]: still no changes.

As a backup, you could run webpack locally. It's all the static_builder does

For that you'll want node installed, run npm install to install dependencies, then run npm run build

<gaurav993[m]1> "I am having a problem with..." <- Btw as I have mentioned here, on running static-builder, all the files in frontend are being recreated. I thought maybe it was due to this issue.

the files in src should definitely not be recreated. the dist folder however gets recreated

monkey[m]: Yes, this is what I was doing yesterday. I was running npm run build:dev command first, and then "./develop.sh up" command. In this cases the changes were being showed. But after sometimes it just automatically stops.

monkey[m]: the dist folder is created.

oof, that would possibly be messy

So, if you want to run webpack on your machine, you can't run it at the same time in docker, so you'll have to comment out static_builder in the docker-compose file.

That being said, if I were you i would try starting from scratch in another folder and trying the docker way (using develop.sh only, not running webpack manually) again to check

monkey[m]: I will try it once more. But I had already tried this the first time I tried to run the project. I have been getting this problem of frontend files being recreated and changes in code not being reflected on the website for a week. Since 2-3 days, I been trying to run static builder manually along with develop.sh so it made it a bit easier.

Did you make any changes to the docker-compose files prior to that? I don't understand how the frontend source file could be rewritten

* I will try it once more. But I had already tried this the first time I tried to run the project. I have been getting this problem of frontend files being recreated and changes in code not being reflected on the website for a week so i had to run develop.sh again and again. Since 2-3 days, I been trying to run static builder manually along with develop.sh so it made it a bit easier but it also stops working after making 2-3

changes in the code.

We do modify some files when webpack autoformats, for example, but it would not recreated all the files

monkey[m]: not made any changes.

Which OS are you on? And which flavour and version of docker are you using?

Windows, Docker version is 27.4.0. I have been using docker desktop application.

I wonder if this could be a permissions issue with docker desktop, I've seen similar issue before

who here is using the codacity app for github?

s/codacity/codacy/

<monkey[m]> "I wonder if this could be a..." <- Just tried everything by reinstalling docker, cloning a new repo, and following all the steps from start. Still the same issue. Seems there is some problem with my pc, will search a bit more about this.