#metabrainz

hi lucifer: thanks for the help, will give it a try

lucifer: got this error running build-mb-metadata-cache --use-mb-conn

mayhem: cool. also i think instead of `session["user"]` who should use `current_user`, if both are the same in your case

salaxceitor: you need to create this table. https://github.com/metabrainz/listenbrainz-serv...

lucifer: ahhh, yes. I was confused about that last night.

lucifer: also a regression has snuck in -- new user logins are no longer working. the login_id column doesn't get set anymore.

monkey: zas : since you two commented on the doc I introduced in last week's meeting, just wanted to let you know that I made some changes to it^, so I'd appreciate it if you could take a second look

^Added a proposal section before the tool descriptions, changed tool rankings, added some details to one of the tool descriptions

lucifer: it's already present in listenbrainz db, do you mean create it in mb ?

mayhem: the user.login_id = str(uuid.uuid4()) is not needed. i think if you just delete your local user table and recreate it everything should work fine

setting login_id for existing users will cause the user to logout from all other sessions. for instance, if you log in on chrome you get logged out on firefox etc.

I did recreate everything and it didn't work.

I can try it again.

mayhem: the if check inside the peewee.DoesNotExist looks wrong.

you are disallowing any non-admin user from creating an account

do you want to restrict registration on the server?

only users who have a (blank) row in the user table are allowed to log in.

account creation is entirely manual by the admin.

i see. so you need to set login_id when creating the blank row.

oki.

do you have an admin panel view to create users yet or should i add it and set it up?

I have it.

what would be a good way to add this UUID for when the user is created?

since the admin view is automated, I can't control the creation of records.

[listenbrainz-server] 14MonkeyDo merged pull request #3166 (03master…duplicate-notify): LB-1742 Notify user if they're adding a duplicate to a playlist https://github.com/metabrainz/listenbrainz-serv...

gimme a sec

pushed changes, mayhem

i set the default in the peewee model itself.

thank you!!

lolololol

Is that field enabled when visiting from Germany?

Faxe number = 10%

(and yes, this is a 1 liter can)

salaxceitor: the table needs to be in listenbrainz timescale db

lucifer: let me check

it's present in listenbrainz_ts -> public -> background_worker_state

i see

but I am using the flag --use-mb-conn

try creating the table in mb db too.

mayhem: can you review https://github.com/metabrainz/listenbrainz-serv...

ok, will do.

lucifer: can you do the final review here? https://github.com/metabrainz/listenbrainz-serv...

done

I'm going to deploy a new LB release very soon, there is a library update that broke a few pages, so deploying fix ASAP

Do y'all wan tot merge 3163 ? mayhem lucifer

I'd like that yes, but a final ok from lucifer would be good.

Does the release fix the apple playlists?

No idea which issue that is.

lucifer did give hiw OK on the PR, that's why I ask

his*

Gonna pop out to get food, release is ready to deploy so let me know

[listenbrainz-server] 14amCap1712 merged pull request #3163 (03master…LB-1730): Allow admins to "pause" a user's account https://github.com/metabrainz/listenbrainz-serv...

is merged now, go for it.

do you want to merge https://github.com/metabrainz/listenbrainz-serv... lucifer ?

yes

[listenbrainz-server] 14mayhem merged pull request #3178 (03master…test-persistence): Cache incremental listens and metadata tables in Spark https://github.com/metabrainz/listenbrainz-serv...

ok, monkey now proceed. :)

Weee!

[listenbrainz-server] release 03v-2025-02-17.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

Updating beta.LB, then prod if all goes well

lucifer or mayhem : can one of you run the sql script that came with the "pause account" PR please? Currently getting 500 error when accessing beta as the column is missing in the DB

k

(sorry, having food)

done.

Updating LB prod

[listenbrainz-server] 14dependabot[bot] opened pull request #3182 (03master…dependabot/npm_and_yarn/dompurify-3.2.4): Bump dompurify from 2.5.8 to 3.2.4 https://github.com/metabrainz/listenbrainz-serv...

^ Gotta review all uses of Dompurify in the PR before merging, just FYI

monkey: is this on your radar? https://tickets.metabrainz.org/browse/LB-1752

LB-1752: Export playlist to apple music broken

[musicbrainz-server] 14reosarevok opened pull request #3477 (03master…MBS-13939): MBS-13939: Don't reject BnF links with language code https://github.com/metabrainz/musicbrainz-serve...

<mayhem[m]> "monkey: is this on your radar..." <- No, but it is now I guess

and we really need to improve https://tickets.metabrainz.org/browse/LB-1592

LB-1592: Non-latin artist/tracks, accents and variations are not resolved properly on Spotify

Yes, we need aliases in metadata

I think we need to do this on the backend with all of our fuzzy tools/unidecode.

alias will only fix a tiny portion of this problem.

Would be useful for displaying on the website too

we need to throw the mapping tools at it. I can look at it after I finish the next round of mapping work.

[musicbrainz-server] 14reosarevok opened pull request #3478 (03master…MBS-13938): MBS-13938: Don't reject VIAF links with language code https://github.com/metabrainz/musicbrainz-serve...

lucifer: can you please review https://github.com/metabrainz/listenbrainz-serv... ? we really need to merge/deploy this.

the newly restarted container is making sentry freak out.

done

thx

[listenbrainz-server] 14mayhem merged pull request #3090 (03master…add-sentry-cron-monitoring): Add sentry cron monitoring https://github.com/metabrainz/listenbrainz-serv...

[musicbrainz-server] 14mwiencek merged pull request #3476 (03master…usetable-key-warnings): Avoid spreading `key` props in `useTable` hook https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14mwiencek merged pull request #3467 (03master…mbs-13925): MBS-13925: Instrument name erroneously displayed in link type autocomplete https://github.com/metabrainz/musicbrainz-serve...

[listenbrainz-android] 14rahul31124 opened pull request #551 (03main…fix-crash-for-add-queue): Fixed crash for add queue option https://github.com/metabrainz/listenbrainz-andr...

[musicbrainz-server] 14reosarevok merged pull request #3450 (03master…MBS-13597): MBS-13597: Add release filter to label index pages https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #1171 (03master…MBS-8328): MBS-8328 / MBS-13917: Limit work authors to authorship rels https://github.com/metabrainz/musicbrainz-serve...

monkey: I was reviewing ticket LB-1753 — do we want to create playlists for series?

LB-1753: create playlist from MusicBrainz series https://tickets.metabrainz.org/browse/LB-1753

If yes, do we have separate playlists for recordings and series? Or allow both of them in one playlist?

[musicbrainz-server] 14mwiencek merged pull request #3456 (03master…tar-no-same-owner): add --no-same-owner option to tar https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #3471 (03master…MBS-13928): MBS-13928: Use jaxsta.com instead of jaxsta.io https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #3465 (03master…MBS-13763): MBS-13763: Add past year stats to the editors statistic page https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #3464 (03master…MBS-13914): MBS-13914: Validate vote arguments for voter edit search https://github.com/metabrainz/musicbrainz-serve...

:D

[listenbrainz-server] 14anshg1214 opened pull request #3183 (03master…ansh/add-recording-page): feat: Add Recordings page https://github.com/metabrainz/listenbrainz-serv...

🦋