lucifer: ahhh, yes. I was confused about that last night.
lucifer: also a regression has snuck in -- new user logins are no longer working. the login_id column doesn't get set anymore.
HemangMishra[m] has quit
julian45[m] joined the channel
julian45[m]
monkey: zas : since you two commented on the doc I introduced in last week's meeting, just wanted to let you know that I made some changes to it^, so I'd appreciate it if you could take a second look
^Added a proposal section before the tool descriptions, changed tool rankings, added some details to one of the tool descriptions
lucifer: it's already present in listenbrainz db, do you mean create it in mb ?
lucifer[m]
mayhem: the user.login_id = str(uuid.uuid4()) is not needed. i think if you just delete your local user table and recreate it everything should work fine
setting login_id for existing users will cause the user to logout from all other sessions. for instance, if you log in on chrome you get logged out on firefox etc.
mayhem[m]
I did recreate everything and it didn't work.
I can try it again.
lucifer[m]
mayhem: the if check inside the peewee.DoesNotExist looks wrong.
you are disallowing any non-admin user from creating an account
do you want to restrict registration on the server?
mayhem[m]
only users who have a (blank) row in the user table are allowed to log in.
account creation is entirely manual by the admin.
lucifer[m]
i see. so you need to set login_id when creating the blank row.
mayhem[m]
oki.
lucifer[m]
do you have an admin panel view to create users yet or should i add it and set it up?
mayhem[m]
I have it.
what would be a good way to add this UUID for when the user is created?
since the admin view is automated, I can't control the creation of records.
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #3166 (03master…duplicate-notify): LB-1742 Notify user if they're adding a duplicate to a playlist https://github.com/metabrainz/listenbrainz-serv...
lucifer[m]
gimme a sec
pushed changes, mayhem
i set the default in the peewee model itself.
mayhem[m]
thank you!!
mayhem[m] uploaded an image: (11KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/ekTrEqmdWwrOvMWgARyfxDEa/image.png >
lolololol
reosarevok[m] joined the channel
reosarevok[m]
Is that field enabled when visiting from Germany?
monkey[m] joined the channel
monkey[m]
Faxe number = 10%
monkey[m] uploaded an image: (936KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/mPNUqiLQqpkbEGliDpLopdrk/image.png >
(and yes, this is a 1 liter can)
lucifer[m]
salaxceitor: the table needs to be in listenbrainz timescale db
salaxceitor[m]
lucifer: let me check
it's present in listenbrainz_ts -> public -> background_worker_state
lucifer or mayhem : can one of you run the sql script that came with the "pause account" PR please? Currently getting 500 error when accessing beta as the column is missing in the DB
mayhem[m]
k
monkey[m]
(sorry, having food)
mayhem[m]
done.
monkey[m]
Updating LB prod
BrainzGit
[listenbrainz-server] 14dependabot[bot] opened pull request #3182 (03master…dependabot/npm_and_yarn/dompurify-3.2.4): Bump dompurify from 2.5.8 to 3.2.4 https://github.com/metabrainz/listenbrainz-serv...
monkey[m]
^ Gotta review all uses of Dompurify in the PR before merging, just FYI
[musicbrainz-server] 14mwiencek merged pull request #3467 (03master…mbs-13925): MBS-13925: Instrument name erroneously displayed in link type autocomplete https://github.com/metabrainz/musicbrainz-serve...
I also started messing around with Tidal's complicated and poorly-documented v2 API since most of yambs's requests to their internal API seem to be getting blocked now.
It feels like they've done their best to make it hard to use from a statically-typed language (e.g. properties that can be either an object or an array of objects, arrays that mix objects of different types), so we'll see if I have the patience to actually rewrite my code to use it.
'''
derat: you might want to talk to outsidecontext about it since he was working on it for harmony
And aerozol says:
'''
Hello! I am feeling better now, just having a fun time trying to catch up on sleep and two weeks of neglected work. If I’m up I’ll pop into the meeting, but if I am getting some blessed sleep I will take it, and you will see me at next week’s meeting.
Same as last week, I have just been staying on top of the basics, socials and a couple of tickets.
'''
MonkeyPython
Sleep well aerozol
reosarevok[m]
MonkeyPython: you wanted to go early?
On my list for today: ansh, julian45, monkey, bitmap, lucifer, kellnerd, yvanzo, mayhem, reosarevok, zas, outsidecontext, jasje, Gautam Shorewala
MonkeyPython
Arararara~! hi!
(i've got a whole bunch so i'm gonna just paste it and run off. people pm me or whatever)
Still having very hectic weeks (and due to house BS going to be EVEN Moar this week)
not helped by there being an emergency cut of the water for 2 hours this morning due to some pump-error (was thankfully fixed atleast)
Still I am starting to see the end of the Work on the Table of Contence for our BookBrainz Style document (I hope, I keep finding new things we should probably add, lol)
updated Vivaldi (shock gasp!) so now translations don't work anymore, lol (translating work on Picard will have to eh, wait.)
In that vein: anyone familiar with vivaldi/chrome extensions who want to earn 100 bucks get in contact with me abt writing a gorram extension. (I've had it, lol)
There's more of this stuff, but it's offtopic so not important
Come March and I'll have time to work on instruments again (hopefully, lmao)
that's it, the next fish can be kellnerd
kellnerd[m] joined the channel
kellnerd[m]
Hi 👋
I've also been in the "annoyed by Tidal's API" team this week
I was testing and reviewing outsidecontext's provider implementation for Harmony, trying to make the best out of what we have...
