#metabrainz

/

      • lucifer[m]
        mayhem: hi! let me know when you are around for a quick discussion on listen deletion stuff.
      • Kladky joined the channel
      • yvanzo[m]
        Hi Jade, your idea #1 is very ambitious/thrilling and would fill a gap that was left after moving to Matrix.
      • (Even though our IRC web logger is still running, it isn’t maintained and it doesn't handle Matrix-only stuff such as reactions and threads.)
      • outsidecontext[m
        That's a weird ListenBrainz issue: https://community.metabrainz.org/t/imported-old...
      • yvanzo[m]
        Tickets will go offline in 5 minutes from now for maintenance.
      • monkey[m]
        lucifer: something went wrong with the user stats.
      • The stats I am seeing for myself (other users reported issue too, see forum link above) look like old stats, and switching between time periods doesn’t change anything.
      • Also hello :)
      • outsidecontext[m
        Interesting. On my account it looks sensible.
      • mayhem[m]
        moooin!
      • lucifer: ready for a chat.
      • lucifer[m]
        mayhem: yes, debugging stats right now. will ping you sson.
      • monkey: does this week stats look any better now?
      • artists this week
      • monkey[m]
        lucifer: negative. Definitely stats from some time ago
      • The top three artists for every rabge look suspicious, and don't change. The rest could be correct
      • Almost looks like in interspersed some of my top artists from last year into every other range
      • yvanzo[m]
        Tickets are back online.
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #3186 (03master…inc-listens-filter): Add missing filter on incremental listens during stats https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] 14MonkeyDo merged pull request #3177 (03master…read-more): LB-1750 Added Show more button to playlist description https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-android] 14hemang-mishra opened pull request #552 (03feat-playlists…feat-playlistScreen-hemang-mishra): MOBILE-214: User Playlist screen implementation. https://github.com/metabrainz/listenbrainz-andr...
      • snobdiggy29283 joined the channel
      • [listenbrainz-server] 14amCap1712 merged pull request #3186 (03master…inc-listens-filter): Add missing filter on incremental listens during stats https://github.com/metabrainz/listenbrainz-serv...
      • lucifer[m]
        monkey: stats have been regenerated and should be fixed for all user/time ranges now.
      • mayhem: hi around now?
      • mayhem[m]
        yep
      • monkey[m]
        Brilliant, thank you lucifer ! At a quick glance it looks correct now for me
      • Appreciate you rushing to resolve the issue
      • lucifer[m] uploaded an image: (288KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/jTxtFIDbhrWuEaxUSiTtbHgo/image.png >
      • lucifer[m]
        (after fixing the bugs i introduced)
      • monkey[m]
        Haha
      • mayhem[m]
        lucifer: https://stackoverflow.com/questions/79451293/pr... -- so far all I am getting are downvotes, lol.
      • Jigen
        lmao
      • lucifer[m]
        mayhem: for listen deletion, we add listened_at, recording_msid, user_id to the `listen_delete_metadata` without checking if the listen actually exists. sometimes there can also be duplicate rquests for the same listen's deletion. at the moment, we try to delete all requests and record the max_id of the listen that was attempted to delete. then after deletion is complete we removed the requests until that max_id row. and if there
      • were any duplicate or non-existent listen deletion requests they would go away too.
      • however, with the latest PR i made yesterday this changes. we now do not clear the table immediately but set a deleted column to true and for invalid/non-existent requests deleted remains false, just like for a new request. after a full dump has been produced, we removed rows from the table where deleted is true. but since we can't differentiate between invalid or new requests, the table clutters with the invalid requests. i am
      • thinking about how to fix it and was wondering if i should add a new table to store just the actually deleted listens and restore the original cleanup method for existing table. but while writing this i realised i can change deleted from boolean to an enum and add a invalid state to differentiate.
      • Jigen
        wait, wtf why is that question closed and downvoted? it seems clear enough? even to a guy liek me who don't code
      • lucifer[m]
        >Post Closed as "Not suitable for this site" - lol
      • mayhem[m]
        wow, just closed it.
      • fuck me. I better go ask someplace not run by community nazis. gees.
      • Jigen
        god it's probably becasue this is the first post by mayhem. some sites liek this are very "u must be this experienced before we take u seriously"
      • fuck
      • maybe reddit 🤔
      • lucifer[m]
        yeah maybe scikit reddit or some community channel is a better option
      • mayhem[m]
        they specifically tell people to ask on SO. sigh.
      • lucifer[m]
        lolol
      • mayhem[m]
        > but while writing this i realised i can change deleted from boolean to an enum and add a invalid state to differentiate.
      • that was the first thing that came to my mind too. probably the easiest.
      • Jigen
        i'venever seen an useful stackoverflow post tbh, most of the time i look up some thing. and like the guy explains it, and thne there are 30 mesgs saying "lol u are stupid for asking this slightly wrong" and thne one, highly usefull post that actually help (and aswers my question as well) in small it also has like atleast 4 "well ackshually" refuting comments underneath
      • mayhem[m]
        "and the shortest code necessary to reproduce the problem." that was fully ignored. I guess I need to inline that.
      • Jigen
        i signed up with github but i can't vote or comment becasue they want me to onboard or whatever. fack
      • can't beassed right now
      • yea i cant until i.. uh get 15 upvotes. i don't care to even bother with writing a post. god useless site
      • monkey[m]: you around :)
      • monkey[m]
        Jigen (IRC): Finishing lunch, will be back shortly
      • SigHunter has quit
      • Jigen
        👍
      • SigHunter joined the channel
      • SigHunter has quit
      • SigHunter joined the channel
      • outsidecontext[m
        mayhem: weird how your question was handled. But I'd suspect the low CPU usage is still somewhat related to Python's global interpreter lock. The assumption would be that the performance relevant parts of the nmslib calls run mostly outside the GIL, but still there might be enough Python code execution in build_index when preparing the data to have this slowed down by the GIL.
      • mayhem[m]
        oh. GIL. feck, that might be it.
      • outsidecontext[m
        Would be interesting to compare this when running the code with a Python 3.13 build with GIL disabled
      • pite joined the channel
      • mayhem[m]
        indeed -- something worth trying. but... I think I may have found a workable solution.
      • be lazy.
      • SigHunter has quit
      • just build the indexes on demand, since it is very quick to build them.
      • outsidecontext[m
        be lazy is often a workable solution :D
      • mayhem[m]
        yeah, fully testing that now. :)
      • SigHunter joined the channel
      • minimal joined the channel
      • BrainzGit
        [bookbrainz-user-guide] 14MonkeyDo merged pull request #20 (03master…update-theme): Update theme https://github.com/metabrainz/bookbrainz-user-g...
      • [listenbrainz-server] 14amCap1712 opened pull request #3187 (03master…refactor-listen-deletion-again): Refactor listen deletion status column https://github.com/metabrainz/listenbrainz-serv...
      • lucifer[m]
        mayhem: can you please review ^
      • mayhem[m]
        lucifer: done
      • I got the fast fuzzy to be fast!
      • the key? don't build the recording indexes at start time, build them on the fly.
      • searching the beatles the first time might take 90ms. the second time 40ms.
      • this is the fastest and most robust approach I've seen yet.
      • lucifer[m]
        Awesome
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #3187 (03master…refactor-listen-deletion-again): Refactor listen deletion status column https://github.com/metabrainz/listenbrainz-serv...
      • JadedBlueEyes has quit
      • JadedBlueEyes joined the channel
      • Sophist-UK has quit
      • GautamShorewala[ has quit
      • jasje[m] has quit
      • [listenbrainz-server] release 03v-2025-02-19.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • zas[m] has quit
      • pite has quit
      • pite joined the channel
      • Jade[m]
        I spent a bit of time on SO back in 2018 and did some questions and answers there, but haven't really come back to it because it's not been useful to me lol
      • but even though I just logged on for the first time since like 2022 my reputation just kept going up
      • Jade[m] uploaded an image: (13KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/ellis.link/e602WU6b6lohJ5wTfnE8fJvMhD63Ez02/image.png >
      • because it's not about who engages in the site in a positive way, or gives useful answers, but who got there first
      • JadedBlueEyes has quit
      • JadedBlueEyes joined the channel
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #3188 (03master…delete-users-record): Add a table to record listen history deletion https://github.com/metabrainz/listenbrainz-serv...
      • SothoTalKer__ joined the channel
      • SothoTalKer_ has quit
      • kellnerd[m] has quit
      • Kladky has quit
      • mayhem[m]
        bitmap: LB just wobbled with a lot of "server closed the connection unexpectedly" errors from PG. I restarted the container and all seems well. could you have a look to see if anything odd is happening on the PG side of things?
      • bitmap[m]
        mayhem: sorry that was almost certainly my fault since I'm moving some pgbouncer services in preparation for the switchover tomorrow
      • I'm not entirely sure why it affected LB and not MB though .. I put everything into maintenance mode and issued a PAUSE to pgbouncer first (which waits for all transactions / sessions to complete)
      • mayhem[m]
        ah, ok. can you do me a favor and keep an eye out for more LB wobbles? If so, restart lb-web-prod on kiss, please.
      • ok, off to bed!
      • bitmap[m]
        yeah I'll watch over it, good night!
      • 2025-02-20 05133, 2025

      • hmm, I think the problem is that the LB web container didn't reload uwsgi when I put the old pgbouncer container into maintenance mode. this template block in /etc/consul-template-uwsgi.conf looks suspect since it has no command/exec setting:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
      • lucifer: is my understanding of the consul-template config correct? if so, can it be changed to reload uwsgi when config.py changes?
      • derat[m] has quit
      • snobdiggy29283 has quit
      • allen has quit
      • minimal has quit
      • ansh[m] has quit
      • lucifer[m]
      • bitmap[m]
        that seems problematic since the workers have to be restarted if the config changes, right?
      • zas: hey, can you configure gmail to allow exim relay on isaac? (logging off now but I can move them tomorrow)
      • lucifer[m]
        yes, i think so. i'll discuss with monkey on the rationale.
      • aerozol[m]
        mayhem: 🥳 v
      • Aerozol[m]1 joined the channel
      • Aerozol[m]1 uploaded an image: (17KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/zcAxxQAkKnBzmftKQlQTuboT/image.png >
      • pite has quit
      • dabeglavins3 has quit
      • dabeglavins3 joined the channel
      • BrainzGit
        [bookbrainz-site] 14shalini-bhandari opened pull request #1154 (03master…replace-twitter): fix: Replaced Twitter logo and link with Mastodon and Bluesky https://github.com/metabrainz/bookbrainz-site/p...