Tickets will go offline for security update in half an hour from now.
2025-03-19 07819, 2025
d4rk-ph0enix has quit
2025-03-19 07843, 2025
d4rk-ph0enix joined the channel
2025-03-19 07827, 2025
holycow23[m] joined the channel
2025-03-19 07827, 2025
holycow23[m]
Hey everyone, I’m planning to apply for GSoC and working on my proposal for **new statistics graphs** in ListenBrainz. I’d love any feedback or guidance to improve it. Looking forward to contributing and learning! [Here](https://community.metabrainz.org/t/gsoc-202… is my draft proposal.
2025-03-19 07832, 2025
holycow23[m]
* Hey everyone, I’m planning to apply for GSoC and working on my proposal for **new statistics graphs** in ListenBrainz. I’d love any feedback or guidance to improve it. Looking forward to contributing and learning! [Here](https://community.metabrainz.org/t/gsoc-202… is my draft proposal.
2025-03-19 07833, 2025
holycow23[m]
ansh lucifer
2025-03-19 07844, 2025
holycow23[m]
* Hey everyone, I’m planning to apply for GSoC and working on my proposal for **new statistics graphs** in **ListenBrainz**. I’d love any feedback or guidance to improve it. Looking forward to contributing and learning! [Here](https://community.metabrainz.org/t/gsoc-202… is my draft proposal.
2025-03-19 07844, 2025
holycow23[m]
ansh lucifer
2025-03-19 07853, 2025
yvanzo[m]
Welcome holycow23 and thank you for your proposal. Don’t worry about proposed mentors not being online right now, they will catch it later on.
2025-03-19 07833, 2025
holycow23[m]
* Hey everyone! I’m planning to apply for GSoC and working on my proposal for **new statistical graphs** in **ListenBrainz**. I’ve previously contributed by developing a couple of new features and would love any feedback or guidance to refine my proposal. Looking forward to contributing and learning!
2025-03-19 07833, 2025
holycow23[m]
You can check out my draft proposal here.
2025-03-19 07833, 2025
holycow23[m]
ansh lucifer
2025-03-19 07816, 2025
holycow23[m]
* Hey everyone! I’m planning to apply for GSoC and working on my proposal for **new statistical graphs** in **ListenBrainz**. I’ve previously contributed by developing a couple of new features and would love any feedback or guidance to refine my proposal. Looking forward to contributing and learning!
* Hey everyone! I’m planning to apply for GSoC and working on my proposal for **new statistical graphs** in **ListenBrainz**. I’ve previously contributed by developing a couple of new features in ListenBrainz and would love any feedback or guidance to improve my proposal. Looking forward to contributing and learning!
holycow23[m]: sorry for sounding rude. Your edits are spamming the IRC room. And I think your message is clear.
2025-03-19 07822, 2025
ansh joined the channel
2025-03-19 07820, 2025
holycow23[m]
Sorry for causing the incovenience
2025-03-19 07851, 2025
yvanzo[m]
No worry, you couldn’t have know, that was rude indeed. Thanks for not over-editing though.
2025-03-19 07812, 2025
DjSlash
yeah, I should've worded that better
2025-03-19 07855, 2025
reosarevok[m]
I always forget edits send new messages on IRC 😅 good reminder to try to not use them often
2025-03-19 07854, 2025
yvanzo[m]
reosarevok: Should the topic be updated to clear the agenda?
2025-03-19 07802, 2025
reosarevok[m]
Yes, thanks!
2025-03-19 07811, 2025
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged and not empty as it is bridged to IRC; see https://musicbrainz.org/doc/ChatBrainz for details | Agenda: Reviews
2025-03-19 07847, 2025
yvanzo[m]
Tickets are back.
2025-03-19 07834, 2025
vardhan_ joined the channel
2025-03-19 07811, 2025
reosarevok[m]
Aww, I was liking the bike
2025-03-19 07817, 2025
reosarevok[m]
But thanks :)
2025-03-19 07857, 2025
rustynova[m]
Remade my pending PR on Melba.
2025-03-19 07857, 2025
rustynova[m]
Although is it normal that there's both a Library and binary target? I find it difficult to justify the presence of a library in there, as it's tailor made for MusicBrainz.
2025-03-19 07857, 2025
rustynova[m]
We could extract the IA archiving and internal database into it's own library, but the rest doesn't really fit in
Hi rustynova, IIRC there was one to target to be used as a daemon and another as a CLI tool.
2025-03-19 07821, 2025
yvanzo[m]
Also the longer plan is to make it work for any other project (BB…) not just MB.
2025-03-19 07828, 2025
yvanzo[m]
(But we’re not there yet.)
2025-03-19 07835, 2025
rustynova[m]
Oh. For daemons, you still need a binary to act as an actual runnable code. Or else it's just raw rust
2025-03-19 07835, 2025
rustynova[m]
As for expanding, it's useless. The code is already in the binary crate, and not calling the library part.
2025-03-19 07835, 2025
rustynova[m]
I see the intent, just that it wasn't properly executed. For now i'd suggest to act as if the crate is a library, and when we want to expend, we can extract the core part (database and IA interface) and make multiple children binaries with the custom code for that project
2025-03-19 07847, 2025
rustynova[m]
That question was mostly to see if I could update some dependencies/rust version to remove some now useless code.
2025-03-19 07848, 2025
rustynova[m]
Libraries should try to not use the latest stuff, but binaries absolutely should
2025-03-19 07857, 2025
yvanzo[m]
I’m not sure it is really need to have two separate binaries either, but at least you got the idea.
2025-03-19 07822, 2025
yvanzo[m]
Absolutely, that is very welcome!
2025-03-19 07852, 2025
rustynova[m]
We'll see about it when we need it then!
2025-03-19 07852, 2025
rustynova[m]
Also migrate to the 2024 edition. With junior code there might have some things getting broken
2025-03-19 07837, 2025
reosarevok[m]
bitmap: I just noticed that we sort RGs by secondary type id in `_find_by_artist_fast` but by secondary type name in `_find_by_artist_slow`.
2025-03-19 07835, 2025
reosarevok[m]
I assume we'd want to change both to use child_order with the schema change - although child order is 0 for all secondary types right now AFAICT
2025-03-19 07838, 2025
reosarevok[m]
Which is also the only reason the list is in alphabetical order when editing / adding RGs
2025-03-19 07851, 2025
reosarevok[m]
(since that does sort on child_order before name)
2025-03-19 07803, 2025
reosarevok[m]
Two questions: 1) I assume not, but is the different sort intended in any way? 2) Should we be setting child orders for the types, and if so should we start with alphabetical and keep the same sort we have the form, or id and keep the sort we have in _find_by_artist_fast?
<rustynova[m]> "We'll see about it when we..." <- > <@_discord_492790468321607681:chatbrainz.org> We'll see about it when we need it then!
2025-03-19 07844, 2025
julian45[m]
> Also migrate to the 2024 edition. With junior code there might have some things getting broken
2025-03-19 07844, 2025
julian45[m]
maybe shape it as a library alone but with a (hopefully MeB-project-agnostic) API?
2025-03-19 07813, 2025
julian45[m]
> <@_discord_492790468321607681:chatbrainz.org> We'll see about it when we need it then!
2025-03-19 07813, 2025
julian45[m]
> Also migrate to the 2024 edition. With junior code there might have some things getting broken
2025-03-19 07813, 2025
julian45[m]
* maybe shape it as a daemon alone but with a (hopefully MeB-project-agnostic) API?
2025-03-19 07858, 2025
d4rkie has quit
2025-03-19 07823, 2025
d4rkie joined the channel
2025-03-19 07800, 2025
fettuccinae[m]
mayhem: do you have any suggestion on how to implement creator options for notification senders? also, we barely send out mails to users in listenbrainz but we do change their timeline (for example, if someone just got a track recommended) ,so should i add sending mails when we change their timeline in my project?
2025-03-19 07801, 2025
mayhem[m]
what do you mean by "creator options for notification senders". User settings wrt to their notifications preferences?
2025-03-19 07824, 2025
mayhem[m]
and we dont send a lot of emails because the notification system is missing. :)
2025-03-19 07839, 2025
fettuccinae[m]
mayhem[m]: no, im talking about settings for notifications like marking it important
2025-03-19 07857, 2025
mayhem[m]
fettuccinae[m]: I still dont understand
2025-03-19 07858, 2025
fettuccinae[m]
mayhem[m]: lets take yim notifs for example, when we send it out, we do need to set an expiry age and also mark it as important.
lucifer: " * The seed artist Radiohead has no similar artists, nor top recordings. Too niche?"
2025-03-19 07847, 2025
mayhem[m]
this is regarding the regression yesterday. has something happened to the similar artist data?
2025-03-19 07819, 2025
mayhem[m]
I'll fix the bug for when there are no similar artists, but we need to check the similar artist data.
2025-03-19 07853, 2025
fettuccinae[m]
fettuccinae[m]: this needs to done from maintainers side ,setting the notification as important or not, setting its expiry date and all.
2025-03-19 07831, 2025
mayhem[m]
fettuccinae[m]: and I still don't understand what you're asking.
2025-03-19 07839, 2025
fettuccinae[m] uploaded an image: (36KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/tuvXqMYJLhLaPEvaRCwbvPCM/image.png >
2025-03-19 07812, 2025
lucifer[m]
mayhem: i'll take a look at similarity data and see if something is broken
2025-03-19 07847, 2025
mayhem[m]
fettuccinae[m]: ahhh, I finally understand. these options are provided to the notification system when sending a notifcaition.
2025-03-19 07852, 2025
lucifer[m]
mayhem: i think @fettuccinae:matrix.org is talking about notification priority
2025-03-19 07813, 2025
mayhem[m]
lucifer[m]: now I am extra confused, lol. :)
2025-03-19 07819, 2025
fettuccinae[m]
mayhem[m]: yess, how do u suggest i implement it
2025-03-19 07838, 2025
mayhem[m]
as parameters to the function call.
2025-03-19 07853, 2025
fettuccinae[m]
mayhem[m]: one of the option we choosein notification system is its priority
2025-03-19 07815, 2025
fettuccinae[m]
* one of the option we choose in notification system is its priority
2025-03-19 07814, 2025
lucifer[m]
@fettuccinae:matrix.org: yeah i think we'll have a common function that will receive those options in addition to the notification content and then take action appropriately.
2025-03-19 07801, 2025
lucifer[m]
and each option in particular can just be hard coded at the place you are calling the notification helper function.
2025-03-19 07805, 2025
reosarevok[m]
bitmap: also, we don't do `NULLS FIRST` for `_slow`, not sure if there's a reason for that?
2025-03-19 07847, 2025
reosarevok[m]
bitmap: updated https://github.com/metabrainz/musicbrainz-server/… a bit for now, anyway, please see if the changes so far + the listed tasks seem sensible and whether I seem to be forgetting something :)
2025-03-19 07825, 2025
mayhem[m]
<lucifer[m]> "and each option in particular..." <- thanks for handling that. :) #soconfused
2025-03-19 07850, 2025
bitmap[m]
<reosarevok[m]> "Two questions: 1) I assume not..." <- setting child orders makes sense to me, there's a ticket for that - MBS-13790. I don't think I bothered changing the slow function because it's only used outside of production, but we could make them consistent
