aerozol: seems like the usual matrix encryption bugginess. i've tried messaging you back
aerozol[m]
All good, I'll message you on the MB channel so as not to gum up the dev chat, it's nothing too important!
rinsuki[m] joined the channel
rinsuki[m]
are there any tickets to migrate MusicBrainz's frontend source code to TypeScript from Flow typed? I can't find any, but since book and listenbrainz have already migrated (or ing), i think it would make sense to migrate musicbrainz as well (also I'd be interested).
BrainzGit
[listenbrainz-server] 14granth23 closed pull request #3257 (03master…LB-1777--Artist-origin-map-"play-something-from-this-country"): LB-1777: Artist origin map "play something from this country" https://github.com/metabrainz/listenbrainz-serv...
Hey monkey, I'm currently working on [LB-1784](https://tickets.metabrainz.org/projects/LB/issues/LB-1784?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC), which depends on some changes from [LB-1778](https://tickets.metabrainz.org/projects/LB/issues/LB-1778?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC) by lucifer which is still open as well as some changes that have already
been merged into main from the ticket [LB-1783](https://tickets.metabrainz.org/projects/LB/issues/LB-1778?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC). However, I noticed that LB-1778 doesn’t include the changes from LB-1783.
Could you please advise the best way to proceed here? Just want to make sure I’m aligning with the expected workflow.
BrainzBot
LB-1784: Hyperlink Artist name and Improve tooltip on the Artist Activity graph
LB-1778: Artist activity graph splits artists under some circumstances
<monkey[m]> "holycow23: Actually, some..." <- I missed out on these bugs, have fixed the same [here](https://github.com/metabrainz/listenbrainz-server/pull/3258)
reosarevok[m] joined the channel
reosarevok[m]
<rinsuki[m]> "are there any tickets to migrate..." <- No, not really. As far as I can tell we are fairly happy with Flow and have no current plans to change it
<derat[m]> "reosarevok: i noticed that the..." <- It might make sense to have these be consistent, but I maybe feel we should use Title on the site instead to be honest... might break more stuff though that way 🫣
Zhele_ joined the channel
Zhele has quit
mayhem[m] has quit
ijc_ has quit
ijc joined the channel
aerozol[m]
I had exactly the same thought re. maybe changing things to “Title”, but kept my mouth shut because it sounds hard haha
holycow23: I was just checking it and the screenshot looked good, any reason for closing PR LB-1777 ?
re "Title" vs. "Name", i think i lean slightly toward "Title" too (there's also /doc/Style/Titles, of course). seems like it's probably fine to leave it alone for now since i haven't heard of anyone being confused by it
monkey[m]
<holycow23[m]> "Hey monkey, I'm currently..." <- Hi holycow23, I'm a bit lost, you mention ticket numbers, but are you talking about code that is in specific PRs?
I see that LB#3248 is almost finished and should be ready to merge into master soon.
The easiest is probably to wait until it is merge, but if you are in a rush I can always merge master into PR 3248, and you can base your new branch on that (the `artist-activity-fix` branch)?
<monkey[m]> "Hi holycow23, I'm a bit lost..." <- I have been working with the `artist-activity-fix` as my base branch but another PR which has been merged has changes on to the same file I am working on but `artist-activity-fix` isn't synced
* I have been working with the artist-activity-fix as my base branch but another PR which has been merged has changes on to the same file I am working on but artist-activity-fix isn't synced
monkey[m]
I see. I just reviewed and approved the PR in question, let me merge it and you can rebase on top of master after that.
<aerozol[m]> "holycow23: I was just checking..." <- I fell into many bugs so have opened a new PR for the same ticket
s/fell into many bugs so//
monkey[m]
holycow23: #3258 is up on test.LB , I wanted to try it in the wild.
Pretty cool feature!
Techman has quit
Techman joined the channel
Techman has quit
BrainzGit
[listenbrainz-server] 14granth23 opened pull request #3259 (03master…LB-1784): LB-1784: Hyperlink Artist name and Improve tooltip on the Artist Activity graph https://github.com/metabrainz/listenbrainz-serv...
