#metabrainz

bitmap: someone is saying they hit MBS-13949 again, fwiw - maybe you can take a look when around?

MBS-13949: Can't email user https://tickets.metabrainz.org/browse/MBS-13949

yvanzo: available most of the working day today to look at whatever solr/sir stuff you can use some eyes on (or for testing)

Hi reosarevok: Can you please update https://tickets.metabrainz.org/browse/SEARCH-740 ?

SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2)

IIRC https://github.com/metabrainz/mbdata/pull/71 is already at the last version

But I can re-run stuff just in case if you want

Once that is merged and tagged we can use the tag in search projects

I'm fairly sure it's fine, but ideally you can give it a quick review, yvanzo :)

That’s a no I guess.

Ok, I'm confused :)

What is it that you want me to update exactly? :)

That ticket says Update mbdata to schema 30, I was pointing that it's already ready for review

But maybe I misunderstood something

reosarevok: Please update the status of the ticket, add links to the pull requests in comments, and all.

Aaaaah ok

The ticket itself. Sure can do :)

reosarevok: That can be automated if you are following https://github.com/metabrainz/guidelines/blob/m...

Yes, I did forget we had a ticket number for mbdata tbh

Anyway, on it :)

The mbdata repository i snew to our organization, it is missing webhooks for automation to work.

Ah ok. Well, anyway, I edited the ticket, edited the PR to add the ticket number and to specify I have tested sir with it too

Ok, I will set up webhooks.

OK, I’ve set up mbdata webhooks for BrainzGit & Jira automation, following the docs.

bitmap: I just deleted the duplicate cron job running at 20:13 in search-indexes-dump container, that was only for early Solr backup tests.

Thanks for having restored those dumps a week ago by the way.

bitmap: Do the `admin/sql` scripts `DisableLastUpdatedTriggers.sql` and `EnableLastUpdatedTriggers.sql` really need the execution permissions?

zas: hi! can you please take a look at https://github.com/metabrainz/docker-server-con... and redeploy ftp sshd?

thanks!

lucifer: done

yvanzo: ok, that took longer than planned but quickish lunch now and back after that

reosarevok: no problem, I'm reviewing your mbdata PR and then go for lunch as well.

m.amanullah7: responding to your LB question here regarding LB-1793:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

LB-1793: BrainzPlayer: Save Volume % between sessions https://tickets.metabrainz.org/browse/LB-1793

The volume prop is passed down from the parent BrainzPlayer component here: https://github.com/metabrainz/listenbrainz-serv...

It is stored in the global brainzPlayerContext. Changes to this context should automatically trickle down to the children components https://github.com/metabrainz/listenbrainz-serv...

You can dispatch an action VOLUME_CHANGE to change the context value: https://github.com/metabrainz/listenbrainz-serv...

monkey[m]: monkey: i thnk u have tagged me instead of mshahnawaz1

Not sure why that isn't working for you, but that's the trail to follow :)

Oh shit, sorry! My bad

All the above for mshahnawaz1 ^ 😅

Thanks @monkey for the detailed explanation, I have made pull request. [Here](https://github.com/metabrainz/listenbrainz-server/pull/3271).

Can you please review the pull request.

🙂🙂

Will do. Is everything worlking as you expect it to?

Yes it is working now, added the working video in PR.

OK

lucifer: I resized the sentry instance. 2GB ram free -- which is amazing for a system that is nearly idly.

s/idly./idle/

yvanzo: updated the PR, when back see if it looks good now :)

reosarevok: Thanks, it looks good.

[mbdata] 14reosarevok merged pull request #71 (03main…schema-change-2025-q2): SEARCH-740 (I): Update mbdata for v30 of the musicbrainz-server schema https://github.com/metabrainz/mbdata/pull/71

SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740

yvanzo: neat - should we make a release?

Or just a tag for now?

mayhem: sounds good, fwiw MB hasn;t migrated yet so you might be able to scale it down further in future.

odd, I only saw the LB project defined.

yes because you are only in LB team.

ahhhh, ok.

you need to join the other teams to view other projects' issues.

bitmap, reosarevok: Pretty sure that those file permissions weren’t intended, so I pushed a commit to the schema-change-2025-q2 branch.

[mbdata] 14yvanzo opened pull request #72 (03main…upd-repo): Fix file permissions and documentation https://github.com/metabrainz/mbdata/pull/72

reosarevok: Would be great to merge that one before releasing ^

welcome Salomanuel !

yvanzo: lgtm. lucifer: can you take a quick look too? ^

lgtm

Thanks

Wonder if we should close the 4 open issues - they are all related to mbslave

yvanzo: while you are at it, can you please make one more cahnge.

reosarevok: Please formally approve it.

lucifer: Sure

Yes, I will :) Was just checking if there was anything else

change push to run only on master branch

lucifer: Please just push a commit to the branch.

sure

yvanzo: pushed. also updated actions/checkout and actions/setup-python to their latest versions.

reosarevok: closing those issues makes sense to me. also probably disable the issues on the repo and create a new jira component if one doesn't exit?

s/exit/exist/

<mayhem[m]> "welcome Salomanuel !" <- Hey everyone, glad to join the party!

(also looking for some intro-tickets 👀)

[mbdata] 14yvanzo merged pull request #72 (03main…upd-repo): Fix file permissions and documentation https://github.com/metabrainz/mbdata/pull/72

lucifer, any clue why Jenkins job is showing up two times for https://github.com/metabrainz/sir/pull/142 ? (Just reviewed your latest commits too.)

reosarevok: mbdata seems to be ready for release (GitHub + PyPI) if you can handle that.

I can check

For the tag, should we tag -u and if so should we use the same command as for MBS tags?

(I will admit only today I read what -u even does - I expect we want to sign with the same key, but just making sure)

It can’t hurt using the same.

Ok :)

Tagged then - https://github.com/metabrainz/mbdata/releases/t...

yvanzo: no idea unfortunately but i have a pending branch to migrate the CI from jenkins to github actions so this should be solved soon either way.

yvanzo: drafted https://github.com/metabrainz/mbdata/releases/t... - can you check if it makes sense to you?

reosarevok: yes, added credits to lucifer.

[mbdata] release 03v30.0.0 has been published by 14reosarevok: https://github.com/metabrainz/mbdata/releases/t...

Heh

So upload_to_pypi does python setup.py sdist but we removed that file 4 years ago in https://github.com/metabrainz/mbdata/commit/f75...

Remember this repository has been merged/split with mbslave.

i can update the repo to add a github action to publish the package to pypi.

we should do the same for mb-rngpy btw.

lucifer: how did you do it last time? (and we should update the script and/or docs)

reosarevok: i just used the git tag for sir. the pypi releases have always been done by luks since only he had accessed to the acoustid pypi org.

That works I guess, as long as we don't push stuff by accident like with the weird update.sh that does all in one go for mb-rngpy

the action would only run when a github release is published.

Seems good. How do I do for the one I just published? :D

Unless we do a 30.0.1 removing the script for pypi and changing the docs anyway

i'll need to check the repo, meanwhile you can use the git tag where needed.

Sure, I was doing that so far :)

But if we can officially release that would be neat

Dunno if it should happen today or once the schema is out?

That can be done later on to be honest, we don't need pypi ourselves.

Ok, works for me too - it kinda feels premature to do so before we have the schema change anyway?

No.

Anyway I'll take care of pypi separately then

lucifer: if you do update the repo maybe drop the `upload_to_pypi.sh` file and references to it too (and if you want release a 30.0.1 but I dunno how much that matters)

(since it changes nothing of the actual models)

lucifer: Can you please look into the SIR comments?

reosarveok: sure

Yvanzo: on it

yvanzo: `mb-rngpy` should be ready too except for the pypi upload as well, but if you want to take a quick look? I accidentally merged that by not noticing a while ago that the same script that updates things also commits merges and pushes

There is a documentation for this repository.

You can just comment out the unneeded commands and run the script again.

summit lodgings secured. waiting for proof of that to pass on for visa purposes.

yvanzo: my point was more that I already did that - just I stopped the script before it pushed to pypi

why?