#metabrainz

/

      • spynxic has quit
      • 2025-05-12 13237, 2025

      • spynxic joined the channel
      • 2025-05-12 13219, 2025

      • vardhan joined the channel
      • 2025-05-12 13254, 2025

      • spynxic has quit
      • 2025-05-12 13228, 2025

      • vardhan has quit
      • 2025-05-12 13255, 2025

      • vardhan joined the channel
      • 2025-05-12 13257, 2025

      • spynxic joined the channel
      • 2025-05-12 13236, 2025

      • reosarevok[m] joined the channel
      • 2025-05-12 13237, 2025

      • reosarevok[m]
        bitmap: someone is saying they hit MBS-13949 again, fwiw - maybe you can take a look when around?
      • 2025-05-12 13238, 2025

      • BrainzBot
      • 2025-05-12 13211, 2025

      • reosarevok[m]
        yvanzo: available most of the working day today to look at whatever solr/sir stuff you can use some eyes on (or for testing)
      • 2025-05-12 13232, 2025

      • yvanzo[m] joined the channel
      • 2025-05-12 13232, 2025

      • yvanzo[m]
        Hi reosarevok: Can you please update https://tickets.metabrainz.org/browse/SEARCH-740 ?
      • 2025-05-12 13233, 2025

      • BrainzBot
        SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2)
      • 2025-05-12 13224, 2025

      • reosarevok[m]
        IIRC https://github.com/metabrainz/mbdata/pull/71 is already at the last version
      • 2025-05-12 13255, 2025

      • reosarevok[m]
        But I can re-run stuff just in case if you want
      • 2025-05-12 13228, 2025

      • reosarevok[m]
        Once that is merged and tagged we can use the tag in search projects
      • 2025-05-12 13218, 2025

      • reosarevok[m]
        I'm fairly sure it's fine, but ideally you can give it a quick review, yvanzo :)
      • 2025-05-12 13215, 2025

      • yvanzo[m]
        That’s a no I guess.
      • 2025-05-12 13250, 2025

      • reosarevok[m]
        Ok, I'm confused :)
      • 2025-05-12 13200, 2025

      • reosarevok[m]
        What is it that you want me to update exactly? :)
      • 2025-05-12 13222, 2025

      • reosarevok[m]
        That ticket says Update mbdata to schema 30, I was pointing that it's already ready for review
      • 2025-05-12 13234, 2025

      • reosarevok[m]
        But maybe I misunderstood something
      • 2025-05-12 13227, 2025

      • yvanzo[m]
        reosarevok: Please update the status of the ticket, add links to the pull requests in comments, and all.
      • 2025-05-12 13233, 2025

      • reosarevok[m]
        Aaaaah ok
      • 2025-05-12 13241, 2025

      • reosarevok[m]
        The ticket itself. Sure can do :)
      • 2025-05-12 13222, 2025

      • yvanzo[m]
        reosarevok: That can be automated if you are following https://github.com/metabrainz/guidelines/blob/mas…
      • 2025-05-12 13248, 2025

      • reosarevok[m]
        Yes, I did forget we had a ticket number for mbdata tbh
      • 2025-05-12 13209, 2025

      • reosarevok[m]
        Anyway, on it :)
      • 2025-05-12 13259, 2025

      • yvanzo[m]
        The mbdata repository i snew to our organization, it is missing webhooks for automation to work.
      • 2025-05-12 13258, 2025

      • reosarevok[m]
        Ah ok. Well, anyway, I edited the ticket, edited the PR to add the ticket number and to specify I have tested sir with it too
      • 2025-05-12 13216, 2025

      • yvanzo[m]
        Ok, I will set up webhooks.
      • 2025-05-12 13256, 2025

      • yvanzo[m]
        OK, I’ve set up mbdata webhooks for BrainzGit & Jira automation, following the docs.
      • 2025-05-12 13209, 2025

      • yvanzo[m]
        bitmap: I just deleted the duplicate cron job running at 20:13 in search-indexes-dump container, that was only for early Solr backup tests.
      • 2025-05-12 13206, 2025

      • yvanzo[m]
        Thanks for having restored those dumps a week ago by the way.
      • 2025-05-12 13238, 2025

      • spynxic has quit
      • 2025-05-12 13258, 2025

      • Kladky has quit
      • 2025-05-12 13217, 2025

      • spynxic joined the channel
      • 2025-05-12 13256, 2025

      • Kladky joined the channel
      • 2025-05-12 13201, 2025

      • spynxic has quit
      • 2025-05-12 13207, 2025

      • yvanzo[m]
        bitmap: Do the `admin/sql` scripts `DisableLastUpdatedTriggers.sql` and `EnableLastUpdatedTriggers.sql` really need the execution permissions?
      • 2025-05-12 13241, 2025

      • spynxic joined the channel
      • 2025-05-12 13255, 2025

      • Kladky has quit
      • 2025-05-12 13242, 2025

      • Kladky joined the channel
      • 2025-05-12 13229, 2025

      • lucifer[m]
        zas: hi! can you please take a look at https://github.com/metabrainz/docker-server-confi… and redeploy ftp sshd?
      • 2025-05-12 13210, 2025

      • lucifer[m]
        thanks!
      • 2025-05-12 13213, 2025

      • zas[m] joined the channel
      • 2025-05-12 13213, 2025

      • zas[m]
        lucifer: done
      • 2025-05-12 13250, 2025

      • reosarevok[m]
        yvanzo: ok, that took longer than planned but quickish lunch now and back after that
      • 2025-05-12 13222, 2025

      • yvanzo[m]
        reosarevok: no problem, I'm reviewing your mbdata PR and then go for lunch as well.
      • 2025-05-12 13219, 2025

      • monkey[m] joined the channel
      • 2025-05-12 13220, 2025

      • monkey[m]
        m.amanullah7: responding to your LB question here regarding LB-1793:... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/HyZzTiQJgXSLqyXTwTNAXCJv>)
      • 2025-05-12 13221, 2025

      • BrainzBot
        LB-1793: BrainzPlayer: Save Volume % between sessions https://tickets.metabrainz.org/browse/LB-1793
      • 2025-05-12 13208, 2025

      • monkey[m]
        The volume prop is passed down from the parent BrainzPlayer component here: https://github.com/metabrainz/listenbrainz-server…
      • 2025-05-12 13258, 2025

      • monkey[m]
        It is stored in the global brainzPlayerContext. Changes to this context should automatically trickle down to the children components https://github.com/metabrainz/listenbrainz-server…
      • 2025-05-12 13207, 2025

      • monkey[m]
        You can dispatch an action VOLUME_CHANGE to change the context value: https://github.com/metabrainz/listenbrainz-server…
      • 2025-05-12 13249, 2025

      • mamanullah7[m] joined the channel
      • 2025-05-12 13250, 2025

      • mamanullah7[m]
        monkey[m]: monkey: i thnk u have tagged me instead of mshahnawaz1
      • 2025-05-12 13251, 2025

      • monkey[m]
        Not sure why that isn't working for you, but that's the trail to follow :)
      • 2025-05-12 13205, 2025

      • monkey[m]
        Oh shit, sorry! My bad
      • 2025-05-12 13224, 2025

      • monkey[m]
        All the above for mshahnawaz1 ^ 😅
      • 2025-05-12 13230, 2025

      • mshahnawaz1[m] joined the channel
      • 2025-05-12 13231, 2025

      • mshahnawaz1[m]
        Thanks @monkey for the detailed explanation, I have made pull request. [Here](https://github.com/metabrainz/listenbrainz-….
      • 2025-05-12 13231, 2025

      • mshahnawaz1[m]
        Can you please review the pull request.
      • 2025-05-12 13231, 2025

      • mshahnawaz1[m]
        🙂🙂
      • 2025-05-12 13250, 2025

      • monkey[m]
        Will do. Is everything worlking as you expect it to?
      • 2025-05-12 13248, 2025

      • mshahnawaz1[m]
        Yes it is working now, added the working video in PR.
      • 2025-05-12 13212, 2025

      • monkey[m]
        OK
      • 2025-05-12 13241, 2025

      • mayhem[m]
        lucifer: I resized the sentry instance. 2GB ram free -- which is amazing for a system that is nearly idly.
      • 2025-05-12 13247, 2025

      • mayhem[m]
        s/idly./idle/
      • 2025-05-12 13231, 2025

      • reosarevok[m]
        yvanzo: updated the PR, when back see if it looks good now :)
      • 2025-05-12 13256, 2025

      • yvanzo[m]
        reosarevok: Thanks, it looks good.
      • 2025-05-12 13211, 2025

      • _BrainzGit
        [mbdata] 14reosarevok merged pull request #71 (03main…schema-change-2025-q2): SEARCH-740 (I): Update mbdata for v30 of the musicbrainz-server schema https://github.com/metabrainz/mbdata/pull/71
      • 2025-05-12 13212, 2025

      • BrainzBot
        SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740
      • 2025-05-12 13200, 2025

      • reosarevok[m]
        yvanzo: neat - should we make a release?
      • 2025-05-12 13212, 2025

      • reosarevok[m]
        Or just a tag for now?
      • 2025-05-12 13209, 2025

      • lucifer[m]
        mayhem: sounds good, fwiw MB hasn;t migrated yet so you might be able to scale it down further in future.
      • 2025-05-12 13231, 2025

      • mayhem[m]
        odd, I only saw the LB project defined.
      • 2025-05-12 13201, 2025

      • lucifer[m]
        yes because you are only in LB team.
      • 2025-05-12 13225, 2025

      • mayhem[m]
        ahhhh, ok.
      • 2025-05-12 13226, 2025

      • lucifer[m]
      • 2025-05-12 13205, 2025

      • lucifer[m]
        you need to join the other teams to view other projects' issues.
      • 2025-05-12 13200, 2025

      • Maxr1998_ joined the channel
      • 2025-05-12 13214, 2025

      • Maxr1998 has quit
      • 2025-05-12 13247, 2025

      • yvanzo[m]
        bitmap, reosarevok: Pretty sure that those file permissions weren’t intended, so I pushed a commit to the schema-change-2025-q2 branch.
      • 2025-05-12 13232, 2025

      • _BrainzGit
        [mbdata] 14yvanzo opened pull request #72 (03main…upd-repo): Fix file permissions and documentation https://github.com/metabrainz/mbdata/pull/72
      • 2025-05-12 13224, 2025

      • yvanzo[m]
        reosarevok: Would be great to merge that one before releasing ^
      • 2025-05-12 13234, 2025

      • mayhem[m]
        welcome Salomanuel !
      • 2025-05-12 13201, 2025

      • reosarevok[m]
        yvanzo: lgtm. lucifer: can you take a quick look too? ^
      • 2025-05-12 13244, 2025

      • lucifer[m]
        lgtm
      • 2025-05-12 13253, 2025

      • reosarevok[m]
        Thanks
      • 2025-05-12 13217, 2025

      • reosarevok[m]
        Wonder if we should close the 4 open issues - they are all related to mbslave
      • 2025-05-12 13220, 2025

      • lucifer[m]
        yvanzo: while you are at it, can you please make one more cahnge.
      • 2025-05-12 13222, 2025

      • yvanzo[m]
        reosarevok: Please formally approve it.
      • 2025-05-12 13231, 2025

      • yvanzo[m]
        lucifer: Sure
      • 2025-05-12 13234, 2025

      • lucifer[m]
      • 2025-05-12 13236, 2025

      • reosarevok[m]
        Yes, I will :) Was just checking if there was anything else
      • 2025-05-12 13240, 2025

      • lucifer[m]
        change push to run only on master branch
      • 2025-05-12 13209, 2025

      • yvanzo[m]
        lucifer: Please just push a commit to the branch.
      • 2025-05-12 13216, 2025

      • lucifer[m]
        sure
      • 2025-05-12 13253, 2025

      • lucifer[m]
        yvanzo: pushed. also updated actions/checkout and actions/setup-python to their latest versions.
      • 2025-05-12 13243, 2025

      • lucifer[m]
        reosarevok: closing those issues makes sense to me. also probably disable the issues on the repo and create a new jira component if one doesn't exit?
      • 2025-05-12 13249, 2025

      • lucifer[m]
        s/exit/exist/
      • 2025-05-12 13230, 2025

      • Salomanuel[m] joined the channel
      • 2025-05-12 13231, 2025

      • Salomanuel[m]
        <mayhem[m]> "welcome Salomanuel !" <- Hey everyone, glad to join the party!
      • 2025-05-12 13231, 2025

      • Salomanuel[m]
        (also looking for some intro-tickets 👀)
      • 2025-05-12 13205, 2025

      • _BrainzGit
        [mbdata] 14yvanzo merged pull request #72 (03main…upd-repo): Fix file permissions and documentation https://github.com/metabrainz/mbdata/pull/72
      • 2025-05-12 13238, 2025

      • yvanzo[m]
        lucifer, any clue why Jenkins job is showing up two times for https://github.com/metabrainz/sir/pull/142 ? (Just reviewed your latest commits too.)
      • 2025-05-12 13233, 2025

      • yvanzo[m]
        reosarevok: mbdata seems to be ready for release (GitHub + PyPI) if you can handle that.
      • 2025-05-12 13247, 2025

      • reosarevok[m]
        I can check
      • 2025-05-12 13212, 2025

      • reosarevok[m]
        For the tag, should we tag -u and if so should we use the same command as for MBS tags?
      • 2025-05-12 13252, 2025

      • reosarevok[m]
        (I will admit only today I read what -u even does - I expect we want to sign with the same key, but just making sure)
      • 2025-05-12 13203, 2025

      • yvanzo[m]
        It can’t hurt using the same.
      • 2025-05-12 13243, 2025

      • reosarevok[m]
        Ok :)
      • 2025-05-12 13201, 2025

      • reosarevok[m]
      • 2025-05-12 13253, 2025

      • lucifer[m]
        yvanzo: no idea unfortunately but i have a pending branch to migrate the CI from jenkins to github actions so this should be solved soon either way.
      • 2025-05-12 13225, 2025

      • reosarevok[m]
        yvanzo: drafted https://github.com/metabrainz/mbdata/releases/tag… - can you check if it makes sense to you?
      • 2025-05-12 13251, 2025

      • yvanzo[m]
        reosarevok: yes, added credits to lucifer.
      • 2025-05-12 13252, 2025

      • _BrainzGit
        [mbdata] release 03v30.0.0 has been published by 14reosarevok: https://github.com/metabrainz/mbdata/releases/tag…
      • 2025-05-12 13240, 2025

      • reosarevok[m]
        Heh
      • 2025-05-12 13227, 2025

      • reosarevok[m]
        So upload_to_pypi does python setup.py sdist but we removed that file 4 years ago in https://github.com/metabrainz/mbdata/commit/f759f…
      • 2025-05-12 13243, 2025

      • yvanzo[m]
        Remember this repository has been merged/split with mbslave.
      • 2025-05-12 13213, 2025

      • lucifer[m]
        i can update the repo to add a github action to publish the package to pypi.
      • 2025-05-12 13219, 2025

      • lucifer[m]
        we should do the same for mb-rngpy btw.
      • 2025-05-12 13219, 2025

      • reosarevok[m]
        lucifer: how did you do it last time? (and we should update the script and/or docs)
      • 2025-05-12 13253, 2025

      • lucifer[m]
        reosarevok: i just used the git tag for sir. the pypi releases have always been done by luks since only he had accessed to the acoustid pypi org.
      • 2025-05-12 13259, 2025

      • reosarevok[m]
        That works I guess, as long as we don't push stuff by accident like with the weird update.sh that does all in one go for mb-rngpy
      • 2025-05-12 13219, 2025

      • lucifer[m]
        the action would only run when a github release is published.
      • 2025-05-12 13243, 2025

      • reosarevok[m]
        Seems good. How do I do for the one I just published? :D
      • 2025-05-12 13207, 2025

      • reosarevok[m]
        Unless we do a 30.0.1 removing the script for pypi and changing the docs anyway
      • 2025-05-12 13210, 2025

      • lucifer[m]
        i'll need to check the repo, meanwhile you can use the git tag where needed.
      • 2025-05-12 13238, 2025

      • lucifer[m]
      • 2025-05-12 13251, 2025

      • reosarevok[m]
        Sure, I was doing that so far :)
      • 2025-05-12 13201, 2025

      • reosarevok[m]
        But if we can officially release that would be neat
      • 2025-05-12 13212, 2025

      • reosarevok[m]
        Dunno if it should happen today or once the schema is out?
      • 2025-05-12 13234, 2025

      • yvanzo[m]
        That can be done later on to be honest, we don't need pypi ourselves.
      • 2025-05-12 13200, 2025

      • reosarevok[m]
        Ok, works for me too - it kinda feels premature to do so before we have the schema change anyway?
      • 2025-05-12 13217, 2025

      • yvanzo[m]
        No.
      • 2025-05-12 13249, 2025

      • lucifer[m]
        Anyway I'll take care of pypi separately then
      • 2025-05-12 13200, 2025

      • reosarevok[m]
        lucifer: if you do update the repo maybe drop the `upload_to_pypi.sh` file and references to it too (and if you want release a 30.0.1 but I dunno how much that matters)
      • 2025-05-12 13213, 2025

      • reosarevok[m]
        (since it changes nothing of the actual models)
      • 2025-05-12 13229, 2025

      • yvanzo[m]
        lucifer: Can you please look into the SIR comments?
      • 2025-05-12 13250, 2025

      • lucifer[m]
        reosarveok: sure
      • 2025-05-12 13254, 2025

      • lucifer[m]
        Yvanzo: on it
      • 2025-05-12 13252, 2025

      • reosarevok[m]
        yvanzo: `mb-rngpy` should be ready too except for the pypi upload as well, but if you want to take a quick look? I accidentally merged that by not noticing a while ago that the same script that updates things also commits merges and pushes
      • 2025-05-12 13210, 2025

      • yvanzo[m]
        There is a documentation for this repository.
      • 2025-05-12 13212, 2025

      • yvanzo[m]
        You can just comment out the unneeded commands and run the script again.
      • 2025-05-12 13254, 2025

      • mayhem[m]
        summit lodgings secured. waiting for proof of that to pass on for visa purposes.
      • 2025-05-12 13218, 2025

      • reosarevok[m]
        yvanzo: my point was more that I already did that - just I stopped the script before it pushed to pypi
      • 2025-05-12 13229, 2025

      • yvanzo[m]
        why?