yvanzo: what's the use of the default command "creat[ing] empty SolrCloud 9 collections" if `load-backup-archives` says "It doesn't matter whether or not Solr has collections beforehand."?
once it has started, you can choose to either load backups or use SIR to populate collections.
reosarevok[m]
Ok :)
I guess delete-search-indexes is being removed because it's replaced by delete-indexed-documents in mb-solr?
Seems sensible, but should the commit message explain it?
yvanzo[m]
Sure
reosarevok[m]
In the v4.0.0 draft where you say "Hopefully, backup archives are / will be available too" do you mean "Thankfully" or do you actually mean "it needs full reindex, hopefully we'll have backups"? :)
(it sounds like the second but I'm thinking we might mean the first?)
"Helper scripts have been moved from musicbrainz-docker, adapted to work with Solr 9 and improved, to fetch, load and clean up Solr backup archives."
Would that read more clearly as:
"Helper scripts to fetch, load and clean up Solr backup archives have been moved from musicbrainz-docker, adapted to work with Solr 9 and improved." ?
And I guess the idea is to then have a 4.0.1 or 4.1.0 that includes the two open PRS? :)
yvanzo[m]
There is no "/ will be" in the release notes draft. "Thankfully" would be more appropriate.
reosarevok[m]
Yeah, sorry, I wanted to say we could say "will be" if they aren't out by the time we release the version :)
But I guess we've been making them anyway?
yvanzo[m]
Solr backups are out for a few weeks already.
(Solr 9 backups)
reosarevok[m]
Ok, I knew you had worked on them but I didn't remember if we were making them available yet. Thanks!
yvanzo[m]
That was in my weekly review. :)
(2 weeks ago)
reosarevok[m]
Sorry!
Anyway, both PR and draft look good other than the comments I made above :) (well they look good anyway, but)
Why is the PR a draft? I understand it's ready to test?
yvanzo[m]
reosarevok: I made changes to the release notes about helper commands/scripts, partly using your rephrasing.
Yes, the PR is a draft because it refers to a beta tag.
reosarevok[m]
Thanks! An helper -> a helper :)
(well, "A helper")
yvanzo: you say there's an image ready for testing - but isn't the solr image built locally anyway? :/ Or is there a way to tell it to fetch it from elsewhere?
(I've only tested with a local image so far)
yvanzo[m]
reosarevok: Which local image?
What have you tested with?
reosarevok[m]
Just me building stuff based on master + search-690 or master + SEARCH-738
I indexed sample artists locally with latest sir and the new release, at least, checked they are found. I don't have a lot of space locally to play with it much
