#metabrainz

/

      • reosarevok[m]
        Anyway, changed from test to master which seems better
      • 2025-05-16 13627, 2025

      • reosarevok[m]
      • 2025-05-16 13619, 2025

      • bitmap[m]
        btw, the artist_release_group table was empty on test.mb, I'm building it now but you might want to test the child_order triggers again once that's done
      • 2025-05-16 13638, 2025

      • bitmap[m]
        since they weren't actually doing anything before
      • 2025-05-16 13645, 2025

      • reosarevok[m]
        Oh, well good to see sort by slow worked too then :p
      • 2025-05-16 13629, 2025

      • reosarevok[m]
        yvanzo: if https://github.com/metabrainz/sir/pull/160 seems fine now we can merge and then I'll rebase your PR on top and keep fixing any issues
      • 2025-05-16 13629, 2025

      • bitmap[m] is working on updating the migration doc
      • 2025-05-16 13656, 2025

      • bitmap[m]
        mostly removing steps that were for the PG v16 upgrade
      • 2025-05-16 13620, 2025

      • reosarevok[m]
        Thanks. I thought I got rid of most but guess not :D
      • 2025-05-16 13603, 2025

      • bitmap[m]
        looks like there was also one change to a sir trigger, search_release_packaging_update
      • 2025-05-16 13620, 2025

      • bitmap[m]
        instead of dropping/recreating all of them I can just add a command to update that one
      • 2025-05-16 13653, 2025

      • bitmap[m]
        actually it's safe to just update it in production now, so I'll do that
      • 2025-05-16 13640, 2025

      • bitmap[m] added the required BuildMaterializedTables step to the blog post too
      • 2025-05-16 13621, 2025

      • _BrainzGit
        [sir] 14yvanzo opened pull request #161 (03master…2to3-fixes): SEARCH-594 (fixes): Various fixes to the Python 3 upgrade https://github.com/metabrainz/sir/pull/161
      • 2025-05-16 13622, 2025

      • BrainzBot
        SEARCH-594: Port Search Index Rebuilder (SIR) to Python 3 https://tickets.metabrainz.org/browse/SEARCH-594
      • 2025-05-16 13615, 2025

      • yvanzo[m]
        bitmap, lucifer, reosarevok: Sorry but that one must go first ^ :)
      • 2025-05-16 13647, 2025

      • yvanzo[m]
        Thanks lucifer !
      • 2025-05-16 13657, 2025

      • yvanzo[m]
        and bitmap !
      • 2025-05-16 13616, 2025

      • _BrainzGit
        [sir] 14yvanzo merged pull request #161 (03master…2to3-fixes): SEARCH-594 (fixes): Various fixes to the Python 3 upgrade https://github.com/metabrainz/sir/pull/161
      • 2025-05-16 13616, 2025

      • BrainzBot
        SEARCH-594: Port Search Index Rebuilder (SIR) to Python 3 https://tickets.metabrainz.org/browse/SEARCH-594
      • 2025-05-16 13652, 2025

      • julian45[m]
        pure spitballing, may be worthless for now, but: just out of curiosity, i wonder if there might be any benefit in trying `uv`; i know other projects have seen benefit in terms of substantially faster image builds when using `uv pip` vs plain `pip` for example.
      • 2025-05-16 13652, 2025

      • julian45[m]
      • 2025-05-16 13654, 2025

      • julian45[m]
        the team behind it also made ruff, which is a good & performant linter that i've been happy with (and i think zas was too when he tried it in picard?)
      • 2025-05-16 13628, 2025

      • milkii_ has quit
      • 2025-05-16 13614, 2025

      • reosarevok[m]
        Oh that was quick :D
      • 2025-05-16 13641, 2025

      • reosarevok[m]
        Thanks yvanzo
      • 2025-05-16 13653, 2025

      • _BrainzGit
        [sir] 14yvanzo opened pull request #162 (03master…schema-30): SEARCH-740: Upgrade MB DB schema version to 30 - 2025 Q2 https://github.com/metabrainz/sir/pull/162
      • 2025-05-16 13654, 2025

      • BrainzBot
        SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740
      • 2025-05-16 13614, 2025

      • yvanzo[m]
        reosarevok: I picked up, split, documented, and completed some of your commits for this one. ^
      • 2025-05-16 13625, 2025

      • reosarevok[m]
        I just saw, thanks
      • 2025-05-16 13627, 2025

      • reosarevok[m]
        Checking it
      • 2025-05-16 13614, 2025

      • reosarevok[m]
        But it won't work as-is unless you also add my changes adding medium gids from https://github.com/metabrainz/sir/pull/160
      • 2025-05-16 13627, 2025

      • reosarevok[m]
        (well I expect it will work, just the tests won't)
      • 2025-05-16 13657, 2025

      • yvanzo[m]
        reosarevok: Correct, I will move it to your PR then.
      • 2025-05-16 13609, 2025

      • reosarevok[m]
        Works for me as well
      • 2025-05-16 13613, 2025

      • fettuccinae[m] has quit
      • 2025-05-16 13649, 2025

      • bitmap[m]
      • 2025-05-16 13624, 2025

      • bitmap[m]
        otherwise solr will error about the mediumid property
      • 2025-05-16 13600, 2025

      • yvanzo[m]
        Is it what you did for test.mb.o?
      • 2025-05-16 13645, 2025

      • yvanzo[m]
        reosarevok: Updated your PR. Can you please update the status of your tickets (with PR links if needed)?
      • 2025-05-16 13653, 2025

      • reosarevok[m]
        Sure!
      • 2025-05-16 13647, 2025

      • _BrainzGit
        [sir] 14yvanzo closed pull request #162 (03master…schema-30): SEARCH-740: Upgrade MB DB schema version to 30 - 2025 Q2 https://github.com/metabrainz/sir/pull/162
      • 2025-05-16 13647, 2025

      • BrainzBot
        SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740
      • 2025-05-16 13648, 2025

      • bitmap[m]
        yvanzo[m]: for test.mb, I had merged the medium gid for sir, but not the one for mbsssss (it was just using the mb-solr v4.0.0 tag as-is). so reindexing was succesful except for errors about `mediumid`
      • 2025-05-16 13618, 2025

      • yvanzo[m]
        bitmap: Ok, thank you.
      • 2025-05-16 13630, 2025

      • bitmap[m]
        (that was an oversight, I had forgotten about the mbsssss PR)
      • 2025-05-16 13651, 2025

      • yvanzo[m] is off for food.
      • 2025-05-16 13647, 2025

      • reosarevok[m]
        All 3 tickets are AFAICT still in review, but I linked all relevant PRs to each of them now I think
      • 2025-05-16 13620, 2025

      • reosarevok[m]
        brb too
      • 2025-05-16 13628, 2025

      • zas[m]
        julian45 @julian45:julian45.net: yes I like uv, simple, efficient
      • 2025-05-16 13651, 2025

      • mamanullah7[m] has quit
      • 2025-05-16 13626, 2025

      • adhawkins has quit
      • 2025-05-16 13618, 2025

      • adhawkins joined the channel
      • 2025-05-16 13644, 2025

      • Kladky has quit
      • 2025-05-16 13651, 2025

      • Kladky joined the channel