reosarevok: let me know when you have a couple of minutes for some MB schema/data use questions.
reosarevok[m]
If it's a couple minutes and doesn't need a keyboard, now is fine, mayhem:
mayhem[m]
you will need a keyboard, I believe. not urgent, but in the course of the day would be great.
zas: on pypi.org we previously didn't have an organization, just an account called metabrainz. we now have an organization where the members can each have their own login. I've moved all my projects over into the new org -- should picard be moved as well?
lucifer: same for mb-rngpy -- should that be transferred?
lucifer[m]
mayhem: yes
zas[m]
outsidecontext: ^^ about pypi
mayhem[m]
lucifer[m]: done
derat[m] has quit
lucifer[m]
mayhem: have you added me to the org too?
mayhem[m]
next step
remind me of your pypi account name, lucifer "lucifermorningstar"?
outsidecontext: same for you -- is your handle the usual?
lucifer[m]
techmorningstar
mayhem[m]
lucifer[m]: invited as owner.
reosarevok[m]
<mayhem[m]> "you will need a keyboard, I..." <- Ok, I'm traveling in Spain but I'll get the laptop out when I get back to the car then
mayhem[m]
reosarevok[m]: you're traveling on schema change day? brave!
when are you scheduled to be at a keyboard?
monkey[m] joined the channel
monkey[m]
mshahnawaz1: Responding to your message here regarding LB-1761, let's do tech discussions in here :)
Since we have two different set of filters, I assume yes you will need to store them separately, using the `pageType` somewhere in the storage key name. I think that will probably be easier and more flexible than other options (some common settings, then two more type-specific settings separate).
Regarding how you storage values refresh I can't do anything for you without any info, so why don't you open a draft PR with the code you have so I can have a look?
mglubb: we haven't broken anything yet, have we???
also, welcome!
mglubb[m] joined the channel
mglubb[m]
Ha! No! I've been looking at SIR and was wondering whether you'd be migrating (or have already migrated) to Python 3 as part of this release?
mshahnawaz1[m] joined the channel
mshahnawaz1[m]
Ok thanks, I will create the draft PR
mayhem[m]
mglubb[m]: lucifer: yvanzo : this one is for you two.
(I want to say that yes, py3 is happening, but lets get confirmation)
outsidecontext[m joined the channel
outsidecontext[m
mayhem: my handle on pypi is the usual "phw". yes, let's move picard as well
mayhem[m]
invited as manager.
and picard moved. all of our projects are now under the metabrainz foundation org.
rayyan_seliya123 joined the channel
rayyan_seliya123
monkey: I’ve updated the search components to expose the reset function through the imperative handle, and I’m now calling `searchInputRef.current?.reset()` from the parent after each submission. This seems to be working well it clears both the input and the search results just like we wanted. see the latest
[commit](https://github.com/metabrainz/listenbrainz-server/pull/3269/commits/e4bca5f15bbe72084412b8746834627b8856a539) any further changes needed do let me know !!
monkey[m]
rayyan_seliya123: Nice work! Will reveiw the PR again, just give me some time :)
rayyan_seliya123
monkey[m]: No worries ☺️ ! Okk 👍
outsidecontext[m
mayhem: btw, a few days ago I wrote jonnyJD about the python-discid package. Because Picard uses it and it hasn't seen activity from his side I think generally it would be good if we get this package also into the metabrainz org. I haven't heard back yet (not sure whether the email I have is still current). Let's see.
mayhem[m]
sure, let me know what needs doing when the times comes.
mayhem: do you have time today to review the dumps pr?
mayhem[m]
Let me do that now
lucifer[m]
thanks!
mayhem[m]
wait, was this the PR where you asked if I took a cursory look before you tested something?
lucifer[m]
yes
mayhem[m]
ah, I didn't realize that now needed the full review. I missed that message.
lucifer[m]
it refactors dumps code including private dumps so i haven't tested it in prod yet
mayhem[m]
for listenbrainz/dumps/tables.py should I take the time to go through the tables/columns table by table, column by column to make sure there are no discrepancies?
approved, but happy to double check all the tables/columns if you think that should be done.
lucifer[m]
those are mostly copied, except for wrapping in Composable/Literal as needed.
mayhem[m]
lucifer: last thing for now on @fettuccinae:matrix.org 's PR ( https://github.com/metabrainz/metabrainz.org/pu... ) -- that PR is ready for merging and in theory should not conflict with production for now. I think we can merge this PR, but future PRs may not be so clean.
would it be good to add a "approved PRs" branch for @fettuccinae:matrix.org 's work that we merge at the end of the project? what are your thoughts?
lucifer[m]
i think its fine to merge.
in master directly.
but if you prefer we can make an approved branch and deploy that to test.meb.org until the project is completed.
on second thought, yeah let's do that would be useful if we need to change the schema later for some reason.
mayhem[m]
@fettuccinae:matrix.org: I've created a new empty branch that will serve as the "holding pen" for all of your approved PRs: metabrainz-notifications
Can you please update your PR and have it target metabrainz-notifications, rather than master?
and then future PRs, should all attempt to merge into metabrainz-notifications, ok?
then at the end of the project we merge metabrainz-notifications into master and release the whole thing.
fettuccinae[m] joined the channel
fettuccinae[m]
<mayhem[m]> "Can you please update your PR..." <- Yes, on it
