I think you can also use category that is provided by playstore and merge the two results
Whether or not use likes to scrobble yt songs
We need to give them an option
But that option should be lower in the hierarchy
This can be resolved via category tag
s/scrobble/listen/
* likes to listen/scrobble yt
* Whether or not use likes to listen/scrobble yt videos
* the hierarchy when list the apps
lusciouslover has quit
HemangMishra[m]
Okay, I'll work on using category tags and will get back to you.
d4rk-ph0enix joined the channel
<jasje[m]> "I think you can also use..." <- Can you please clarify what you mean by 'category provided by playstore'? Are u referring to Android's `ApplicationInfo.category` or actual Play Store categories like 'Music & Audio', 'Entertainment' that we might have to fetch using some third party apis, or maybe something else entirely?
dabeglavins60721 has quit
<HemangMishra[m]> "Can you please clarify what..." <- Also for YouTube specifically - should I show it as a separate toggle option with explanation text, or just categorize it differently but let users decide normally
pite has quit
HemangMishra[m] uploaded an image: (1090KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/YJOxemeNvUepyvFQcvDpjGpT/image.png >
jasje[m]
<HemangMishra[m]> "Also for YouTube specifically..." <- AppInfo
HemangMishra[m]
jasje[m]: So for that we will have to fetch all installed apps to check the category right?
HemangMishra[m]: I was trying to avoid this approach because google treats installed apps as personal info so might be a trouble in playstore.
lucifer, monkey: is this likely to be about LB? In support: `My profile, [X], tries to load and I see it for a second, then there's an error page regarding an "invalid video id".`
It doesn't specify further, but I can't imagine that'd be MB, so
[@suvid:matrix.org](https://matrix.to/#/@suvid:matrix.org) if it is used at only one place, you can move it to the file where import APIs are defined.
[@reosarevok:chatbrainz.org](https://matrix.to/#/@reosarevok:chatbrainz.org) it's a lb issue, and looking into it.
suvid[m]
lucifer[m]: Sorry, I didn't get it
lucifer[m]
suvid: have you pushed the latest changes? i think the PR is not updated yte
suvid[m]
yes I have pushed the changes
<lucifer[m]> "[@suvid:matrix.org](https://..." <- I have not done this yet tho
Apart from this, all my changes are pushed
lucifer[m]
the import_files API should be removed.
Oh i see, you removed the API from the other file. nevermind.
suvid[m]
yes
working on the changes now 🫡
lucifer[m]
i think you had missed a couple of changes i mentioned in the first review so i have added more detailed comment explaining it again.
suvid: i see, where the confusion came from about using listens_importer table instead of background_tasks and related changes, `user_data_export` works differently because its standalone. but listens importer and external service oauth tables are used in multiple other places and context hence the changes i suggested
let's focus on building the rest of the importer and zip file processing etc for now.
the main thing to consider about the APIs is how to present the import progress to the user and we can discuss that with monkey later.
mamanullah7[m]
lucifer: is there any review on my pr!! yesterday some test failed which were passed before i think after merging master branch! if u can once review! in `MusicServices.tsx` i need to add `currentUser` which i was using in `auth_header`
lucifer[m]
m.amanullah7: you can get the `current_user` from `useContext`, check other files for example.
when that is merged, you can merge master into your branch to fix it
suvid[m]
<lucifer[m]> "let's focus on building the rest..." <- oh
I was thinking of making a separate PR for rest of the importer
separate from this one
or should I just commit further in this only??
s/??/?/
lucifer[m]
one PR is fine for now.
rayyan_seliya123
lucifer: have u reviewd that pr ?!
mamanullah7[m] sent a export code block: https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/lFPhtsSIswrjEGztnWStIHVr
Maxr1998 joined the channel
Maxr1998_ has quit
lucifer[m]
rayyan_seliya123: in general changes look fine to me, a couple of minor comments. i will take a look at IA and indexing to review the rest of the parts.
rayyan_seliya123
Thanks lucifer for the feedback : i have just seen your review comments , i have proposed some changes in the reviewed comments u can have a look and do confirm me that they are fine ? also waiting for your detailed feedback on my models tables , migrations and all ..and love to move forward to the api phase!!
lucifer[m]
rayyan_seliya123: yes, i'll finish reviewing your PR today and let you know what to do next.
