#metabrainz

Hi jasje , for fetching music apps during onboarding, I was planning to query apps based on the below intents.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

I think you can also use category that is provided by playstore and merge the two results

Whether or not use likes to scrobble yt songs

We need to give them an option

But that option should be lower in the hierarchy

This can be resolved via category tag

s/scrobble/listen/

* likes to listen/scrobble yt

* Whether or not use likes to listen/scrobble yt videos

* the hierarchy when list the apps

Okay, I'll work on using category tags and will get back to you.

<jasje[m]> "I think you can also use..." <- Can you please clarify what you mean by 'category provided by playstore'? Are u referring to Android's `ApplicationInfo.category` or actual Play Store categories like 'Music & Audio', 'Entertainment' that we might have to fetch using some third party apis, or maybe something else entirely?

<HemangMishra[m]> "Can you please clarify what..." <- Also for YouTube specifically - should I show it as a separate toggle option with explanation text, or just categorize it differently but let users decide normally

<HemangMishra[m]> "Also for YouTube specifically..." <- AppInfo

jasje[m]: So for that we will have to fetch all installed apps to check the category right?

HemangMishra[m]: I was trying to avoid this approach because google treats installed apps as personal info so might be a trouble in playstore.

[musicbrainz-server] 14mwiencek opened pull request #3579 (03master…update-test-services): Update test services https://github.com/metabrainz/musicbrainz-serve...

HemangMishra[m]: My current approach only requires these queries in Manifest.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

[listenbrainz-server] 14dependabot[bot] opened pull request #3305 (03master…dependabot/pip/urllib3-2.5.0): Bump urllib3 from 2.4.0 to 2.5.0 https://github.com/metabrainz/listenbrainz-serv...

lucifer, monkey: is this likely to be about LB? In support: `My profile, [X], tries to load and I see it for a second, then there's an error page regarding an "invalid video id".`

It doesn't specify further, but I can't imagine that'd be MB, so

Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

I will commit changes after this and I think it should be ready to be merged then

After this, I will proceed with zip file processing for Spotify

I think I will write tests after completing the Spotify imports completely and then start with other services as they should be simpler to implement

* Hi lucifer... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)

[@suvid:matrix.org](https://matrix.to/#/@suvid:matrix.org) if it is used at only one place, you can move it to the file where import APIs are defined.

[@reosarevok:chatbrainz.org](https://matrix.to/#/@reosarevok:chatbrainz.org) it's a lb issue, and looking into it.

lucifer[m]: Sorry, I didn't get it

suvid: have you pushed the latest changes? i think the PR is not updated yte

yes I have pushed the changes

<lucifer[m]> "[@suvid:matrix.org](https://..." <- I have not done this yet tho

Apart from this, all my changes are pushed

the import_files API should be removed.

Oh i see, you removed the API from the other file. nevermind.

yes

working on the changes now 🫡

i think you had missed a couple of changes i mentioned in the first review so i have added more detailed comment explaining it again.

suvid: i see, where the confusion came from about using listens_importer table instead of background_tasks and related changes, `user_data_export` works differently because its standalone. but listens importer and external service oauth tables are used in multiple other places and context hence the changes i suggested

let's focus on building the rest of the importer and zip file processing etc for now.

the main thing to consider about the APIs is how to present the import progress to the user and we can discuss that with monkey later.

lucifer: is there any review on my pr!! yesterday some test failed which were passed before i think after merging master branch! if u can once review! in `MusicServices.tsx` i need to add `currentUser` which i was using in `auth_header`

m.amanullah7: you can get the `current_user` from `useContext`, check other files for example.

for the failing test, there is an open PR: https://github.com/metabrainz/listenbrainz-serv...

when that is merged, you can merge master into your branch to fix it

<lucifer[m]> "let's focus on building the rest..." <- oh

I was thinking of making a separate PR for rest of the importer

separate from this one

or should I just commit further in this only??

s/??/?/

one PR is fine for now.

lucifer: have u reviewd that pr ?!