#metabrainz

/

      • lucifer[m]
        holycow23: test it in pyspark using the new commands i shared.
      • pite has quit
      • davic has quit
      • rayyan_seliya123
        <rayyan_seliya123> "hey lucifer: I noticed that..." <- > <@rayyan_seliya123:matrix.org> hey lucifer: I noticed that in my latest push I am not using any models for my indexer implementation and not importing it in my indexer script though it is still present in `models.py` I was thinking should we remove... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
      • Kladky joined the channel
      • outsidecontext[m
        mayhem: good morning. It's the time again where Apple has changes to their license agreements and wants you to accept that :) Picard code signing is failing again
      • lucifer[m]
        rayyan_seliya123: oh sorry, i missed that comment yes. i'll review your PR again today and let you know then what to do about the models as well.
      • rayyan_seliya123
        lucifer[m]: No worries, okk !
      • lucifer[m]
        mayhem: for when you have time, https://github.com/metabrainz/listenbrainz-serv...
      • __BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #3305 (03master…dependabot/pip/urllib3-2.5.0): Bump urllib3 from 2.4.0 to 2.5.0 https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] 14amCap1712 merged pull request #3299 (03master…dependabot/pip/requests-2.32.4): Bump requests from 2.32.3 to 2.32.4 https://github.com/metabrainz/listenbrainz-serv...
      • reosarevok[m]
        yvanzo: when you have a bit of time and are feeling better, could you check if you have any feedback on https://github.com/metabrainz/musicbrainz-serve... and https://github.com/metabrainz/musicbrainz-serve... by bitmap ?
      • They seem sensible enough to me but two sets of eyes are always best :)
      • mthax_ has quit
      • mthax joined the channel
      • mamanullah7[m]
        lucifer: i'm getting this error i'm not able to understand whats the issue!... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
      • mamanullah7[m] uploaded an image: (365KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/vnyprCeTiDAelZTbmYmvcFTO/Screenshot%202025-06-25%20at%201.49.19%E2%80%AFPM.png >
      • but here i can see its authorising!
      • lucifer[m]
        m.amanullah7: push your latest code to the PR and i'll check
      • rayyan_seliya123: taking a look at the PR, it looks good to me. let's keep the model for now and we can delete it later if still not needed.
      • you should refactor it to be like the other caches now. take a look at SoundcloudHandler and refactor your class to work like that. the rabbitmq connection bits will then be automatically handled by the ServiceMetadataCache
      • mamanullah7[m]
        lucifer: i've pushed the changes
      • lucifer[m]
        👍️
      • suvid: hi! any update on the changes?
      • rayyan_seliya123
        <lucifer[m]> "rayyan_seliya123: taking a..." <- Sure !
      • <lucifer[m]> "you should refactor it to be..." <- Thx for the review ,Sure I will refactor it like other cache and will update you after that !