hey lucifer if a song is not available on fw then should be simply return null or should be return 10-20 similar songs available in fw servers and play one?
2025-07-02 18315, 2025
mamanullah7[m]
<mamanullah7[m]> "i was thinking of dynamically..." <- monkey: ansh Any review?
2025-07-02 18349, 2025
ansh[m]
<mamanullah7[m]> "Hey ansh: i was going through..." <- Hi! So, we have a default priority list which we had formed based on the performance of the players. Initially all users will have the same priority list, however they have the full liberty to reorder the priority list for themselves.
2025-07-02 18349, 2025
ansh[m]
Yes, if a new service is added, it'll not be there in the user's priority list. So what you need to do is find a way to push the newly added service dynamically. This can be handles in the frontend itself, you don't need to modify the user's priority list saved in the database.
2025-07-02 18349, 2025
ansh[m]
For removal of a service, I don't think we should handle those cases as of now. If we ever decide to remove a service, we can either mark it as deprecated and just not allow user's to use it, or just remove it from the DB itself, but that's a concern for later.
2025-07-02 18332, 2025
mamanullah7[m]
Sounds good to me!
2025-07-02 18303, 2025
mamanullah7[m]
cant we simply add newly added service in last user priority list? will simply push the new one in last!
2025-07-02 18331, 2025
ansh[m]
Yes, but do you want to make this change in the database?
2025-07-02 18329, 2025
mamanullah7[m]
i dont think we need to change anything in db i'm thinking of handling with frontend itself!
2025-07-02 18356, 2025
ansh[m]
Thats correct, you can simply add the new services in the bottom
2025-07-02 18339, 2025
ansh[m]
You can handle all of this in the frontend itself
2025-07-02 18343, 2025
mamanullah7[m]
Sure!
2025-07-02 18309, 2025
mamanullah7[m]
ansh: Thanks for the review!
2025-07-02 18353, 2025
__BrainzGit
[listenbrainz-server] 14RayyanSeliya opened pull request #3316 (03master…integrating-ia-into-bp): Integrating Internet Archive recordings into Brainzplayer https://github.com/metabrainz/listenbrainz-server…
2025-07-02 18308, 2025
rayyan_seliya123 has quit
2025-07-02 18356, 2025
rayyan_seliya123 joined the channel
2025-07-02 18356, 2025
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: you can..." <- hey lucifer I have just created a new PR for this and pushed my latest changes to it you can have a look also i have attached the video of my player in that pr itself and i am eager to have a feedback on it and what i am missing more on it and what to add further ?
2025-07-02 18327, 2025
petitminion joined the channel
2025-07-02 18333, 2025
petitminion has quit
2025-07-02 18314, 2025
lucifer[m]
<mamanullah7[m]> "hey lucifer if a song is not..." <- return null, BP will try a different source or skip it
2025-07-02 18325, 2025
lucifer[m]
<rayyan_seliya123> "hey lucifer I have just created..." <- will try review later today or tomorrow
2025-07-02 18326, 2025
lucifer[m]
rayyan_seliya123: if you want you can try adding an api endpoint to LB server, to search the table for the artist/track etc and return a result.
2025-07-02 18308, 2025
mamanullah7[m]
lucifer[m]: lucifer: the search query returning random songs from the funkwhale servers if a song not present in the servers, i'm trying to improve and filtering manually if not it will be highly inaccurate as fw is self hoisted so the availablity of songs is much more lesser!?
2025-07-02 18303, 2025
lucifer[m]
m.amanullah7: i see, leave a comment in your PR and i'll try to look into it
2025-07-02 18354, 2025
mamanullah7[m]
Sure and also the refresh, token one!!
2025-07-02 18304, 2025
lucifer[m]
yes sure, i probably won't have the time today but remind me tomorrow.
2025-07-02 18323, 2025
mamanullah7[m]
lucifer: I'll push some changes today and will let u know! and i also need review for frontend part i think i'm making frontend much more complex lol!
2025-07-02 18329, 2025
mamanullah7[m]
lucifer[m]: Sure no issue!
2025-07-02 18356, 2025
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: if you want..." <- lucifer:sure ! I'll think about it and can u please look at the pr I am doing it in a correct way or not ? in your free time so that it would be helpful for me to understand and go further for api ..
2025-07-02 18359, 2025
lucifer[m]
mamanullah7[m]: for the frontend, monkey and ansh will be able to assist you better but yes list down your questions in the PR for now I guess.
yvanzo: re https://github.com/metabrainz/musicbrainz-server/… I have no idea what I did, I've never used inkscape before. I was hoping I could just move the lines to make some sense and that would do the trick, but it seems that's not it then
2025-07-02 18335, 2025
reosarevok[m]
I guess at least for some of them, the suggestion is to drop the regenerated image entirely and just change some text by hand in the svg file or?
2025-07-02 18351, 2025
yvanzo[m]
reosarevok: No, it is to drop the unnecessary visual changes only.
2025-07-02 18317, 2025
yvanzo[m]
Mainly line changes.
2025-07-02 18326, 2025
reosarevok[m]
Yeah, but all those visual changes were forced by the way the image was generated IIRC - in that as soon as the new image was generated, the lines were a horrible garbled mess
2025-07-02 18343, 2025
reosarevok[m]
And I had to move them all around
2025-07-02 18356, 2025
reosarevok[m]
That's why I'm asking if I should just edit the svg source to change strings instead
2025-07-02 18328, 2025
yvanzo[m]
"change some text", "change strings", if you mean SVG code, yes.
2025-07-02 18330, 2025
yvanzo[m]
Once the SVG code is normalized (using the make normalized), it is easy to pick up changes using gitk (and its git gui).
2025-07-02 18331, 2025
mamanullah7[m]
lucifer: i've pushed the latest changes later u can have a look!
Hey monkey ansh frontend is also ready to review now, as suggested by monkey about fwIcon, styling etc i've tried to match the styling! You can have a look and let me know if anything i can improve or any changes needed!
I don't have a funkwhale server myself, any tips for testing the PR?
2025-07-02 18330, 2025
mamanullah7[m]
U can use mine or lucifer: can create a new user for u!
2025-07-02 18313, 2025
lucifer[m]
monkey, mayhem, ansh : team meeting on coming monday?
2025-07-02 18335, 2025
mayhem[m] joined the channel
2025-07-02 18336, 2025
mayhem[m]
coming monday, please.
2025-07-02 18339, 2025
monkey[m]
I am free.
2025-07-02 18346, 2025
mayhem[m]
#accountinghell
2025-07-02 18350, 2025
monkey[m]
The 7th?
2025-07-02 18337, 2025
lucifer[m]
mayhem[m]: 7th right or do you mean the one after?
2025-07-02 18352, 2025
mayhem[m]
7th is fine
2025-07-02 18358, 2025
lucifer[m]
cool
2025-07-02 18315, 2025
reosarevok[m]
bitmap, aerozol: MBS-14084 makes sense to me, but what do you feel? Re: making events sort newest first, sorting of course we all want but that's a different, longer ticket :p
<monkey[m]> "I don't have a funkwhale..." <- monkey: Sorry i missed one thing you need to create tables before u connect fw servers!... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/kPkgRzGHnNEVeYvOUXleIBgd>)
2025-07-02 18314, 2025
holycow23[m] joined the channel
2025-07-02 18314, 2025
holycow23[m]
hey lucifer have you added genre data to the test so, I could test it out and wind up the genre stats
