hey lucifer if a song is not available on fw then should be simply return null or should be return 10-20 similar songs available in fw servers and play one?
<mamanullah7[m]> "i was thinking of dynamically..." <- monkey: ansh Any review?
ansh[m]
<mamanullah7[m]> "Hey ansh: i was going through..." <- Hi! So, we have a default priority list which we had formed based on the performance of the players. Initially all users will have the same priority list, however they have the full liberty to reorder the priority list for themselves.
Yes, if a new service is added, it'll not be there in the user's priority list. So what you need to do is find a way to push the newly added service dynamically. This can be handles in the frontend itself, you don't need to modify the user's priority list saved in the database.
For removal of a service, I don't think we should handle those cases as of now. If we ever decide to remove a service, we can either mark it as deprecated and just not allow user's to use it, or just remove it from the DB itself, but that's a concern for later.
mamanullah7[m]
Sounds good to me!
cant we simply add newly added service in last user priority list? will simply push the new one in last!
ansh[m]
Yes, but do you want to make this change in the database?
mamanullah7[m]
i dont think we need to change anything in db i'm thinking of handling with frontend itself!
ansh[m]
Thats correct, you can simply add the new services in the bottom
You can handle all of this in the frontend itself
mamanullah7[m]
Sure!
ansh: Thanks for the review!
__BrainzGit
[listenbrainz-server] 14RayyanSeliya opened pull request #3316 (03master…integrating-ia-into-bp): Integrating Internet Archive recordings into Brainzplayer https://github.com/metabrainz/listenbrainz-serv...
rayyan_seliya123 has quit
rayyan_seliya123 joined the channel
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: you can..." <- hey lucifer I have just created a new PR for this and pushed my latest changes to it you can have a look also i have attached the video of my player in that pr itself and i am eager to have a feedback on it and what i am missing more on it and what to add further ?
petitminion joined the channel
petitminion has quit
lucifer[m]
<mamanullah7[m]> "hey lucifer if a song is not..." <- return null, BP will try a different source or skip it
<rayyan_seliya123> "hey lucifer I have just created..." <- will try review later today or tomorrow
rayyan_seliya123: if you want you can try adding an api endpoint to LB server, to search the table for the artist/track etc and return a result.
mamanullah7[m]
lucifer[m]: lucifer: the search query returning random songs from the funkwhale servers if a song not present in the servers, i'm trying to improve and filtering manually if not it will be highly inaccurate as fw is self hoisted so the availablity of songs is much more lesser!?
lucifer[m]
m.amanullah7: i see, leave a comment in your PR and i'll try to look into it
mamanullah7[m]
Sure and also the refresh, token one!!
lucifer[m]
yes sure, i probably won't have the time today but remind me tomorrow.
mamanullah7[m]
lucifer: I'll push some changes today and will let u know! and i also need review for frontend part i think i'm making frontend much more complex lol!
lucifer[m]: Sure no issue!
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: if you want..." <- lucifer:sure ! I'll think about it and can u please look at the pr I am doing it in a correct way or not ? in your free time so that it would be helpful for me to understand and go further for api ..
lucifer[m]
mamanullah7[m]: for the frontend, monkey and ansh will be able to assist you better but yes list down your questions in the PR for now I guess.
yvanzo: re https://github.com/metabrainz/musicbrainz-serve... I have no idea what I did, I've never used inkscape before. I was hoping I could just move the lines to make some sense and that would do the trick, but it seems that's not it then
I guess at least for some of them, the suggestion is to drop the regenerated image entirely and just change some text by hand in the svg file or?
yvanzo[m]
reosarevok: No, it is to drop the unnecessary visual changes only.
Mainly line changes.
reosarevok[m]
Yeah, but all those visual changes were forced by the way the image was generated IIRC - in that as soon as the new image was generated, the lines were a horrible garbled mess
And I had to move them all around
That's why I'm asking if I should just edit the svg source to change strings instead
yvanzo[m]
"change some text", "change strings", if you mean SVG code, yes.
Once the SVG code is normalized (using the make normalized), it is easy to pick up changes using gitk (and its git gui).
mamanullah7[m]
lucifer: i've pushed the latest changes later u can have a look!
Hey monkey ansh frontend is also ready to review now, as suggested by monkey about fwIcon, styling etc i've tried to match the styling! You can have a look and let me know if anything i can improve or any changes needed!
I don't have a funkwhale server myself, any tips for testing the PR?
mamanullah7[m]
U can use mine or lucifer: can create a new user for u!
lucifer[m]
monkey, mayhem, ansh : team meeting on coming monday?
mayhem[m] joined the channel
mayhem[m]
coming monday, please.
monkey[m]
I am free.
mayhem[m]
#accountinghell
monkey[m]
The 7th?
lucifer[m]
mayhem[m]: 7th right or do you mean the one after?
mayhem[m]
7th is fine
lucifer[m]
cool
reosarevok[m]
bitmap, aerozol: MBS-14084 makes sense to me, but what do you feel? Re: making events sort newest first, sorting of course we all want but that's a different, longer ticket :p
<monkey[m]> "I don't have a funkwhale..." <- monkey: Sorry i missed one thing you need to create tables before u connect fw servers!... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
holycow23[m] joined the channel
holycow23[m]
hey lucifer have you added genre data to the test so, I could test it out and wind up the genre stats
