#metabrainz

/

      • aerozol[m]1
        mayhem: A question via Mastodon - “@musicbrainz I stumbled upon Music Story, a commercial music metadata service. Out of curiosity, do they have a relationship with #MusicBrainz other than including it in their list of external identifiers?”
      • I said it’s the first I’d heard of it, but I’d ask :)
      • pite_ has quit
      • Kladky joined the channel
      • d4rk-ph0enix joined the channel
      • d4rkie_ has quit
      • reosarevok[m]
        "Advertising is no longer able to cover our operating costs. If you are a longtime visitor of AllMusic and want to see the site continue, please donate by becoming an AllMusic Subscriber."
      • Wow, I didn't realize even AMG was asking for donations
      • bitmap, aerozol, yvanzo : opinion on MBS-14087 ? Having banned spammer subscribers is effectively harmless, but I guess some people might be bothered by the number being "fake"?
      • BrainzBot
        MBS-14087: Remove subscriptions from accounts after they've been marked as spam https://tickets.metabrainz.org/browse/MBS-14087
      • aerozol[m]1
        I guess I’m not against it in principle, but is it a good use of dev time? Though I suppose it would also be good to completely silo spammer accounts/not have them linked to other entities in any way
      • yvanzo[m]
        I would avoid doing that, as spammer flag is a temporary measure before deleting the account, false positive would hurt.
      • aerozol[m]1
        I thought we are keeping all spammer accounts, for some kind of possible future anti-spam training?
      • yvanzo[m]
        thus temporary
      • aerozol[m]1
        I’m not sure I flag anyone as spammer that isn’t definitely a spammer, but I suppose it’s possible
      • yvanzo[m]
        It was also supposed to give a delay for complaints. False positive are just a misclick away.
      • reosarevok[m]
        I think bitmap had the idea of having a cron option to delete forum accounts from spammers that had been marked as such for a while
      • Although I guess we'd need to have a way to indicate how long they've been marked as spammers in that case :)
      • lucifer[m]
        yvanzo: yes those docstrings can be removed.
      • probably forgot to do that when we changed it to use requests.
      • yvanzo[m]
        shouldn't these be fixed instead?
      • lucifer[m]
        sure, can update them too. i think the request ConnectionErrors are obvious and provide little value in the docs and also there are a lot of those if we want to document them all.
      • the overall possible exceptions are listed at https://requests.readthedocs.io/en/latest/_modu.... and a lot of these could happen when making a request.
      • suvid[m] has quit
      • yvanzo[m]
        And there is no meaningful common parent to these exceptions?
      • petitminion joined the channel
      • lucifer[m]
        I think RequestException captures most.
      • kellnerd[m] has quit
      • yvanzo[m]
        lucifer: I pushed a fix to the current PR.
      • As you might not be around, I will make a separate PR. :)
      • lucifer[m]
        yvanzo: yes sorry, around now. either way sounds fine to me
      • petitminion has quit
      • __BrainzGit
        [sir] 14yvanzo opened pull request #170 (03master…fix-cx-docstring): Fix the docstring for the function `solr_connection` https://github.com/metabrainz/sir/pull/170
      • [sir] 14yvanzo merged pull request #169 (03master…upd-deps): Update requests and urllib3 dependencies https://github.com/metabrainz/sir/pull/169
      • yvanzo[m]
        Just noticed that I was also fixing the docs in the PR #166. :D
      • lucifer: Do you any idea why “JenkinsExpected — Waiting for status to be reported” does show up? I can’t find any repository webhook about it, neither any occurrences of `ci.metabrainz` or `jenkins` in the repository.
      • lucifer[m]
        yvanzo: i was looking at the same but couldn't figure out why yet
      • __BrainzGit
        [sir] 14yvanzo merged pull request #170 (03master…fix-cx-docstring): Fix the docstring for the function `solr_connection` https://github.com/metabrainz/sir/pull/170
      • lucifer[m]
        yvanzo: fixed, there was a branch protection rule referring to jenkins.
      • yvanzo[m]
        lucifer: Good catch, thank you!