everything working fine for fw rn! you can have a look once!
2025-07-17 19800, 2025
reosarevok[m]
aerozol, bitmap, yvanzo, ansh : if planned in advance I should be able to make most but not every meeting time even while here, so if you decide on a time or a few times let me know and I'll confirm if I can make it
Couldn't find anything in the chat about this, is it known? Or just wait for the next stat refresh?
2025-07-17 19809, 2025
lucifer[m]
[@aerozol:matrix.org](https://matrix.to/#/@aerozol:matrix.org) I think it's an issue that happens after full dumps are produced, and my understanding is that last week stats are affected. It goes away when I run stats again so a bit hard to debug but it's on my list of things to fix.
2025-07-17 19810, 2025
lucifer[m]
Can you confirm which stats are broken? I see listening activity for last week is broken
2025-07-17 19821, 2025
lucifer[m]
Are other last week stats fine?
2025-07-17 19848, 2025
lucifer[m]
And can you also check if any other time range stats are broken
2025-07-17 19829, 2025
zas[m]
lucifer: can we remove nomo VM?
2025-07-17 19857, 2025
aerozol[m]
lucifer: you get the same view as me right?
2025-07-17 19823, 2025
aerozol[m]
Hmm yeah this week/this month looks fine to me (a day+ behind but I think that's normal/due to my timezone)
2025-07-17 19803, 2025
rayyan_seliya123
Hey monkey: I am seeing the “Searching Internet Archive...” message appear at the bottom of the player when I try to play a track, which means the searchAndPlayTrack function is being called and loading is set to true.
2025-07-17 19803, 2025
rayyan_seliya123
However, I do not see any network request to '/1/internet_archive/search?...` in my browser’s network tab when I hit play , the fetch request to the API endpoint is not appearing at all.
2025-07-17 19803, 2025
rayyan_seliya123
Do you have any idea what could cause this? Is there something in the React lifecycle, player activation, or data flow that could prevent the fetch from actually being made, even though the loading state is set? Any guesses lucifer ??
2025-07-17 19858, 2025
monkey[m]
Any error in the console?
2025-07-17 19812, 2025
rayyan_seliya123
monkey[m]: Nope !
2025-07-17 19839, 2025
monkey[m]
🤷
2025-07-17 19849, 2025
monkey[m]
Will have to try and run the code locally
2025-07-17 19808, 2025
monkey[m]
Here's one thing you can try:
2025-07-17 19850, 2025
monkey[m]
Actually never mind
2025-07-17 19853, 2025
rayyan_seliya123
monkey[m]: Am i missing any more logic /code to be implemented rather thab braizplaye.tsx and BrainzPlayerSettings.tsx
2025-07-17 19815, 2025
monkey[m]
Sorry, I don't understand the question
2025-07-17 19851, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files braizplaye.tsx and BrainzPlayerSettings.tsx?
2025-07-17 19817, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files Braizplayer.tsx and BrainzPlayerSettings.tsx?
2025-07-17 19843, 2025
monkey[m]
Do you mean in general or regarding this specific issue?
2025-07-17 19857, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files Braizplayer.tsx and BrainzPlayerSettings.tsx? Also in my Internetarchiveplayer.tsx
2025-07-17 19825, 2025
rayyan_seliya123
monkey[m]: In general !! Maybe this would be a cause
2025-07-17 19838, 2025
monkey[m]
I don't think so
2025-07-17 19806, 2025
monkey[m]
Do you know how to use your browser debugger to pause execution in the code, step through line by line, and all that?
2025-07-17 19822, 2025
monkey[m]
That woudl be the way to figure out what is happening in your code
2025-07-17 19823, 2025
rayyan_seliya123
Haven't tried yet ! But Will try too any steps how to
2025-07-17 19858, 2025
mayhem[m]
<aerozol[m]> "Heya ansh monkey bitmap reosarev..." <- I like it. its less ambitious than before and shouldn't be *that* much work. the only request I have is similar to my request for the LB home page: We need to make it clear that we're ethical and a data provider.
2025-07-17 19829, 2025
monkey[m]
<rayyan_seliya123> "Hey monkey: I am seeing the “..." <- So I tried faking the API response (modified listenbrainz/webserver/views/internet_archive_api.py to return a hardcoded response based on the gist you sent yesterday), and without any more modifications to the front-end, it is correctly playing the track and displaying everything correctly.
2025-07-17 19830, 2025
monkey[m] uploaded an image: (51KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/FWrKjAyGyNpLEiiGuxvzSisg/image.png >
2025-07-17 19850, 2025
monkey[m]
So, front-end is working as expected.
2025-07-17 19816, 2025
monkey[m]
I'm not able to easily test the actual internet archive api endpoint though. But considering faking the response both in the front-end and in the back-end results in functional playback, I'm goign to assume that if you have an issue it might be coming from the API endpoint/ IA cache side of things
2025-07-17 19831, 2025
monkey[m]
Now without any IA cache, and running the code exactly as currently pushed in the PR, what I get is this: I see the "searching the Internet Archive" loading text thing appear and disappear over and over as it tries to play track after track on the page, considering the API always returns 0 results for my setup (which is expected). Then I get to the end of the page and I'm left with the player looking like this:
2025-07-17 19833, 2025
monkey[m] uploaded an image: (22KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/blmWzxcLkxIlEMZEGhdCfgWv/image.png >
2025-07-17 19815, 2025
monkey[m]
Which I also expect is what would happen after not playing any actual track.
2025-07-17 19807, 2025
monkey[m]
rayyan_seliya123: Did you disable all the other music services in the BP settings page to make sure it only tries playing with the IA player?
2025-07-17 19833, 2025
rayyan_seliya123
monkey[m]: Yes always !!
2025-07-17 19802, 2025
monkey[m]
OK. Well. I'm sort of out of ideas. From what I can tell everything is working as expected on the front-end side.
2025-07-17 19839, 2025
rayyan_seliya123
Thx monkey: for your detailed review and testing I will talk with lucifer: about this and then get back to you for further frontend implementation!!
2025-07-17 19805, 2025
monkey[m]
Will leave a couple more review points
2025-07-17 19820, 2025
rayyan_seliya123
monkey[m]: Thankyou !! Sure
2025-07-17 19830, 2025
rayyan_seliya123
And what about the internet archive icon I have not used the official one so how to get the official one and update it in the brainzplayer settings page !!
2025-07-17 19853, 2025
rayyan_seliya123
Any suggestions? Would love to hear
2025-07-17 19809, 2025
monkey[m]
Ah, well you're in luck, m.amanullah7 had the same change to make.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/eWdppQtuhhYJXxValWvJbiqB>)
2025-07-17 19855, 2025
rayyan_seliya123
For sure so should I replicate what m.amanullah7: have done ?
2025-07-17 19852, 2025
rayyan_seliya123
Or you can create a one for the IA like as a preview for me
2025-07-17 19807, 2025
monkey[m]
I'm on it. I'll add the custom IA logo in the saqme codesandbox
2025-07-17 19830, 2025
rayyan_seliya123
monkey[m]: Great , Thx for this 👍!!
2025-07-17 19806, 2025
monkey[m]
<rayyan_seliya123> "Great , Thx for this 👍!!..." <- You're welcome. It took a bit of manipulating of the logo and some general SVG knowledge, but I got there. Update the codesandbox.
2025-07-17 19806, 2025
monkey[m]
For some reason the codesandbox isn't rendering the preview, but I tested it locally:
2025-07-17 19807, 2025
monkey[m] uploaded an image: (9KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/UdBVUUxusfliahrmXJEVGaOL/image.png >
2025-07-17 19859, 2025
mamanullah7[m]
<rayyan_seliya123> "For sure so should I replicate..." <- rayyan_seliya123: if u need you can have a look to my letest commit for reference!
Please address failing tests and any open feedback before requesting a review, so we can review fewer times.
2025-07-17 19841, 2025
rayyan_seliya123
<monkey[m]> "You're welcome. It took a bit of..." <- > <@monkey:chatbrainz.org> You're welcome. It took a bit of manipulating of the logo and some general SVG knowledge, but I got there. Update the codesandbox.
2025-07-17 19841, 2025
rayyan_seliya123
> For some reason the codesandbox isn't rendering the preview, but I tested it locally:
2025-07-17 19841, 2025
rayyan_seliya123
Yeah I have seen that it was not able to preview !
