everything working fine for fw rn! you can have a look once!
2025-07-17 19800, 2025
reosarevok[m]
aerozol, bitmap, yvanzo, ansh : if planned in advance I should be able to make most but not every meeting time even while here, so if you decide on a time or a few times let me know and I'll confirm if I can make it
Couldn't find anything in the chat about this, is it known? Or just wait for the next stat refresh?
2025-07-17 19809, 2025
lucifer[m]
[@aerozol:matrix.org](https://matrix.to/#/@aerozol:matrix.org) I think it's an issue that happens after full dumps are produced, and my understanding is that last week stats are affected. It goes away when I run stats again so a bit hard to debug but it's on my list of things to fix.
2025-07-17 19810, 2025
lucifer[m]
Can you confirm which stats are broken? I see listening activity for last week is broken
2025-07-17 19821, 2025
lucifer[m]
Are other last week stats fine?
2025-07-17 19848, 2025
lucifer[m]
And can you also check if any other time range stats are broken
2025-07-17 19829, 2025
zas[m]
lucifer: can we remove nomo VM?
2025-07-17 19857, 2025
aerozol[m]
lucifer: you get the same view as me right?
2025-07-17 19823, 2025
aerozol[m]
Hmm yeah this week/this month looks fine to me (a day+ behind but I think that's normal/due to my timezone)
2025-07-17 19803, 2025
rayyan_seliya123
Hey monkey: I am seeing the “Searching Internet Archive...” message appear at the bottom of the player when I try to play a track, which means the searchAndPlayTrack function is being called and loading is set to true.
2025-07-17 19803, 2025
rayyan_seliya123
However, I do not see any network request to '/1/internet_archive/search?...` in my browser’s network tab when I hit play , the fetch request to the API endpoint is not appearing at all.
2025-07-17 19803, 2025
rayyan_seliya123
Do you have any idea what could cause this? Is there something in the React lifecycle, player activation, or data flow that could prevent the fetch from actually being made, even though the loading state is set? Any guesses lucifer ??
2025-07-17 19858, 2025
monkey[m]
Any error in the console?
2025-07-17 19812, 2025
rayyan_seliya123
monkey[m]: Nope !
2025-07-17 19839, 2025
monkey[m]
🤷
2025-07-17 19849, 2025
monkey[m]
Will have to try and run the code locally
2025-07-17 19808, 2025
monkey[m]
Here's one thing you can try:
2025-07-17 19850, 2025
monkey[m]
Actually never mind
2025-07-17 19853, 2025
rayyan_seliya123
monkey[m]: Am i missing any more logic /code to be implemented rather thab braizplaye.tsx and BrainzPlayerSettings.tsx
2025-07-17 19815, 2025
monkey[m]
Sorry, I don't understand the question
2025-07-17 19851, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files braizplaye.tsx and BrainzPlayerSettings.tsx?
2025-07-17 19817, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files Braizplayer.tsx and BrainzPlayerSettings.tsx?
2025-07-17 19843, 2025
monkey[m]
Do you mean in general or regarding this specific issue?
2025-07-17 19857, 2025
rayyan_seliya123
* Am i missing any more logic /code to be implemented rather than the implementation I have made in these two files Braizplayer.tsx and BrainzPlayerSettings.tsx? Also in my Internetarchiveplayer.tsx
2025-07-17 19825, 2025
rayyan_seliya123
monkey[m]: In general !! Maybe this would be a cause
2025-07-17 19838, 2025
monkey[m]
I don't think so
2025-07-17 19806, 2025
monkey[m]
Do you know how to use your browser debugger to pause execution in the code, step through line by line, and all that?
2025-07-17 19822, 2025
monkey[m]
That woudl be the way to figure out what is happening in your code
2025-07-17 19823, 2025
rayyan_seliya123
Haven't tried yet ! But Will try too any steps how to
2025-07-17 19858, 2025
mayhem[m]
<aerozol[m]> "Heya ansh monkey bitmap reosarev..." <- I like it. its less ambitious than before and shouldn't be *that* much work. the only request I have is similar to my request for the LB home page: We need to make it clear that we're ethical and a data provider.
2025-07-17 19829, 2025
monkey[m]
<rayyan_seliya123> "Hey monkey: I am seeing the “..." <- So I tried faking the API response (modified listenbrainz/webserver/views/internet_archive_api.py to return a hardcoded response based on the gist you sent yesterday), and without any more modifications to the front-end, it is correctly playing the track and displaying everything correctly.
2025-07-17 19830, 2025
monkey[m] uploaded an image: (51KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/FWrKjAyGyNpLEiiGuxvzSisg/image.png >
2025-07-17 19850, 2025
monkey[m]
So, front-end is working as expected.
2025-07-17 19816, 2025
monkey[m]
I'm not able to easily test the actual internet archive api endpoint though. But considering faking the response both in the front-end and in the back-end results in functional playback, I'm goign to assume that if you have an issue it might be coming from the API endpoint/ IA cache side of things
2025-07-17 19831, 2025
monkey[m]
Now without any IA cache, and running the code exactly as currently pushed in the PR, what I get is this: I see the "searching the Internet Archive" loading text thing appear and disappear over and over as it tries to play track after track on the page, considering the API always returns 0 results for my setup (which is expected). Then I get to the end of the page and I'm left with the player looking like this:
2025-07-17 19833, 2025
monkey[m] uploaded an image: (22KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/blmWzxcLkxIlEMZEGhdCfgWv/image.png >
2025-07-17 19815, 2025
monkey[m]
Which I also expect is what would happen after not playing any actual track.
2025-07-17 19807, 2025
monkey[m]
rayyan_seliya123: Did you disable all the other music services in the BP settings page to make sure it only tries playing with the IA player?
2025-07-17 19833, 2025
rayyan_seliya123
monkey[m]: Yes always !!
2025-07-17 19802, 2025
monkey[m]
OK. Well. I'm sort of out of ideas. From what I can tell everything is working as expected on the front-end side.
2025-07-17 19839, 2025
rayyan_seliya123
Thx monkey: for your detailed review and testing I will talk with lucifer: about this and then get back to you for further frontend implementation!!
2025-07-17 19805, 2025
monkey[m]
Will leave a couple more review points
2025-07-17 19820, 2025
rayyan_seliya123
monkey[m]: Thankyou !! Sure
2025-07-17 19830, 2025
rayyan_seliya123
And what about the internet archive icon I have not used the official one so how to get the official one and update it in the brainzplayer settings page !!
2025-07-17 19853, 2025
rayyan_seliya123
Any suggestions? Would love to hear
2025-07-17 19809, 2025
monkey[m]
Ah, well you're in luck, m.amanullah7 had the same change to make.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/eWdppQtuhhYJXxValWvJbiqB>)
2025-07-17 19855, 2025
rayyan_seliya123
For sure so should I replicate what m.amanullah7: have done ?
2025-07-17 19852, 2025
rayyan_seliya123
Or you can create a one for the IA like as a preview for me
2025-07-17 19807, 2025
monkey[m]
I'm on it. I'll add the custom IA logo in the saqme codesandbox
2025-07-17 19830, 2025
rayyan_seliya123
monkey[m]: Great , Thx for this 👍!!
2025-07-17 19806, 2025
monkey[m]
<rayyan_seliya123> "Great , Thx for this 👍!!..." <- You're welcome. It took a bit of manipulating of the logo and some general SVG knowledge, but I got there. Update the codesandbox.
2025-07-17 19806, 2025
monkey[m]
For some reason the codesandbox isn't rendering the preview, but I tested it locally:
2025-07-17 19807, 2025
monkey[m] uploaded an image: (9KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/UdBVUUxusfliahrmXJEVGaOL/image.png >
2025-07-17 19859, 2025
mamanullah7[m]
<rayyan_seliya123> "For sure so should I replicate..." <- rayyan_seliya123: if u need you can have a look to my letest commit for reference!
Please address failing tests and any open feedback before requesting a review, so we can review fewer times.
2025-07-17 19841, 2025
rayyan_seliya123
<monkey[m]> "You're welcome. It took a bit of..." <- > <@monkey:chatbrainz.org> You're welcome. It took a bit of manipulating of the logo and some general SVG knowledge, but I got there. Update the codesandbox.
2025-07-17 19841, 2025
rayyan_seliya123
> For some reason the codesandbox isn't rendering the preview, but I tested it locally:
2025-07-17 19841, 2025
rayyan_seliya123
Yeah I have seen that it was not able to preview !
2025-07-17 19812, 2025
Maxr1998_ joined the channel
2025-07-17 19856, 2025
Maxr1998 has quit
2025-07-17 19855, 2025
mamanullah7[m]
<monkey[m]> "Last commit looks good at a..." <- > <@monkey:chatbrainz.org> Last commit looks good at a glance. Did you have specific requests?... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/blxdfFwgrYOpVabtQzfVlwBA>)
2025-07-17 19807, 2025
mamanullah7[m]
s/monkey: Nothin specific request as now! Frontend is working as of now!/@monkey:chatbrainz.org: Nothin specific request as now! Frontend is working fine as of now!/
2025-07-17 19851, 2025
mamanullah7[m]
Sure I'll look into the failing test
2025-07-17 19818, 2025
rayyan_seliya123
Hey monkey: with your latest suggestions including the registered blueprint one ,I have made changes on local I am observing a strange thing when I am triggering the play button I am getting a fetching request for this track `http://localhost:8100/1/internet_archive/search?track=Tu+Hi+Tu+Hai&artist=Shafqat+Amanat+Ali` which I was playing earlier on YouTube player but it is automatically getting sync with my search endpoint of
2025-07-17 19818, 2025
rayyan_seliya123
internetarchive don't know why 😅 any clue ? I think it is remianed in my queue or something?
2025-07-17 19858, 2025
rayyan_seliya123 uploaded an image: (133KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/azfllSTTdfMYNnGZadyoWjEf/Screenshot%202025-07-17%20205233.png >
2025-07-17 19806, 2025
rayyan_seliya123
also see this ^
2025-07-17 19849, 2025
monkey[m]
Is there a listen by that name on the page?
2025-07-17 19821, 2025
rayyan_seliya123
yes
2025-07-17 19821, 2025
monkey[m]
Well, it's trying to play it, then, no? I think I need more context. What are you expecting to happen and what is happening instead?
2025-07-17 19821, 2025
monkey[m]
Same question fro the screenshot, I need context
2025-07-17 19823, 2025
rayyan_seliya123
monkey[m]: > <@monkey:chatbrainz.org> Well, it's trying to play it, then, no? I think I need more context. What are you expecting to happen and what is happening instead?... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/bVkKNmrDnnIuLNwFFJlcHVYt>)
2025-07-17 19829, 2025
monkey[m]
I think I see. Basically, whatever listen is on a page, BrainzPlayer will try to play it. It does that by asking the first available datasource to do a search and play what it finds.
2025-07-17 19829, 2025
monkey[m]
If you have all other datasources disabled in your BP Settings page, then the only source BrainzPlayer can use is the IA player.
2025-07-17 19829, 2025
monkey[m]
So it tries to search in the IA cache. So far that describes exactly what we expect.
2025-07-17 19814, 2025
monkey[m]
So, for example if you had a previous listen that was listened to from Youtube, but you dicables the YT player, it will try to search for that track on the IA endpoint using the title + artist name
2025-07-17 19815, 2025
suvid[m]
Hi monkey
2025-07-17 19815, 2025
suvid[m]
The reason for not making an api endpoint was that it was implemented like this in the exports as well
2025-07-17 19815, 2025
suvid[m]
So to maintain consistency, I reused some code form exports only
2025-07-17 19839, 2025
suvid[m]
But lucifer can also help in deciding what to do I believe
2025-07-17 19842, 2025
rayyan_seliya123
monkey[m]: Yeah exactly it's happening like that only !
2025-07-17 19809, 2025
monkey[m]
rayyan_seliya123: That's not a bug though. That's what we expect would happen.
2025-07-17 19816, 2025
d4rkie has quit
2025-07-17 19817, 2025
rayyan_seliya123
monkey[m]: Ooh so should I delete this listen and try after an hour! So how I would be able to test then if this is working like that ?? Should I delete and try later
2025-07-17 19836, 2025
d4rkie joined the channel
2025-07-17 19815, 2025
monkey[m]
I think there is a fundamental misunderstanding here. You are currently testing the functionality, and from what I can tell it is working correctly.
2025-07-17 19815, 2025
monkey[m]
It tries to search for a match in the IA cache, the IA cache returns 0 results, so it does not play anything and tries to play the next listen.
2025-07-17 19815, 2025
monkey[m]
If you are talking about testing an actual match from the IA cache, you need to have a listen that has the right metadata to search
2025-07-17 19801, 2025
rayyan_seliya123
So the problem is in the backend I guess as you mentioned me !!
2025-07-17 19827, 2025
monkey[m]
I don't see a problem at the moment. What is the problem you see?
2025-07-17 19803, 2025
rayyan_seliya123
That's what I am unable to find where I am missing !!
2025-07-17 19846, 2025
monkey[m]
Is your issue that you cannot test playing a track from the IA cache?
2025-07-17 19832, 2025
rayyan_seliya123
monkey[m]: Nope I had played two three hardcoded tracks on this latest implementation it was running fine but the problem i am getting is when I am not hardcoding it rely on api on that point I am getting an issue ! Should I go ahead for an explicit search bar for this and then see what's happening?
2025-07-17 19847, 2025
monkey[m]
rayyan_seliya123: Let's stop for a second :)... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/MhJGuOfhLpAfzMbtNmeMQosA>)
2025-07-17 19850, 2025
mamanullah7[m]
rayyan_seliya123: i would recommend you shuld manually add listen any song which is available in internet archive and then set IA on top priority list and disable other services and try hope it works!
2025-07-17 19858, 2025
monkey[m]
So pick a song that you know is in the IA cache and add it as a listen on your account.
2025-07-17 19858, 2025
monkey[m]
It's easiest to do if the song is in MusicBrainz too, that way you can use the "add listen" menu on your dashboard and paste the MusicBrains URL
2025-07-17 19808, 2025
suvid[m]
lucifer: so should i make it an api endpoint like this: `app.register_blueprint(import_bp, url_prefix=API_PREFIX+'/import')`?
2025-07-17 19853, 2025
rayyan_seliya123
monkey[m]: > <@monkey:chatbrainz.org> So pick a song that you know is in the IA cache and add it as a listen on your account.
2025-07-17 19853, 2025
rayyan_seliya123
> It's easiest to do if the song is in MusicBrainz too, that way you can use the "add listen" menu on your dashboard and paste the MusicBrains URL
2025-07-17 19853, 2025
rayyan_seliya123
Sure thx will try to do this instead I see there is not a problem i understand now that brainzplayer relies on the listen info to search thbIA chache and if the song is not in the cache it just won't play anything which is expected!
suvid[m]: Yes sounds fine for now, we can change it before deploying if a better url comes to mind
2025-07-17 19847, 2025
monkey[m]
lucifer[m]: The question was about the prefix. Currently it is defined without the API_PREFIX. If the endpoint is used as an API endpoint I suggested it should have the prefix (/1/)
2025-07-17 19841, 2025
rayyan_seliya123
monkey[m]: > <@monkey:chatbrainz.org> See https://listenbrainz.readthedocs.io/en/latest/use…... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/gxueOvqOIFnCHWbsxOSoOLvQ>)
2025-07-17 19849, 2025
ansh[m]
<reosarevok[m]> "aerozol, bitmap, yvanzo, ansh..." <- Let's discuss this after the next weekly monday meeting?
2025-07-17 19838, 2025
monkey[m]
<rayyan_seliya123> "> <@monkey:chatbrainz.org> See..." <- If you need your API token, open your local LB website and in the console, inspect the page and look for the script element with id="global-react-props".
2025-07-17 19838, 2025
monkey[m]
This is a JSON object with data for the front-end. It contains an object current_user with your auth_token in it.
2025-07-17 19822, 2025
ansh[m]
monkey:
2025-07-17 19822, 2025
ansh[m]
> i am not convinced by the similar tracks being presented as a graph like the similar artists. I think the artist name at the very least is missing to make it a useful feature. Personally, I would make it a grid of listencards like we do on the top-tracks page. It would also make the tracks playable without needing to navigate to their respective pages.
2025-07-17 19823, 2025
ansh[m]
I agree, artist name should be added in the node to make the graph more informative. We can also show similar recordings in a grid format, but we'll end up not using the similarity score we have.
2025-07-17 19845, 2025
rayyan_seliya123
monkey[m]: > <@monkey:chatbrainz.org> If you need your API token, open your local LB website and in the console, inspect the page and look for the script element with id="global-react-props".
2025-07-17 19845, 2025
rayyan_seliya123
> This is a JSON object with data for the front-end. It contains an object current_user with your auth_token in it.
2025-07-17 19845, 2025
rayyan_seliya123
Sure it is super helpful for me now I'll use the submit_listens.py script and update the payload with a track which I know is in the IA cache also grab this API token as you described !!
2025-07-17 19827, 2025
monkey[m]
ansh[m]: There's definitely no space in those circles though. So you could define a new square (rounded corners?) component with enough space....which is suspiciously starting to sound like a listencard.
2025-07-17 19811, 2025
ansh[m]
Umm...true
2025-07-17 19815, 2025
monkey[m]
Do we have CAA ids for the similar tracks? If so direct benefit of using listencard is we get cover art
2025-07-17 19827, 2025
ansh[m]
lemme check
2025-07-17 19852, 2025
monkey[m]
Maybe the listenCard element can even be used directly in the SVG graph?
2025-07-17 19852, 2025
monkey[m]
With a foreignObject like I did in the top-$entity charts
2025-07-17 19806, 2025
ansh[m]
The endpoint does not give us the caa ids, but since we fetch this data in the backend, we can fetch them from the database
