-
DjSlash joined the channel
2025-08-15 22748, 2025
-
duanin2 has quit
2025-08-15 22754, 2025
-
duanin2 joined the channel
2025-08-15 22705, 2025
-
Techman has quit
2025-08-15 22727, 2025
-
Techman joined the channel
2025-08-15 22752, 2025
-
aerozol[m] has quit
2025-08-15 22707, 2025
-
__BrainzGit
2025-08-15 22707, 2025
-
BrainzBot
2025-08-15 22708, 2025
-
__BrainzGit
2025-08-15 22708, 2025
-
__BrainzGit
2025-08-15 22708, 2025
-
__BrainzGit
2025-08-15 22708, 2025
-
BrainzBot
2025-08-15 22708, 2025
-
BrainzBot
2025-08-15 22708, 2025
-
BrainzBot
2025-08-15 22712, 2025
-
__BrainzGit
2025-08-15 22734, 2025
-
lucifer[m]
2025-08-15 22729, 2025
-
lucifer[m]
2025-08-15 22707, 2025
-
lucifer[m]
also, did you test it with your own listening history?
2025-08-15 22712, 2025
-
suvid[m]
I've implemented the changes 🤔
2025-08-15 22722, 2025
-
suvid[m]
Backend tests are remaining, yes
2025-08-15 22722, 2025
-
suvid[m]
Rest all is done
2025-08-15 22750, 2025
-
lucifer[m]
yes tests are incomplete and listen validation not implemented or removed if not needed, changes to cleaning up listen imports.
2025-08-15 22743, 2025
-
lucifer[m]
okay i have made some changes to the code and will push to your PR. will add comments on what i have changed and what still needs to be done.
2025-08-15 22725, 2025
-
suvid[m]
<lucifer[m]> "yes tests are incomplete and..." <- Cleanup listen imports works now
2025-08-15 22737, 2025
-
suvid[m]
<lucifer[m]> "okay i have made some changes to..." <- Okay
2025-08-15 22737, 2025
-
suvid[m]
Thanks :)
2025-08-15 22754, 2025
-
lucifer[m]
yes i know it works but it needs to be updated. i'll add a comment on the PR on what to do.
2025-08-15 22713, 2025
-
lucifer[m]
did you test it with your listening history?
2025-08-15 22744, 2025
-
suvid[m]
I'm yet to test it with the entire history
2025-08-15 22744, 2025
-
suvid[m]
I was working on frontend tests lately
2025-08-15 22713, 2025
-
suvid[m]
lucifer: pls test the big sql query for getting details from Spotify id using the existing data
2025-08-15 22715, 2025
-
suvid[m]
In staging
2025-08-15 22737, 2025
-
monkey[m]
<rayyan_seliya123> "Hey monkey: can u pleas have a..." <- rayyan_seliya123: please remind me on monday, I'm AFK from today to monday
2025-08-15 22731, 2025
-
lucifer[m]
I updated the query and it should work fine now. but yes will test after the final batch of requested changes is done.
2025-08-15 22734, 2025
-
mamanullah7[m]
monkey: what’s the command to fix linting issue? I forgot 🫠
2025-08-15 22747, 2025
-
mamanullah7[m]
lucifer: I’ve pushed the latest changes you can have a look! I’ve taken most of the things from fw itself I’ll refactor later this weekend!
2025-08-15 22754, 2025
-
mamanullah7[m]
2025-08-15 22742, 2025
-
monkey[m]
<mamanullah7[m]> "monkey: what’s the command to..." <- All the commands are defined in the package.json file
2025-08-15 22722, 2025
-
mamanullah7[m]
Got it thanks!
2025-08-15 22729, 2025
-
fettuccinae[m] has quit
2025-08-15 22708, 2025
-
suvid[m]
lucifer: Should I define a new exception class so that I only except import failed errors in that try except finally block?
2025-08-15 22755, 2025
-
suvid[m]
* exception class in `errors.py` so that
2025-08-15 22704, 2025
-
lucifer[m]
Yes sounds good
2025-08-15 22700, 2025
-
suvid[m]
So I am catching import failed exceptions now
2025-08-15 22700, 2025
-
suvid[m]
What do I do for other exceptions that are raised?
2025-08-15 22731, 2025
-
suvid[m]
Like externalserviceerror in submit_listens function
2025-08-15 22752, 2025
-
__BrainzGit
2025-08-15 22706, 2025
-
d4rkie has quit
2025-08-15 22752, 2025
-
d4rkie joined the channel
2025-08-15 22723, 2025
-
mamanullah7[m]
2025-08-15 22735, 2025
-
pite_ has quit
2025-08-15 22738, 2025
-
__BrainzGit
2025-08-15 22739, 2025
-
BrainzBot
2025-08-15 22720, 2025
-
__BrainzGit
2025-08-15 22720, 2025
-
BrainzBot
2025-08-15 22700, 2025
-
Maxr1998 joined the channel
2025-08-15 22754, 2025
-
Maxr1998_ has quit
