Could you pls review the frontend pr whenever you're free?
2025-08-22 23400, 2025
suvid[m]
Thanks :)
2025-08-22 23421, 2025
suvid[m]
#3317
2025-08-22 23414, 2025
monkey[m]
<suvid[m]> "Hi monkey..." <- > <@suvid:matrix.org> Hi monkey... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/BISXNOtHGGYSYRnZaGfQAnPQ>)
2025-08-22 23417, 2025
d4rkie has quit
2025-08-22 23458, 2025
d4rkie joined the channel
2025-08-22 23413, 2025
suvid[m]
Yes, I feel so!
2025-08-22 23420, 2025
d4rkie has quit
2025-08-22 23447, 2025
d4rkie joined the channel
2025-08-22 23422, 2025
d4rkie has quit
2025-08-22 23449, 2025
d4rkie joined the channel
2025-08-22 23446, 2025
d4rkie has quit
2025-08-22 23426, 2025
d4rkie joined the channel
2025-08-22 23422, 2025
SigHunter has quit
2025-08-22 23408, 2025
SigHunter joined the channel
2025-08-22 23448, 2025
mamanullah7[m]
monkey: I've refactored funkwhale player and removed some inconsistency due to using different endpoint ds!
2025-08-22 23448, 2025
mamanullah7[m]
pushed the latest changes and also left some comments you can have look when you have some moment and do let me know if any thing more can be improved! pr #3289
2025-08-22 23400, 2025
mamanullah7[m]
regarding the delay while playing songs i tested playing songs https://open.audio/ and felt same i dont think this is issue from end!
holycow23: Please have a look at the failing tests on LB#3314, will review when they are fixed.
2025-08-22 23450, 2025
monkey[m]
At a quick glance the changes look fine and in line with my last review. There were also a couple of questions that I answered which will introduce more changes.
bitmap, yvanzo: please let me know if that's no longer how we add a language to beta :) btw, I think Albanian was added to beta when we meant to put it on test. I don't mind much either way, but
2025-08-22 23441, 2025
monkey[m] updates beta.LB
2025-08-22 23417, 2025
SigHunter joined the channel
2025-08-22 23452, 2025
d4rkie has quit
2025-08-22 23429, 2025
d4rkie joined the channel
2025-08-22 23450, 2025
Jade[m] has quit
2025-08-22 23408, 2025
SigHunter has quit
2025-08-22 23400, 2025
__BrainzGit
[bookbrainz-utils] 14MonkeyDo merged pull request #54 (03master…dependabot/npm_and_yarn/cleaner/sha.js-2.4.12): chore(deps): bump sha.js from 2.4.11 to 2.4.12 in /cleaner https://github.com/metabrainz/bookbrainz-utils/pu…
2025-08-22 23403, 2025
__BrainzGit
[bookbrainz-utils] 14dependabot[bot] opened pull request #55 (03master…dependabot/npm_and_yarn/cleaner/multi-c22e25d29b): chore(deps): bump brace-expansion in /cleaner https://github.com/metabrainz/bookbrainz-utils/pu…
2025-08-22 23415, 2025
mamanullah7[m]
lucifer: last time we discussed about the the trailing slash in endpoints! which was causing some errors i was exploring api responses and testing them to check the reason for inconsistency caused in FwPlayer!
2025-08-22 23415, 2025
mamanullah7[m]
surprisingly i saw `/api/v1/tracks/?q=` does exist! and also `/api/v1/tracks?q=` do exist and even i matched both endpoint response its same!
mamanullah7[m] uploaded an image: (427KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/YjRJtSTwHszgFuoeDKebJOAt/Screenshot%202025-08-22%20at%203.41.45%E2%80%AFPM.png >
2025-08-22 23422, 2025
mamanullah7[m] uploaded an image: (441KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/SyXPaVsGHNWZcZoHbKhLQyOT/Screenshot%202025-08-22%20at%203.41.36%E2%80%AFPM.png >
2025-08-22 23427, 2025
mamanullah7[m]
as of now i'm sticking with /api/v1/tracks?q= this endpoint what you say? and even refactored FwPlayer according to this only! you can have a look when you have some moments!
2025-08-22 23451, 2025
SigHunter joined the channel
2025-08-22 23437, 2025
rdswift[m] has quit
2025-08-22 23414, 2025
d4rkie has quit
2025-08-22 23455, 2025
d4rkie joined the channel
2025-08-22 23421, 2025
d4rkie has quit
2025-08-22 23403, 2025
d4rkie joined the channel
2025-08-22 23433, 2025
outsidecontext[m has quit
2025-08-22 23436, 2025
wileyfoxyx[m]
reosarevok: that'd be way nicer hehe
2025-08-22 23401, 2025
Toasty joined the channel
2025-08-22 23428, 2025
d4rkie has quit
2025-08-22 23413, 2025
d4rkie joined the channel
2025-08-22 23456, 2025
d4rkie has quit
2025-08-22 23442, 2025
d4rkie joined the channel
2025-08-22 23409, 2025
d4rkie has quit
2025-08-22 23434, 2025
d4rkie joined the channel
2025-08-22 23433, 2025
s1b1 joined the channel
2025-08-22 23443, 2025
nawcom has quit
2025-08-22 23415, 2025
d4rkie has quit
2025-08-22 23401, 2025
d4rkie joined the channel
2025-08-22 23435, 2025
d4rkie has quit
2025-08-22 23415, 2025
d4rkie joined the channel
2025-08-22 23406, 2025
mamanullah7[m]
monkey: Thanks for the review :)
2025-08-22 23406, 2025
mamanullah7[m]
I'll work on your review and if everything works fine i'll push changes by tomorrow itself and keep you posted!
2025-08-22 23432, 2025
mamanullah7[m]
about additional test surely i'll create a separate pr but before writing additional test i'll work on navidrome integration and also i've to write basic backend and frontend test!
