since none of the new listens should be imported, the existing tests passing will mean it works.
2025-09-02 24557, 2025
__BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #3316 (03master…integrating-ia-into-bp): Integrating Internet Archive recordings into Brainzplayer https://github.com/metabrainz/listenbrainz-server…
2025-09-02 24537, 2025
lucifer[m]
holycow23: just that one change needed on the PR and then its ready acc. to me.
2025-09-02 24552, 2025
lucifer[m]
m.amanullah7: missing tests on the navidrome PR.
2025-09-02 24554, 2025
monkey[m]
<lucifer[m]> "sure. fwiw you only need to..." <- Shucks, I created a new test instead... but your method makes more sense, I can revert the changes and proceed as you suggested
2025-09-02 24533, 2025
lucifer[m]
new test is fine. if you have already implemented, feel free to keep it that way
2025-09-02 24543, 2025
lucifer[m]
* is fine too. if
2025-09-02 24511, 2025
monkey[m]
Yes. I pushed the commit in question if you want to look. One thing I wasn't sure about was self.wait_for_query_to_have_items(url, num_items=0, attempts=20) since we should get 0 results, not sure this loop utility makes sense or will test appropriately.
2025-09-02 24517, 2025
mamanullah7[m]
lucifer: Working on it! Was travelling last weeek will push before Thursday!
2025-09-02 24500, 2025
mamanullah7[m]
Btw any reviews ?
2025-09-02 24507, 2025
lucifer[m]
monkey: yes, i suggest to add one valid listen to the file so that you can change it to num_items=1.
2025-09-02 24537, 2025
monkey[m]
Yeah, was thinking that. Will add said listen at the end of the file so we know the entire think has been processed
2025-09-02 24540, 2025
lucifer[m]
fwiw its batch processed (chunk size 50 iirc) . so all of it will be processed in one go but yes sounds good.
2025-09-02 24551, 2025
lucifer[m]
s/.//
2025-09-02 24508, 2025
lucifer[m]
m.amanullah7: not yet, will let you know soon
2025-09-02 24546, 2025
holycow23[m]
<lucifer[m]> "holycow23: just that one..." <- done
2025-09-02 24522, 2025
spynx is now known as spynxic
2025-09-02 24500, 2025
lucifer[m]
monkey: pushed a small change. let me know if its ready according to you. will merge after tests pass.
2025-09-02 24539, 2025
monkey[m]
Yes, perfect, thanks for the assist lucifer
2025-09-02 24533, 2025
monkey[m]
I see the failing test, let me see which of those listens is not doing what I think it should
2025-09-02 24506, 2025
kellnerd[m]
The second to last, reason "unknown"
2025-09-02 24524, 2025
kellnerd[m]
Give me a minute, I think I have a few more reason_end values to be considered.
2025-09-02 24543, 2025
monkey[m]
Wasn't sure about the "unknow" case, but I suppose it should also be ignored if played less than 30s
2025-09-02 24521, 2025
monkey[m]
Made that change now.
2025-09-02 24502, 2025
kellnerd[m]
Most of my "endplay" listens are also very short (few seconds), they are only accompanied with skipped == true since October 2022.
