I remember being horrified at the 3000 line commit last time
2025-10-22 29543, 2025
reosarevok[m]
So I would like to pick a day when you're available and start looking through it bit by bit, figuring out what has changed on each function etc
2025-10-22 29511, 2025
reosarevok[m]
And maybe we can comment with extra info about all of it in the PR for when yvanzo is back so it will help him look at it too
2025-10-22 29517, 2025
bitmap[m]
I don't think the diff for some of those files are useful to look at, it'd be better to review the new files on their own (in some cases)
2025-10-22 29522, 2025
reosarevok[m]
(seems like the kind of change that would benefit from both of us)
2025-10-22 29548, 2025
reosarevok[m]
Marking those cases in the PR is a thing that would help that review later and we could do :)
2025-10-22 29549, 2025
bitmap[m]
but yeah, let me know when you'd like to go through it together
2025-10-22 29508, 2025
reosarevok[m]
Depending on how things are looking with subscriptions we could do it tomorrow/Friday, or next week
2025-10-22 29519, 2025
reosarevok[m]
Keep me updated on how that goes :)
2025-10-22 29528, 2025
bitmap[m]
sounds good
2025-10-22 29517, 2025
reosarevok[m]
Ok, good for today - thanks! :)
2025-10-22 29522, 2025
reosarevok[m]
Time to go have dinner
2025-10-22 29554, 2025
outsidecontext[m
mayhem: Hi, Apple wants us to accept some changed agreement again :/ Can you check the Apple account for that?
2025-10-22 29503, 2025
mayhem[m]
joy
2025-10-22 29511, 2025
mayhem[m]
outsidecontext: accepted
2025-10-22 29547, 2025
outsidecontext[m
great, thanks
2025-10-22 29500, 2025
outsidecontext[m
zas: I restarted the failed CI runs, macos signing should work now
2025-10-22 29507, 2025
mayhem[m]
zas: bitmap what server is cesaria? the LB mappings are failing because the recording_first_release_date tables doesn't exist. It used to be that LB connected to prod MB for updating caches. is cesaria a replica?
2025-10-22 29542, 2025
bitmap[m]
mayhem: cesaria is the primary at the moment, it should have these tables
2025-10-22 29507, 2025
bitmap[m]
could it be a search_path issue?
2025-10-22 29548, 2025
mayhem[m]
"LEFT JOIN recording_first_release_d"
2025-10-22 29505, 2025
mayhem[m]
possibly. let me review the query in detail.
2025-10-22 29559, 2025
bitmap[m]
can confirm recording_first_release_date is in the musicbrainz schema and has data in it
2025-10-22 29513, 2025
mayhem[m]
then likely a search path issue. let me fix this query. thanks!
