I've been trying to finish this patch for the ArtistCreditEditor. basically what I've determined is that it'd be easier if it used the actual field data it its state, but we need a nicer way to attach additional state to a field
2025-10-29 30214, 2025
bitmap[m]
s/it/in/
2025-10-29 30235, 2025
bitmap[m]
since FieldT etc. are exact types and a lot of places don't like if you add additional properties to those, rn I'm adding a field_state property which can store whatever we want
2025-10-29 30236, 2025
reosarevok[m]
Naughty
2025-10-29 30257, 2025
reosarevok[m]
How are you going to make it play well with Flow?
2025-10-29 30247, 2025
bitmap[m]
it'll actually be a type parameter than you can optionally pass to FieldT/CompoundFieldT/RepeatableFieldT (but it defaults to null)
2025-10-29 30231, 2025
bitmap[m]
this does make some of the code more annoying though since e.g. state.names is now state.field.names.field
2025-10-29 30237, 2025
reosarevok[m]
heh
2025-10-29 30255, 2025
reosarevok[m]
Well we already have stuff that has field.field so
2025-10-29 30208, 2025
reosarevok[m]
I guess we'll live, if it's properly and clearly documented (wink, nudge)
2025-10-29 30221, 2025
bitmap[m]
I'll try!
2025-10-29 30225, 2025
reosarevok[m]
I've been working on converting more stuff to React
2025-10-29 30204, 2025
reosarevok[m]
Worked a bit on disc ID stuff, some of it ready, some of it in progress while I fight the kinda messy cdtoc/lookup page
2025-10-29 30216, 2025
reosarevok[m]
Nothing probably super complicated, just kinda annoying
2025-10-29 30205, 2025
reosarevok[m]
Although we have three similar, but not equivalent CDTocPossibleMediumRow, CDTocMediumListRow and CDTocReleaseListRow components now, which prooobably should be mashed together in some way or another
2025-10-29 30251, 2025
bitmap[m]
do they have any meaningful differences?
2025-10-29 30223, 2025
bitmap[m]
sounds like a good idea to combine them if not
2025-10-29 30243, 2025
reosarevok[m]
Well, they have extra columns sometimes, in different orders sometimes
2025-10-29 30207, 2025
reosarevok[m]
They're all the same general "table with info about a medium and its toggleable tracklist" but with changing contexts
2025-10-29 30235, 2025
reosarevok[m]
For now I'm converting as-is, but we can look at whether we can improve it in a subsequent commit or something
