0:53 AM
SigHunter has quit
2025-11-04 30839, 2025
1:04 AM
ApeKattQuest has quit
2025-11-04 30800, 2025
1:05 AM
MonkeyPython joined the channel
2025-11-04 30818, 2025
1:05 AM
SigHunter joined the channel
2025-11-04 30837, 2025
1:07 AM
MonkeyPython has quit
2025-11-04 30802, 2025
1:08 AM
MonkeyPython joined the channel
2025-11-04 30819, 2025
1:09 AM
MonkeyPython has left the channel
2025-11-04 30823, 2025
1:09 AM
MonkeyPython joined the channel
2025-11-04 30837, 2025
1:10 AM
MonkeyPython has quit
2025-11-04 30853, 2025
1:10 AM
MonkeyPython joined the channel
2025-11-04 30846, 2025
2:27 AM
ApeKattQuest joined the channel
2025-11-04 30800, 2025
2:29 AM
MonkeyPython has quit
2025-11-04 30831, 2025
2:29 AM
HSOWA has quit
2025-11-04 30808, 2025
2:35 AM
HSOWA joined the channel
2025-11-04 30815, 2025
2:52 AM
SigHunter has quit
2025-11-04 30802, 2025
2:54 AM
SigHunter joined the channel
2025-11-04 30827, 2025
3:03 AM
Protab joined the channel
2025-11-04 30833, 2025
3:07 AM
ApeKattQuest has quit
2025-11-04 30833, 2025
3:07 AM
rdswift[m] has quit
2025-11-04 30833, 2025
3:07 AM
HemangMishra[m] has quit
2025-11-04 30833, 2025
3:07 AM
lazybookwyrm[m] has quit
2025-11-04 30833, 2025
3:07 AM
op3kay[m] has quit
2025-11-04 30833, 2025
3:07 AM
reosarevok[m] has quit
2025-11-04 30833, 2025
3:07 AM
MatrixBrainzBot has quit
2025-11-04 30833, 2025
3:07 AM
Techman has quit
2025-11-04 30834, 2025
3:07 AM
Rotab has quit
2025-11-04 30834, 2025
3:07 AM
pite has quit
2025-11-04 30834, 2025
3:07 AM
genius3000 has quit
2025-11-04 30834, 2025
3:07 AM
tuxpaint has quit
2025-11-04 30834, 2025
3:07 AM
siina has quit
2025-11-04 30853, 2025
3:07 AM
LupinIII joined the channel
2025-11-04 30853, 2025
3:07 AM
rdswift[m] joined the channel
2025-11-04 30853, 2025
3:07 AM
HemangMishra[m] joined the channel
2025-11-04 30853, 2025
3:07 AM
lazybookwyrm[m] joined the channel
2025-11-04 30853, 2025
3:07 AM
op3kay[m] joined the channel
2025-11-04 30853, 2025
3:07 AM
reosarevok[m] joined the channel
2025-11-04 30853, 2025
3:07 AM
MatrixBrainzBot joined the channel
2025-11-04 30853, 2025
3:07 AM
pite joined the channel
2025-11-04 30853, 2025
3:07 AM
genius3000 joined the channel
2025-11-04 30853, 2025
3:07 AM
tuxpaint joined the channel
2025-11-04 30853, 2025
3:07 AM
siina joined the channel
2025-11-04 30818, 2025
3:10 AM
lusciouslover has quit
2025-11-04 30832, 2025
3:11 AM
lusciouslover joined the channel
2025-11-04 30828, 2025
3:15 AM
Techman joined the channel
2025-11-04 30819, 2025
5:45 AM
Kladky joined the channel
2025-11-04 30847, 2025
5:45 AM
d4rk-ph0enix has quit
2025-11-04 30803, 2025
6:00 AM
davic joined the channel
2025-11-04 30841, 2025
6:02 AM
d4rk-ph0enix joined the channel
2025-11-04 30812, 2025
9:31 AM
_BrainzGit
2025-11-04 30842, 2025
9:33 AM
lucifer[m]
bitmap: you can use
https://test.metabrainz.org to develop the changes for MB locally. you might need ngrok or tailscale to expose the local MB service on a public domain. alternatively you could can run the `webhooks` branch from MeB, run both MeB and MB on the same docker network.
2025-11-04 30808, 2025
9:34 AM
lucifer[m]
monkey: hi, do you have a couple of minutes to discuss registration flow UI/UX?
2025-11-04 30849, 2025
9:35 AM
lucifer[m]
mayhem, bitmap, monkey, reosarevok, yvanzo: also, let me know what time can we organize a meet this week to discuss next steps for MeB OAuth?
2025-11-04 30821, 2025
9:36 AM
mayhem[m]
I should be available EU working hours all this week.
2025-11-04 30819, 2025
9:38 AM
mayhem[m]
lucifer: let me know if any of the open PRs are ready for review.
2025-11-04 30846, 2025
9:38 AM
lucifer[m]
mayhem: all of the ones on metabrainz repo
2025-11-04 30810, 2025
9:39 AM
mayhem[m]
ok, remember to request reviews, please. but I'll have a look.
2025-11-04 30824, 2025
9:39 AM
lucifer[m]
but those are huge PRs so I am unsure what's the best way to review it
2025-11-04 30838, 2025
9:40 AM
lucifer[m]
mayhem[m]: yup it just became ready to review 5mins ago as i finished testing.
2025-11-04 30853, 2025
9:40 AM
x123 has quit
2025-11-04 30813, 2025
9:45 AM
mayhem[m]
I didnt know GitHub has a "single file mode" since the PR is too large. wow, no joking. :)
2025-11-04 30802, 2025
9:50 AM
mayhem[m]
this view is particularly difficult to review in.
2025-11-04 30845, 2025
9:51 AM
lucifer[m]
2025-11-04 30806, 2025
9:52 AM
lucifer[m]
haven't used it myself but have heard others finding it useful
2025-11-04 30845, 2025
9:56 AM
mayhem[m]
still in single file mode, so not helping. thanks though
2025-11-04 30808, 2025
9:57 AM
lucifer[m]
probably best to review locally then using vscode/pycharm or other editors
2025-11-04 30810, 2025
9:57 AM
mayhem[m]
maybe ask @mokey
2025-11-04 30826, 2025
9:57 AM
mayhem[m]
* maybe ask monkey to review the react bits?
2025-11-04 30852, 2025
9:57 AM
lucifer[m]
yup already requested a review from him
2025-11-04 30826, 2025
10:00 AM
mayhem[m]
review in vscode.. .that needs an extension I trust? which do you suggest? there is a sea of shitty AI ones.
2025-11-04 30842, 2025
10:00 AM
lucifer[m]
the official github one.
2025-11-04 30813, 2025
10:01 AM
lucifer[m]
2025-11-04 30817, 2025
10:01 AM
mayhem[m]
thx
2025-11-04 30822, 2025
10:01 AM
dabeglavins689 joined the channel
2025-11-04 30808, 2025
10:03 AM
lucifer[m]
mayhem: need a new sub-domain to host a dev instance of LB so that the team can do oauth testing? any suggestions
2025-11-04 30831, 2025
10:03 AM
mayhem[m]
2025-11-04 30846, 2025
10:03 AM
dabeglavins68 has quit
2025-11-04 30846, 2025
10:03 AM
dabeglavins689 is now known as dabeglavins68
2025-11-04 30855, 2025
10:03 AM
lucifer[m]
sure
2025-11-04 30803, 2025
10:04 AM
lucifer[m]
thanks
2025-11-04 30802, 2025
10:06 AM
mayhem[m]
except, a lot of domains are now being managed by dnscontrol. I dont recall how to do that right now. Remind me zas ?
2025-11-04 30816, 2025
10:06 AM
mayhem[m]
2025-11-04 30830, 2025
10:06 AM
lucifer[m]
yes i'll add it there
2025-11-04 30847, 2025
10:06 AM
mayhem[m]
unsure if that is the right place, TBH
2025-11-04 30847, 2025
10:06 AM
zas[m]
Yes, just edit dnscontrol.js, create a PR, wait for tests to pass, and merge if ok
2025-11-04 30824, 2025
10:07 AM
zas[m]
It is, all records are managed in this file, dnscontrol takes care of the rest
2025-11-04 30852, 2025
10:11 AM
anuj_ joined the channel
2025-11-04 30824, 2025
10:14 AM
mayhem[m]
that plugin isn't helping either, now I have deal vsvode flakiness and lagginess. I'll go back to the web view. it works.
2025-11-04 30818, 2025
10:18 AM
MonkeyPython joined the channel
2025-11-04 30801, 2025
10:21 AM
mayhem[m]
lucifer: doing anything else other than scanning for serious issues isn't going to happen. I think we should do a skim and then any follow up PRs get a lot more attention.
2025-11-04 30808, 2025
10:22 AM
lucifer[m]
mayhem: sure makes sense. if you want i can give a walkthrough of the code in the oauth meet, maybe do a video meet and others can chime in as well.
2025-11-04 30805, 2025
10:23 AM
mayhem[m]
the big picture I am getting, not problem. I'm more worried about the little stuff and the really important stuff, since this a rather critical to our overall account security
2025-11-04 30826, 2025
10:23 AM
lucifer[m]
ah okay, yes makes sense
2025-11-04 30816, 2025
10:26 AM
mayhem[m]
I cant wait to see this live, so exciting!
2025-11-04 30832, 2025
10:27 AM
reosarevok[m]
I'm off this week, lucifer, but I can talk a bit on my phone if I'm of use at some point
2025-11-04 30837, 2025
10:27 AM
reosarevok[m]
Not taking the laptop with me tho
2025-11-04 30853, 2025
10:27 AM
mayhem[m]
"of use" 🤣
2025-11-04 30833, 2025
10:28 AM
lucifer[m]
i think there's some admin stuff that would be useful to have your opinion on but we can do that separately again when you are around
2025-11-04 30812, 2025
10:29 AM
mayhem[m]
yeah, I plan to take a very careful look at all the commercial supporter stuff, since that is missing critical for me
2025-11-04 30823, 2025
10:29 AM
mayhem[m]
(in the testing phase, that is)
2025-11-04 30830, 2025
10:30 AM
lucifer[m]
2025-11-04 30811, 2025
10:31 AM
lucifer[m]
hmm one sec
2025-11-04 30825, 2025
10:31 AM
lucifer[m]
2025-11-04 30852, 2025
10:31 AM
lucifer[m]
you can create an account now, and i'll add you to admins so that you can check it out
2025-11-04 30828, 2025
10:33 AM
mayhem[m]
done.
2025-11-04 30846, 2025
10:33 AM
mayhem[m]
nice looking login workflow. works great with 1password. )
2025-11-04 30833, 2025
10:35 AM
mayhem[m]
and maybe we should ask julian to also review the oauth code?
2025-11-04 30854, 2025
10:53 AM
lucifer[m]
2025-11-04 30856, 2025
10:53 AM
monkey[m]
I mean, I can review the react bits again, but I'm the one who was working on those, so it's not the best review you'll get.
2025-11-04 30856, 2025
10:53 AM
monkey[m]
That being said I did spend a bunch of time improving the signup/login pages and left it once I was happy with it.
2025-11-04 30856, 2025
10:53 AM
monkey[m]
I'm going to have a chat with ansh this week to talk about the user profile pages which have not been worked on yet.
2025-11-04 30813, 2025
10:54 AM
lucifer[m]
sure if julian45 has the time sounds good to me.
2025-11-04 30800, 2025
10:55 AM
lucifer[m]
monkey: hi! do you have some time to discuss the registration workflow?
2025-11-04 30806, 2025
10:55 AM
monkey[m]
Sure thing
2025-11-04 30852, 2025
10:55 AM
lucifer[m]
so this is the workflow if you are a new user.
2025-11-04 30832, 2025
10:56 AM
lucifer[m] uploaded an image: (171KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/DNEQfTiUMVlRtxKnhSWKfOmz/image.png >
2025-11-04 30833, 2025
10:56 AM
lucifer[m]
click on sign in on LB or login. (create account option will/should go?)
2025-11-04 30858, 2025
10:56 AM
lucifer[m] uploaded an image: (101KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/dFBIFIcaApIruvsjIVqSwAIq/image.png >
2025-11-04 30802, 2025
10:57 AM
lucifer[m]
that takes you to LB login page
2025-11-04 30805, 2025
10:57 AM
SigHunter has quit
2025-11-04 30827, 2025
10:57 AM
mayhem[m]
lucifer: did you add me to admins?
2025-11-04 30842, 2025
10:57 AM
SigHunter joined the channel
2025-11-04 30846, 2025
10:57 AM
lucifer[m]
clicking sign in with musicbrainz takes you to
meb.org login page
2025-11-04 30849, 2025
10:57 AM
lucifer[m] uploaded an image: (235KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/KBGrxqccQAPOQIYgGzOWsXlw/image.png >
2025-11-04 30855, 2025
10:57 AM
lucifer[m]
mayhem: yes the username `rob`
2025-11-04 30813, 2025
10:58 AM
lucifer[m]
since this is the case of the user not having an account click signup
2025-11-04 30828, 2025
10:58 AM
lucifer[m]
takes you here
2025-11-04 30829, 2025
10:58 AM
lucifer[m] uploaded an image: (293KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/uatNQvdquLpkkQKSLybHvEQu/image.png >
2025-11-04 30852, 2025
10:58 AM
mayhem[m]
lucifer[m]: I signed up with "trouble" just to keep you guessing. :)
2025-11-04 30812, 2025
10:59 AM
lucifer[m] uploaded an image: (93KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/sbrpnqoceIGyoqOhFSLqopjJ/image.png >
2025-11-04 30818, 2025
10:59 AM
lucifer[m]
signing up takes you to oauth approval
2025-11-04 30831, 2025
10:59 AM
lucifer[m]
(note the email is not currently verified)
2025-11-04 30854, 2025
10:59 AM
lucifer[m] uploaded an image: (88KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/puzvUqjqllTIwzQhKcgkbrpk/image.png >
2025-11-04 30800, 2025
11:00 AM
lucifer[m]
allow access takes you to gdpr approval
2025-11-04 30807, 2025
11:00 AM
lucifer[m]
and then finally to lb dashboard
2025-11-04 30821, 2025
11:00 AM
lucifer[m] uploaded an image: (81KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/cYLcHKLFYvANNgVmqMrazYzc/image.png >
2025-11-04 30848, 2025
11:00 AM
lucifer[m]
the user is not lost anywhere but it feels a bit too long
2025-11-04 30857, 2025
11:01 AM
monkey[m]
OK, I think this is all good apart from 2 things: the LB login page is superfluous and we should remove it.
2025-11-04 30857, 2025
11:01 AM
monkey[m]
The information on that screen is mostly repeated in the GDPR screen.
2025-11-04 30857, 2025
11:01 AM
monkey[m]
2. the only thing we need to add somewhere is a notice to verify your email
2025-11-04 30820, 2025
11:02 AM
lucifer[m]
that is present on the allow access page
2025-11-04 30825, 2025
11:02 AM
lucifer[m]
but not very prominent
2025-11-04 30836, 2025
11:02 AM
monkey[m]
Ah, also: If you click "create account" you're skipping one of those step (login page > signup page)
2025-11-04 30836, 2025
11:02 AM
lucifer[m]
mayhem: ah lol, added trouble now. can you try again?
2025-11-04 30854, 2025
11:02 AM
lucifer[m]
monkey: create account should be removed i think.
2025-11-04 30808, 2025
11:03 AM
monkey[m]
Huh? Why?
2025-11-04 30827, 2025
11:03 AM
mayhem[m]
2025-11-04 30840, 2025
11:03 AM
monkey[m]
IMO it skips one click and page load, one whole step removed is good especially for a process with many steps
2025-11-04 30849, 2025
11:03 AM
lucifer[m]
2025-11-04 30825, 2025
11:04 AM
lucifer[m]
monkey: makes sense, i can implement it in a way that based on query params the users is redirected to login or signup when not logged in already.
2025-11-04 30802, 2025
11:05 AM
lucifer[m]
so that create account works
