I think i'm missing something. The usual flow I see on all other websites is two buttons like we have, one takes you to account creation, the other to signup.
2025-11-04 30829, 2025
monkey[m]
What is the issue we have with that setup?
2025-11-04 30845, 2025
lucifer[m]
that would break oauth flow.
2025-11-04 30855, 2025
lucifer[m]
in the way it is implemented currently.
2025-11-04 30855, 2025
monkey[m]
Because if I just need to sign in (already have an account), I don't want to be directed to the account creation form
2025-11-04 30826, 2025
lucifer[m]
the issue is that just creating an account signs you in metabrainz.org
2025-11-04 30836, 2025
lucifer[m]
but not on listenbrainz.org automatically even if you are redirected back
2025-11-04 30859, 2025
lucifer[m]
to ensure that a new user is redirected back and logged in, it needs to be a part of the oauth process.
2025-11-04 30828, 2025
lucifer[m]
monkey[m]: yes i'll implement it that way. that if you clicked on login, the sign in page opens. if you clicked on register, the sign up page opens.
2025-11-04 30849, 2025
monkey[m]
OK, then that sounds good to me, thanks for the explanations
2025-11-04 30804, 2025
lucifer[m]
we also need to update some of the OAuth pages.
2025-11-04 30838, 2025
lucifer[m]
well not exactly oauth but somewhere that tell you that creating an account creates accounts for you on all *Brainz websites.
2025-11-04 30813, 2025
monkey[m]
Is that what we decided in the end, the automatic creation on all *Brainz?
2025-11-04 30834, 2025
monkey[m]
If so, indeed the signup page would be the place
2025-11-04 30800, 2025
monkey[m]
It currently states "access all MetaBrainz projects", we can rework that to make it clear it creates accounts there
2025-11-04 30804, 2025
lucifer[m]
yup, because otherwise you need to check on LB whether you have a MB account or not and i don't the think the user wants to be bothered by that
2025-11-04 30848, 2025
lucifer[m]
the way it would work is that the accounts would be created on all websites but on first login you would still need to approve the permissions.
2025-11-04 30854, 2025
lucifer[m]
if that makes sense.
2025-11-04 30840, 2025
lucifer[m]
i am working on setting up LB and CB on wolf so that you and others can test this workflow and i can point using examples what i mean.
2025-11-04 30846, 2025
monkey[m]
From a user point of view I'm not sure it makes sense. If you need to accept something anyway, why not do account creation at that time?
2025-11-04 30803, 2025
monkey[m]
Yes, examples would be useful, I can tell I'm missing a lot of details that I can't wrap my head around
2025-11-04 30834, 2025
monkey[m]
> you need to check on LB whether you have a MB account or not
2025-11-04 30834, 2025
monkey[m]
This part I don't undestand
2025-11-04 30842, 2025
lucifer[m]
submitting tags/reviews etc. assumes that you alreadys have a MB account because currently you always do but it might not be the case going forward if someone registers through LB
2025-11-04 30851, 2025
lucifer[m]
s/alreadys/already/
2025-11-04 30811, 2025
lucifer[m]
unless you automatically creates accounts everywhere.
2025-11-04 30828, 2025
monkey[m]
Ah, yes I see, for tags and stuff.... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/uRmPBEFwvKpbHCDoyTPaVWuY>)
2025-11-04 30856, 2025
monkey[m]
Option 2 is definitely less friction, I suppose it is preferable
2025-11-04 30801, 2025
lucifer[m]
monkey[m]: that makes sense to me. but its hard to implement without a lot of hacks.
2025-11-04 30810, 2025
lucifer[m]
i'll try to think if i can find a way
2025-11-04 30840, 2025
lucifer[m]
currently i don't have any special cases in place. MB/LB/BB/CB are regular OAuth clients.
2025-11-04 30803, 2025
lucifer[m]
to auto approve, we would have to put in some special cases or workarounds.
2025-11-04 30821, 2025
lucifer[m]
but yes that is definitely an improvement from user perspective.
2025-11-04 30827, 2025
monkey[m]
Right, i see the issue.
2025-11-04 30806, 2025
monkey[m]
If the account on other Brainzes is basically "inactive" until you accept the oauth client permissions, I think it's probably acceptable
2025-11-04 30834, 2025
mayhem[m]
lucifer: how would you like site feedback? jira tickets?
2025-11-04 30853, 2025
lucifer[m]
mayhem[m]: Sure
2025-11-04 30808, 2025
mayhem[m]
lucifer: impressive job on the really huge task. things are looking very very good already!
2025-11-04 30831, 2025
Maxr1998 joined the channel
2025-11-04 30811, 2025
Maxr1998_ has quit
2025-11-04 30824, 2025
anuj_ has quit
2025-11-04 30851, 2025
lucifer[m]
[@mayhem:chatbrainz.org](https://matrix.to/#/@mayhem:chatbrainz.org) thanks! I'll merge all the PRs into a separate branch for now.
2025-11-04 30823, 2025
Protab has quit
2025-11-04 30845, 2025
mamanullah7[m] joined the channel
2025-11-04 30845, 2025
mamanullah7[m]
Sorry i just missed yesterday meeting! I’m mostly away from screen due to my eye infection sadly it’s appeared again and this time it was worst! I’m underway for minor surgery to clean the infections and most probably I’ll be unavailable for two weeks or more hoping to recover fast!
2025-11-04 30820, 2025
Rotab joined the channel
2025-11-04 30803, 2025
rayyan_seliya[m] joined the channel
2025-11-04 30804, 2025
rayyan_seliya[m]
<mamanullah7[m]> "Sorry i just missed yesterday..." <- Take care m.amanullah7: and have a good rest !! Hope you comeback fit and fine ! good wishes ...
2025-11-04 30807, 2025
julian45[m]
<lucifer[m]> "sure if julian45 has the time..." <- hi, which branch of the meb.o repo would be best to look at?
2025-11-04 30804, 2025
julian45[m]
i see, e.g., oauth-phase-2, but also merge-back-oauth, users, etc.
