bitmap[m]: Comments appreciated on that pull request.
2025-11-07 31103, 2025
adhawkins
Not overly happy with having to pull in the artwork-redirect somewhere else. I guess it could be a git submodule?
2025-11-07 31156, 2025
d4rkie joined the channel
2025-11-07 31131, 2025
mayhem[m]
<lucifer[m]> "mayhem, monkey, ansh, aerozol..." <- critiquebrainz worked fine.
2025-11-07 31121, 2025
mayhem[m]
LB... the sign in link in the bottom right is... actually quite well hidden now that I think of it.
2025-11-07 31116, 2025
mayhem[m]
when I click sign-in, I get the MeB "welcome back" screen with the "Don't have an account?" link greyed out, so I can't actually create an account on oauth.lb.org
mayhem[m] uploaded an image: (39KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/sjVYvkfJYZVEYtSAkYXQVett/image.png >
2025-11-07 31125, 2025
mayhem[m]
use this sign-in, dont use the create account button from the main page.
2025-11-07 31155, 2025
mayhem[m] uploaded an image: (151KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/xCGYJFWBZBkkLfZlsDyVTJzt/image.png >
2025-11-07 31107, 2025
mayhem[m]
dont have an account link is not enabled.
2025-11-07 31119, 2025
lucifer[m]
the sign up button is for that
2025-11-07 31125, 2025
lucifer[m]
*text
2025-11-07 31137, 2025
mayhem[m]
mayhem[m]: perhaps in this stack (sign in, about..) we should add a create account link as well.
2025-11-07 31114, 2025
lucifer[m]
mayhem[m]: yes could do that, monkey thoughts?
2025-11-07 31139, 2025
lucifer[m]
but for now, you can use the blue sign up text in bottom right to go to create account form.
2025-11-07 31156, 2025
mayhem[m]
using the create account button from the home page, everything works well.
2025-11-07 31116, 2025
monkey[m]
<mayhem[m]> "dont have an account link is not..." <- I was wondering if having the text to the left and the actual link to the right would be confusing... I'll look into making the whole line a link maybe
2025-11-07 31140, 2025
monkey[m]
Not opposed to a "create account" link in the navbar when users are not signed in
2025-11-07 31147, 2025
monkey[m]
(in LB that is)
2025-11-07 31136, 2025
monkey[m]
<mayhem[m]> "Source: The Verge..." <- Hah, I swear they're now copying us instead of the other way around
2025-11-07 31150, 2025
monkey[m]
<mayhem[m]> "LB... the sign in link in the..." <- mayhem: do you mean this one on the home page?
2025-11-07 31151, 2025
monkey[m] uploaded an image: (35KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/NzqnSqimRaaywBkKWsvWgTPL/image.png >
2025-11-07 31106, 2025
monkey[m]
It is pretty camouflaged...
2025-11-07 31128, 2025
mayhem[m]
monkey[m]: lysdexia strikes again.. *left* side.
2025-11-07 31145, 2025
monkey[m]
Yeah, i guess they're both easy to miss, huh.
2025-11-07 31146, 2025
mayhem[m]
<mayhem[m]> "image.png" <- here on top of the stack in grey.
2025-11-07 31131, 2025
Maxr1998 has quit
2025-11-07 31139, 2025
Maxr1998 joined the channel
2025-11-07 31115, 2025
petitminion joined the channel
2025-11-07 31157, 2025
petitminion has quit
2025-11-07 31159, 2025
petitminion joined the channel
2025-11-07 31107, 2025
julian45[m] has quit
2025-11-07 31130, 2025
petitminion has quit
2025-11-07 31116, 2025
petitminion joined the channel
2025-11-07 31140, 2025
petitminion has quit
2025-11-07 31115, 2025
bitmap[m]
adhawkins (IRC): thanks for the PR! re: pulling in the artwork-redirect code, I think we should follow how the sir service does it: copy in artwork-redirect Dockerfile, and modify it to pull the code from git
bitmap[m]: Ok, I'll update the PR to that effect. Thanks
2025-11-07 31143, 2025
adhawkins
There don't appear to be any 'releases' labelled in the artwork redirect git repo, should I just use ''master'?
2025-11-07 31107, 2025
bitmap[m]
adhawkins (IRC): good point, I just tagged master with v-2025-07-07.0
2025-11-07 31108, 2025
petitminion has quit
2025-11-07 31121, 2025
adhawkins
bitmap[m]: PR updated. How does that look? It'll need some documentation on how to activate it (unless it becomes the default)
2025-11-07 31134, 2025
bitmap[m]
adhawkins (IRC): looks good, just needs some documentation, and we'll want to add some DBDefs configuration options to the environment for `COVER_ART_ARCHIVE_DOWNLOAD_PREFIX` / `EVENT_ART_ARCHIVE_DOWNLOAD_PREFIX`
2025-11-07 31133, 2025
adhawkins
The last part means little to me I'm afraid!
2025-11-07 31142, 2025
bitmap[m]
ah, those are just DBDefs values that tell musicbrainz-server what redirect service to use. not relevant to you, since you're using libcaa
2025-11-07 31102, 2025
bitmap[m]
I can help add those to the PR
2025-11-07 31134, 2025
adhawkins
Do you need access to the original repo to be able to add to the PR?
2025-11-07 31103, 2025
bitmap[m]
I should be able to do that already ("Maintainers are allowed to edit this pull request" is visible)
