NOTICE: MBS-13874 (https://tickets.metabrainz.org/browse/MBS-13874): Clean YouTube /live/<id> and /shorts/<id> to standard /watch?v=<id>
2025-12-16 35024, 2025
op3kay[m]
@reosarevok in regard to the areabot, is it in our best interest to add a huge amount of areas to our database just as the bot does? seems like that would add a lot of unnecessary areas that wonโt be of any use
2025-12-16 35055, 2025
reosarevok[m]
Well, the original bot we ran many years ago just added all areas it could find
2025-12-16 35006, 2025
reosarevok[m]
That is overkill, we end up with a lot of tiny US villages
2025-12-16 35022, 2025
reosarevok[m]
IIRC the idea with this bot is that it would have some limit on how small a place should be for it to be added automatically
2025-12-16 35019, 2025
op3kay[m]
hm looking through the codebase it seemed like it was just pulling a lot of areas from wikidata.
2025-12-16 35024, 2025
op3kay[m]
would it be ideal to have a system where wed still use the AREQ tickets but its addition to the database would be done by a bot(using jira webhooks or so)
2025-12-16 35038, 2025
reosarevok[m]
I mean, if it adds all cities with 10k people or more, that would still be a lot of areas, for example
2025-12-16 35008, 2025
reosarevok[m]
But it's not a bad thing to have a lot of areas, as long as the system is automated - right now it's kind of embarrassing how bad our coverage is outside of Europe and the US/Canada
2025-12-16 35034, 2025
reosarevok[m]
The idea was to keep the AREQ system, but just for the kind of small areas to be added on a per-request basis
2025-12-16 35012, 2025
reosarevok[m]
Otherwise, if you still use AREQ and want the bot to do the work, you depend on people actually doing a good job of adding all the info the bot needs to the ticket. Which is not often how people work ๐
2025-12-16 35029, 2025
op3kay[m]
yea that does make sense. so are we proposing we use the bot to add areas based on population?
2025-12-16 35017, 2025
reosarevok[m]
What conditions does it currently follow?
2025-12-16 35031, 2025
reosarevok[m]
I think it should have some filtering built in even now, but I can't remember which
2025-12-16 35019, 2025
FaizanAkhtar[m]
monkey: Hi ๐
2025-12-16 35019, 2025
FaizanAkhtar[m]
While working on LB-1761....... I noticed that the All / For You selection also doesnt persist on refresh and always defaults back to For You...just wanted to check whether this should be included in the scope of this issue as well, or if I should focus only on the filters mentioned in the ticket.....
NOTICE: LB-1761 (https://tickets.metabrainz.org/browse/LB-1761): Remember explore filters between navigation
2025-12-16 35035, 2025
Sophist-UK has quit
2025-12-16 35059, 2025
reosarevok[m]
Releasing prod
2025-12-16 35034, 2025
FaizanAkhtar[m]
Got it.... Iโll focus only on lb-1761 for now...
2025-12-16 35005, 2025
Sophist-UK joined the channel
2025-12-16 35055, 2025
pite has quit
2025-12-16 35037, 2025
pite joined the channel
2025-12-16 35042, 2025
reosarevok[m]
Faizan Akhtar: no, sorry, that wasn't an answer to you :D
2025-12-16 35051, 2025
reosarevok[m]
Just letting people know I'm updating the MusicBrainz server
2025-12-16 35057, 2025
reosarevok[m]
Wait for a monkey answer
2025-12-16 35037, 2025
op3kay[m]
<reosarevok[m]> "What conditions does it currentl..." <- looking through it, it just seems to be fetching countries that are "sovereign states"
2025-12-16 35046, 2025
op3kay[m]
theres no check on population
2025-12-16 35036, 2025
reosarevok[m]
Hmm. that does seem correct
2025-12-16 35002, 2025
reosarevok[m]
Well, for subdivisions directly we don't necessarily need to have a check, but we should have it for cities. I guess this is even more half-done than I remembered
2025-12-16 35021, 2025
reosarevok[m]
A lot of cities outside of Europe will, I bet, be missing population data, but
I expect another option would be to just hardcode a bunch of stuff things can be instances of - "city" like here for example Wikidata calls "large human settlement" and it might be safe to add, while something under "village" would not, and something under "town" might be unclear too
2025-12-16 35000, 2025
op3kay[m]
wow this really messy
2025-12-16 35015, 2025
reosarevok[m]
Wikidata is messy - well, all ontologies are
2025-12-16 35033, 2025
reosarevok[m]
But Wikidata even more because it's trying to make a lot of very different data fit
2025-12-16 35047, 2025
reosarevok[m]
So for example, what qualifies as "city" depends a lot on the country
2025-12-16 35053, 2025
reosarevok[m]
The smallest one in Estonia has less than 800 people. In India, it seems like it might be minimum 100000 people?
2025-12-16 35022, 2025
reosarevok[m]
(by which measurement Estonia would have only one city, so it makes sense they have a different scale ๐ )
2025-12-16 35059, 2025
reosarevok[m]
The reality might be that the best we can do is hardcode a bunch of "instance of" values that we will auto-import
im guessing the best system in this case would be to use the bot to add major cities(like top 10) in countries using the bot. for the other outlier ones, AREQ would probably be our only good option(?)
2025-12-16 35057, 2025
reosarevok[m]
I'm happy to have anything called a city, personally - having more areas is not a bad thing (they don't generally get in the way) except when you start adding small villages, because then often they have the same name and can be confusing
2025-12-16 35026, 2025
reosarevok[m]
At least now we show more used areas higher in search
2025-12-16 35040, 2025
reosarevok[m]
So having ten Paris in the US does not hide the one in France
2025-12-16 35013, 2025
reosarevok[m]
In any case, we'd for sure have test runs first where we see what we would be importing, and see if it seems problematic and try to adjust accordingly
2025-12-16 35004, 2025
reosarevok[m]
Server updated, continuing the upgrade process :)
2025-12-16 35017, 2025
Tykling_ is now known as Tykling
2025-12-16 35007, 2025
pite has quit
2025-12-16 35023, 2025
pite joined the channel
2025-12-16 35047, 2025
op3kay[m]
<op3kay[m]> "im guessing the best system in..." <- In that case, do you think its worth working on the bot to do something like this?
2025-12-16 35037, 2025
reosarevok[m]
I mean, it's certainly worth working on the bot to get areas in (and ideally, to keep existing ones with Wikidata links up to date and add aliases in different languages too). If we test it and it is working properly
2025-12-16 35050, 2025
reosarevok[m]
Then we can always fiddle with what gets automatically added later
2025-12-16 35035, 2025
op3kay[m]
sounds good. Ill start working on it.
2025-12-16 35012, 2025
op3kay[m]
right now the repo seems to have no access to the mb test_db to actually add the data. ill try to get that setup.
2025-12-16 35026, 2025
op3kay[m]
is there anything youd like me to tackle first in it specifically ?
2025-12-16 35019, 2025
reosarevok[m]
First of all, I'd suggest seeing what works and what doesn't
2025-12-16 35037, 2025
reosarevok[m]
And get a clear idea of what is going on right now. Once that is done, we can see what the next step should be :)
2025-12-16 35004, 2025
op3kay[m]
perfect
2025-12-16 35007, 2025
monkey[m]1
<FaizanAkhtar[m]> "monkey: Hi ๐..." <- If you mean on the fresh releases page, then I think that is a good observation and a good idea to include that in your PR
2025-12-16 35001, 2025
FaizanAkhtar[m]
okay...๐
2025-12-16 35046, 2025
monkey[m]1
Faizan Akhtar: Actually the same applies to the filtering and ordering dropdowns on the top right
2025-12-16 35003, 2025
monkey[m]1
Sorry, the sorting and direction dorpdowns
2025-12-16 35020, 2025
FaizanAkhtar[m]
monkey: Thanks for pointing that out ๐
2025-12-16 35020, 2025
FaizanAkhtar[m]
Yes.....I noticed the sort and direction dropdowns reset as well...
2025-12-16 35054, 2025
monkey[m]1
That would round off your PR nicely
2025-12-16 35046, 2025
FaizanAkhtar[m]
Thanks! ๐
2025-12-16 35046, 2025
FaizanAkhtar[m]
Iโll include persistence for the sort and direction dropdowns as well and update the pr accordingly....
2025-12-16 35054, 2025
wileyfoxyx[m] has quit
2025-12-16 35000, 2025
rayyan_seliya[m]
Hey monkey: thx for pushing the pr to the test bb I just tested with multiple editions it is working fine ! now users can redirect to the source pages too... Of the book ! Looks good from my side u too can verify the behaviour in your free time and do another round of review to my pr ! Thankyou !